From patchwork Fri Mar 27 14:54:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeremy Korwin-Zmijowski X-Patchwork-Id: 20905 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6A5C227BBEA; Fri, 27 Mar 2020 15:38:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id CD97327BBE4 for ; Fri, 27 Mar 2020 15:38:13 +0000 (GMT) Received: from localhost ([::1]:43224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHr3l-0004mW-8o for patchwork@mira.cbaines.net; Fri, 27 Mar 2020 11:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49330) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHr3c-0004jB-UL for guix-patches@gnu.org; Fri, 27 Mar 2020 11:38:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHr3b-0008Iz-94 for guix-patches@gnu.org; Fri, 27 Mar 2020 11:38:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHr3b-0008IQ-5t for guix-patches@gnu.org; Fri, 27 Mar 2020 11:38:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jHr3b-0007ZW-3D for guix-patches@gnu.org; Fri, 27 Mar 2020 11:38:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#39739] Here is the patch updated Resent-From: Jeremy Korwin-Zmijowski Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 Mar 2020 15:38:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39739 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Kyle Meyer , 39739@debbugs.gnu.org Received: via spool by 39739-submit@debbugs.gnu.org id=B39739.158532345029044 (code B ref 39739); Fri, 27 Mar 2020 15:38:03 +0000 Received: (at 39739) by debbugs.gnu.org; 27 Mar 2020 15:37:30 +0000 Received: from localhost ([127.0.0.1]:33255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHr33-0007YN-7Q for submit@debbugs.gnu.org; Fri, 27 Mar 2020 11:37:30 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHqNz-0006QB-Sj for 39739@debbugs.gnu.org; Fri, 27 Mar 2020 10:55:04 -0400 X-Originating-IP: 91.169.127.99 Received: from patch (91-169-127-99.subs.proxad.net [91.169.127.99]) (Authenticated sender: jeremy@korwin-zmijowski.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D93654000F; Fri, 27 Mar 2020 14:54:56 +0000 (UTC) Message-ID: <9b5b3851902fa98a0f351ba41b0c956d9da5cf04.camel@korwin-zmijowski.fr> From: Jeremy Korwin-Zmijowski Date: Fri, 27 Mar 2020 15:54:56 +0100 In-Reply-To: <87a74dm5k0.fsf@kyleam.com> References: <581abff0066082cce54ce77cee75f88d40cebd71.camel@korwin-zmijowski.fr> <87a74dm5k0.fsf@kyleam.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-Mailman-Approved-At: Fri, 27 Mar 2020 11:37:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Le jeudi 19 mars 2020 à 02:39 +0000, Kyle Meyer a écrit : > Hi Jérémy, > > Thanks for the update and for clarifying the license with the author. > > Jeremy Korwin-Zmijowski writes: > > > +;;; Copyright © 2020 Jérémy Korwin-Zmijowski < > > jeremy@korwin-zmijowski.fr> > > This has a trivial conflict with master (4a0399e277 at the time I > applied it for testing). That'd be easy for whoever eventually > commits > your patch to clean up, but, if you resend the patch for the other > reasons I mention below, it'd be good to resolve it on your end by > moving that to a newer base. > > > +(define-public emacs-ac-geiser > > + (package > > + (name "emacs-ac-geiser") > > + (version "0.1") > > + (source > > + (origin > > You should specify a `file-name' so that the directory in the store > contains the package name. Note that you can run `guix lint' to > catch > issues like these: > > $ pre-inst-env guix lint emacs-ac-geiser > gnu/packages/emacs-xyz.scm:21842:5: emacs-ac-geiser@0.1: the source > file name should contain the package name > > > + (uri (git-reference > > + (url "https://github.com/xiaohanyu/ac-geiser.git") > > + (commit "502d18a8a0bd4b5fdd495a99299ba2a632c5cd9a"))) > > This commit is a couple of commits after the v0.1 tag, so you can > represent that with something like > > (let ((commit "abcdef...") > (revision "0")) > (package > ... > (version (git-version "0.1" revision commit)) > (source > (origin > (uri (git-reference > (url "https://github.com/xiaohanyu/ac-geiser.git") > (commit "abcdef..."))) > > You can find a good number of examples in emacs-xyz.scm. > > Because the author clarified the license in the next commit > (93818c936ee7e2f1ba1b315578bde363a7d43d05), I think that'd be a good > commit to use. > > > + (method git-fetch) > > + (sha256 (base32 > > "0h2kakb4f5hgzf5l2kpqngalcmc4402lkg1pvs88c8z4rqp2vfvz")))) > > Formatting/consistency nit: Most packages put "(base32 ..." on a new > line. I think the same is true, to a lesser extent, for the value of > propagated-inputs below. > > > + (build-system emacs-build-system) > > + (propagated-inputs `(("geiser" ,emacs-geiser) > > + ("auto-complete" ,emacs-auto-complete))) > > + (synopsis "Auto-complete backend for geiser") > > + (description "Provides one auto-complete source for Scheme > > projects using geiser.") > > + (license license:bsd-3) > > + (home-page "https://github.com/xiaohanyu/ac-geiser"))) > > Thanks! Hey Kyle, I hope this one can do the job ! As I see three commits after the 0.1 release, I valued revision to 3. Take care. Jérémy From c0bfbdfd69ac89fd092ed51cd9bbb07c0e784136 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Korwin-Zmijowski?= Date: Fri, 27 Mar 2020 15:49:53 +0100 Subject: [PATCH 1/1] gnu: Add emacs-ac-geiser. * gnu/packages/emacs-xyz.scm (emacs-ac-geiser): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 5653796731..863432f939 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -65,6 +65,7 @@ ;;; Copyright © 2020 Michael Rohleder ;;; Copyright © 2020 Brice Waegeneire ;;; Copyright © 2020 6033fe7de85d <6033fe7de85d@airmail.cc> +;;; Copyright © 2020 Jérémy Korwin-Zmijowski ;;; ;;; This file is part of GNU Guix. ;;; @@ -21774,3 +21775,27 @@ enables modal editing and composition of commands, too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Emacs conventions.") (license license:gpl3+))) + +(define-public emacs-ac-geiser + (let ((commit "93818c936ee7e2f1ba1b315578bde363a7d43d05") + (revision "3")) + (package + (name "emacs-ac-geiser") + (version (git-version "0.1" revision commit)) + (source + (origin + (uri (git-reference + (url "https://github.com/xiaohanyu/ac-geiser.git") + (commit commit))) + (method git-fetch) + (sha256 + (base32 "00n2qa26yilaj837n1yp6lbqa4gf30nkkbvanl7m9ih7k48ssqmw")) + (file-name (git-file-name name version)))) + (build-system emacs-build-system) + (propagated-inputs + `(("geiser" ,emacs-geiser) + ("auto-complete" ,emacs-auto-complete))) + (synopsis "Auto-complete backend for geiser") + (description "Provides one auto-complete source for Scheme projects using geiser.") + (license license:bsd-3) + (home-page "https://github.com/xiaohanyu/ac-geiser")))) -- 2.25.2