From patchwork Sat Mar 21 19:09:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexandros Theodotou X-Patchwork-Id: 20827 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AD62227BBEA; Sat, 21 Mar 2020 19:10:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 2A8F727BBE4 for ; Sat, 21 Mar 2020 19:10:11 +0000 (GMT) Received: from localhost ([::1]:39846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFjVa-0004SX-Mz for patchwork@mira.cbaines.net; Sat, 21 Mar 2020 15:10:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38085) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFjVT-0004SK-W4 for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFjVS-0003iU-Ja for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFjVS-0003iK-F7 for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFjVS-0000Zh-AO for guix-patches@gnu.org; Sat, 21 Mar 2020 15:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#39786] [PATCH] Add dragonfly-reverb. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 21 Mar 2020 19:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39786 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 39786@debbugs.gnu.org Received: via spool by 39786-submit@debbugs.gnu.org id=B39786.15848178002198 (code B ref 39786); Sat, 21 Mar 2020 19:10:02 +0000 Received: (at 39786) by debbugs.gnu.org; 21 Mar 2020 19:10:00 +0000 Received: from localhost ([127.0.0.1]:48027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjVQ-0000ZO-4u for submit@debbugs.gnu.org; Sat, 21 Mar 2020 15:10:00 -0400 Received: from mout02.posteo.de ([185.67.36.142]:46121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFjVN-0000Z4-IL for 39786@debbugs.gnu.org; Sat, 21 Mar 2020 15:09:58 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 55E442400FB for <39786@debbugs.gnu.org>; Sat, 21 Mar 2020 20:09:51 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 48l9F94x0jz9rxd; Sat, 21 Mar 2020 20:09:49 +0100 (CET) Message-ID: <458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org> From: Alexandros Theodotou Date: Sat, 21 Mar 2020 19:09:48 +0000 In-Reply-To: <877dzd8xly.fsf@nicolasgoaziou.fr> References: <877dzd8xly.fsf@nicolasgoaziou.fr> User-Agent: Evolution 3.32.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, Thanks for the feedback. Attaching the updated patch. I also removed some unneeded dependencies. Thanks, Alex 2020-03-21 (土) の 17:46 +0100 に Nicolas Goaziou さんは書きました: > Hello, > > Alexandros Theodotou writes: > > > This patch adds dragonfly reverb, a popular reverb plugin. > > Thank you! > > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (bin (string-append out "/bin")) > > + (vst (string-append out "/lib/vst")) > > + (lv2 (string-append out "/lib/lv2"))) > > + (mkdir-p bin) > > + (mkdir-p vst) > > + (mkdir-p lv2) > > + > > + ;; Install VST > > + (for-each > > + (lambda (file) > > + (install-file file vst)) > > + (find-files "bin" "\\-vst.so$")) > > Since you use `install-file' you don't need to `mkdir-p' beforehand, > i.e., you can drop (mkdir-p vst) above. > > > + ;; Install standalone > > + (install-file "bin/DragonflyRoomReverb" bin) > > + (install-file "bin/DragonflyHallReverb" bin) > > Ditto, you can drop (mkdir-p bin). > > > + #t)))))) > > + (inputs > > + `(("jack" ,jack-1) > > + ("libx11" ,libx11) > > + ("mesa" ,mesa))) > > + (native-inputs > > + `(("lv2" ,lv2) > > + ("pkg-config" ,pkg-config))) > > + (synopsis "Concert hall reverb and room reverb effects") > > + (description > > + "Dragonfly Reverb is a bundle of two free audio effects: a > > concert > > +hall reverb and a room reverb. Both are available as VST and LV2 > > plugins, > > You need to add two spaces after full stops. > > Could you send an updated patch? > > Regards, > From 194140d3bb34df369c585968c5ee2c93a4b41f15 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou Date: Tue, 25 Feb 2020 15:17:10 +0000 Subject: [PATCH] gnu: Add dragonfly-reverb * gnu/packages/music.scm (dragonfly-reverb): New variable. --- gnu/packages/music.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 16e69840df..1bdd905f77 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -5189,3 +5189,55 @@ featureful and easy to use. It offers unlimited automation options, LV2 plugin support, JACK support and chord assistance.") (home-page "https://www.zrythm.org") (license license:agpl3+))) + +(define-public dragonfly-reverb + (package + (name "dragonfly-reverb") + (version "2.0.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/michaelwillis/dragonfly-reverb.git") + (commit version) + ;; bundles a specific commit of the DISTRHO plugin framework + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1qrbv4kk5v6ynx424h1i54qj0w8v6vpw81b759jawxvzzprpgq72")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no check target + #:make-flags (list "CC=gcc") + #:phases + (modify-phases %standard-phases + (delete 'configure) ; no configure target + (replace 'install ; no install target + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (lv2 (string-append out "/lib/lv2"))) + ;; Install LV2 + (for-each + (lambda (file) + (copy-recursively file (string-append lv2 "/" + (basename file)))) + (find-files "bin" "\\.lv2$" #:directories? #t)) + ;; Install standalone + (install-file "bin/DragonflyRoomReverb" bin) + (install-file "bin/DragonflyHallReverb" bin) + #t)))))) + (inputs + `(("jack" ,jack-1) + ("libx11" ,libx11) + ("mesa" ,mesa))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (synopsis "Concert hall reverb and room reverb effects") + (description + "Dragonfly Reverb is a bundle of two free audio effects: a concert +hall reverb and a room reverb. Both are available as LV2 plugins as well +as JACK standalone applications.") + (home-page "https://michaelwillis.github.io/dragonfly-reverb/") + (license license:gpl3+))) -- 2.25.1