From patchwork Fri Mar 20 19:34:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ekaitz Zarraga X-Patchwork-Id: 20796 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2043627BBEA; Fri, 20 Mar 2020 19:36:13 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 7E62927BBE4 for ; Fri, 20 Mar 2020 19:36:12 +0000 (GMT) Received: from localhost ([::1]:58234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFNRE-00030b-2O for patchwork@mira.cbaines.net; Fri, 20 Mar 2020 15:36:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57118) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFNR6-0002xS-O9 for guix-patches@gnu.org; Fri, 20 Mar 2020 15:36:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFNR5-0000Uq-8N for guix-patches@gnu.org; Fri, 20 Mar 2020 15:36:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39712) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFNR4-0000UJ-Pf for guix-patches@gnu.org; Fri, 20 Mar 2020 15:36:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFNR3-00086P-MR for guix-patches@gnu.org; Fri, 20 Mar 2020 15:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Mar 2020 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40102 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: "40102\\@debbugs.gnu.org" <40102@debbugs.gnu.org>, Leo Prikler Received: via spool by 40102-submit@debbugs.gnu.org id=B40102.158473291731095 (code B ref 40102); Fri, 20 Mar 2020 19:36:01 +0000 Received: (at 40102) by debbugs.gnu.org; 20 Mar 2020 19:35:17 +0000 Received: from localhost ([127.0.0.1]:45685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFNQG-00085P-Ns for submit@debbugs.gnu.org; Fri, 20 Mar 2020 15:35:17 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:15468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFNQE-000854-90 for 40102@debbugs.gnu.org; Fri, 20 Mar 2020 15:35:11 -0400 Date: Fri, 20 Mar 2020 19:34:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1584732903; bh=mngl39b+oJXEsnPop6XC42QIahMHuWW9P8kV1yf4frs=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=k16P+08rIFcDpubRilktYycg8RCToAaW58nAuXZYZM29bynXGTsjpCK3JcSXLky5H Wym/LIBe+SRFsSotXF4mnYnbpvKIbid/p62uWUq9sBfDAjP+BkStOt+ujdI+lemQ6u OO1m3lSapG+Wi42maiscm6bdDfdvskk7UgNlUeV4= From: Ekaitz Zarraga Message-ID: In-Reply-To: <87fte29al1.fsf@devup.no> References: <87fte29al1.fsf@devup.no> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi all, Thanks Marius for the feedback. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, March 20, 2020 5:53 PM, Marius Bakke wrote: > Such "autogenerated" tarballs from GitLab and GitHub are prone to > getting re-created with different time stamps, breaking the checksum. > Can you adjust this package to use git-fetch instead of url-fetch? I wasn't aware of that! Thank you very much. > Why are tests disabled? Please leave a comment. Project doesn't have any test. > Indentation is off here. If you are not using Emacs there is a script > that can help with indentation, see "Formatting Code" in the Guix manual. I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't work very well sometimes. > > The line break here is not necessary. Solved > > - (synopsis "Displays legacy tray icons in the GNOME Shell top panel. > > +Rewritten fork of TopIcons Plus.") > > > > Please keep synopsis to single sentences. The second sentence can be > removed IMO. Done. > 'guix lint gnome-shell-extension-topicons-redux' will warn that > sentences should be separated by two spaces. Can you adjust accordingly? Done. > > - (license license:gpl2))) > > Is the license really GPL2 only? Unless the source code says explicitly > "GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later > version". Done. > > Can you send an updated patch? > Here it comes: From e62251601732587409c18dfe3af0cd56ecf39d5f Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Tue, 17 Mar 2020 13:54:24 +0100 Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux --- gnu/packages/gnome-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) -- 2.25.1 diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index b8cd32db08..39579bbea4 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2019 Giacomo Leidi ;;; Copyright © 2020 Alex Griffin ;;; Copyright © 2020 Jack Hill +;;; Copyright © 2020 Ekaitz Zarraga ;;; ;;; This file is part of GNU Guix. ;;; @@ -146,6 +147,48 @@ GNOME Shell.") (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/") (license license:gpl2+))) +(define-public gnome-shell-extension-topicons-redux + (package + (name "gnome-shell-extension-topicons-redux") + (version "6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/pop-planet/TopIcons-Redux.git") + (commit version))) + (sha256 + (base32 "1dli9xb545n3xlj6q4wl0y5gzkm903zs47p8fiq71pdvbr6v38rj")))) + (build-system gnu-build-system) + (native-inputs + `(("glib" ,glib "bin"))) + (arguments + `(#:tests? #f ; No test defined in the project + #:phases + (modify-phases + %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (invoke "make" + "install" + (string-append + "INSTALL_PATH=" + out + "/share/gnome-shell/extensions")))))))) + + (home-page "https://gitlab.com/pop-planet/TopIcons-Redux/") + (synopsis "Displays legacy tray icons in the GNOME Shell top panel.") + (description "Many applications, such as chat clients, downloaders, and +some media players, are meant to run long-term in the background even after you +close their window. These applications remain accessible by adding an icon to +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME +3.26. TopIcons Redux brings those icons back into the top panel so that it's +easier to keep track of apps running in the backround.") + (license license:gpl2+))) + (define-public gnome-shell-extension-dash-to-dock (package (name "gnome-shell-extension-dash-to-dock")