From patchwork Tue Jan 28 08:20:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Amin Bandali X-Patchwork-Id: 20005 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 988BF16369; Tue, 28 Jan 2020 08:21:10 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 2544C16352 for ; Tue, 28 Jan 2020 08:21:10 +0000 (GMT) Received: from localhost ([::1]:55288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwM7R-0006x4-Nx for patchwork@mira.cbaines.net; Tue, 28 Jan 2020 03:21:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47412) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwM7L-0006uX-9x for guix-patches@gnu.org; Tue, 28 Jan 2020 03:21:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwM7K-0007Ji-0i for guix-patches@gnu.org; Tue, 28 Jan 2020 03:21:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwM7J-0007JE-T9 for guix-patches@gnu.org; Tue, 28 Jan 2020 03:21:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iwM7J-0006jt-Sr for guix-patches@gnu.org; Tue, 28 Jan 2020 03:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#39320] [PATCH] gnu: Add emacs-mwim. Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Jan 2020 08:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 39320@debbugs.gnu.org Received: via spool by 39320-submit@debbugs.gnu.org id=B39320.158019964125860 (code B ref 39320); Tue, 28 Jan 2020 08:21:01 +0000 Received: (at 39320) by debbugs.gnu.org; 28 Jan 2020 08:20:41 +0000 Received: from localhost ([127.0.0.1]:59451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwM6y-0006j2-MR for submit@debbugs.gnu.org; Tue, 28 Jan 2020 03:20:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwM6w-0006ip-Ix for 39320@debbugs.gnu.org; Tue, 28 Jan 2020 03:20:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iwM6q-0006pJ-OP; Tue, 28 Jan 2020 03:20:32 -0500 Received: from cpe00fc8d518353-cm00fc8d518350.cpe.net.cable.rogers.com ([99.228.8.225]:59298 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iwM6q-0006Yt-CO; Tue, 28 Jan 2020 03:20:32 -0500 From: Amin Bandali Organization: GNU References: <20200127235036.14809-1-mab@gnu.org> <87pnf4m35y.fsf@nicolasgoaziou.fr> Date: Tue, 28 Jan 2020 03:20:30 -0500 In-Reply-To: <87pnf4m35y.fsf@nicolasgoaziou.fr> Message-ID: <87eevkhu0h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello, Nicolas Goaziou writes: [...] > > Thank you for the patch. > Cheers, and thank you for the feedback (addressed below). > > Is there any particular reason to prefer this particular commit over > stable 0.4 release? > > If so, it may be worth mentioning as a comment. > The main reason is that commit is a fix for a reported issue [0], but sadly isn’t part of any tagged release. Further, the repository hasn’t seen any activity in over a year, so I figured the likelihood of the author tagging a new release any time soon is pretty slim. [0]: https://github.com/alezost/mwim.el/issues/12 For what it’s worth, I’ve had this package definition in my personal Guix channel for about six months now, and no activity in the upstream repo through this time. How does the following v2 look? > > > Regards, Best, amin P.S. thanks for bumping my copyright year in emacs-xyz.scm. :-) From 3832e92daebd5fd1659f00179b5ad88bfd1aeef7 Mon Sep 17 00:00:00 2001 From: Amin Bandali Date: Tue, 28 Jan 2020 03:18:08 -0500 Subject: [PATCH v2] gnu: Add emacs-mwim. * gnu/packages/emacs-xyz.scm (emacs-mwim): New variable. --- gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index ed03c2bddd..5788f57418 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21144,3 +21144,29 @@ mercury-mode provided by Emacs as a wrapper around prolog-mode.") EBDB. It is copied more or less intact from @code{company-bbdb}, originally by Jan Tatarik.") (license license:gpl3+))) + +(define-public emacs-mwim + ;; Use the latest commit not in a release version as of yet, since it + ;; contains a bug fix for the cases where `comment-start-skip' is nil. + (let ((commit "b4f3edb4c0fb8f8b71cecbf8095c2c25a8ffbf85") + (revision "0")) + (package + (name "emacs-mwim") + (version (git-version "0.4" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/alezost/mwim.el.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0l3k611gp9g2x2vfmh92wnhnda81dslpwwpb8mxmzk308man77ya")))) + (build-system emacs-build-system) + (home-page "https://github.com/alezost/mwim.el") + (synopsis "Move to the beginning/end of line, code or comment") + (description "@code{mwim} provides several commands to switch between +various line positions, like moving to the beginning/end of code, line, or +comment.") + (license license:gpl3+)))) -- 2.25.0