From patchwork Thu Feb 24 22:53:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Langlois X-Patchwork-Id: 515 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 308C427BBEA; Thu, 24 Feb 2022 23:00:24 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C043B27BBE9 for ; Thu, 24 Feb 2022 23:00:23 +0000 (GMT) Received: from localhost ([::1]:41576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNN5y-00058C-TJ for patchwork@mira.cbaines.net; Thu, 24 Feb 2022 18:00:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNN5f-00057n-6B for guix-patches@gnu.org; Thu, 24 Feb 2022 18:00:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNN5e-0006Rg-RU for guix-patches@gnu.org; Thu, 24 Feb 2022 18:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNN5e-0000C9-Jy for guix-patches@gnu.org; Thu, 24 Feb 2022 18:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54152] [PATCH] gnu: dovecot: Fix backtrace test on aarch64. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Feb 2022 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54152 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54152@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1645743595704 (code B ref -1); Thu, 24 Feb 2022 23:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2022 22:59:55 +0000 Received: from localhost ([127.0.0.1]:50682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNN5X-0000BG-Ew for submit@debbugs.gnu.org; Thu, 24 Feb 2022 17:59:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:60262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNN5V-0000B9-Th for submit@debbugs.gnu.org; Thu, 24 Feb 2022 17:59:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNN5U-000575-If for guix-patches@gnu.org; Thu, 24 Feb 2022 17:59:53 -0500 Received: from mout.gmx.net ([212.227.17.22]:58541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNN5P-0006O6-3v for guix-patches@gnu.org; Thu, 24 Feb 2022 17:59:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645743583; bh=bIbv/x+g8qH8TmBFE6AOCDlYKq7L3t3tzMpyie0Y1hA=; h=X-UI-Sender-Class:From:To:Subject:Date; b=gR+6oIZ2PIfB6zP/u5v+Lns/3kqyp9TAsQfhKBMExgoeLHcZNdpP4XEZRiHg7hFGX cw0K7Lpfz3dp4euK9DcmG99WFxWKLoffIlZEjISP5aHwKsEB3//IRtiVoE5uVgUvSU H8jEyF6kkP35drPH5L4Q+9XIeTphWcw3v59QvDb8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MDQic-1nXqwr2OWM-00AVQ9 for ; Thu, 24 Feb 2022 23:59:43 +0100 User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Thu, 24 Feb 2022 22:53:31 +0000 Message-ID: <874k4ng9b5.fsf@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:fEuYeRB5nX1DO+CPGNR3yob/Q6SiCZMV6fM+QG4uSxksyHtE+i4 de9rJMJOSWMr55ZeIry/Qv/epqKgpRdQX8UaaBX9mBamO4fU7HbYt0L4FB0dvALHZ04ozcP +YFR1wsQm1I9DT2VLhy0i5wrQPaolI5A/hd4EujizeC+G7QF9mIzRZJml3mETLGRdUDMpGS SOU2ep40HHVOu+ULH9o7A== X-UI-Out-Filterresults: notjunk:1;V03:K0:xNEWXm43vUc=:Mwj0SCOL+67vqNV+zhVaEZ qm/isd57pXgFNo2v/1PBwS+qBRmvVwJ+HljHg5eqgn/mjXgAVzn0t86n2gzB7X2H7UoeSzDjZ ePkY86gobfTYkSLzMG9NayMBnlO23+wgq5aoieAdzlNyr8iEC2GxVQvjiGeRdQipW2LCT0Yab Mtn5lc/hSNqC+BVTHNPG1D4KbiXnvvSgr7SoHIF9rcDa+8K0iNb3Gt7TZ4W+/VsYGKLMYC6c1 pMrG9MmBC8XY2EH11mnA6IfaIMCrw5XlBPRw4LZp/4uRBBcXQum4DvwlUwUvzixPdHrfhgPBH 8RF2e63Ux27/7a1Co38Hswusx6ZRIANVDPYAl01kPj4bfygwbJQb9/LU3Kq0jNiWbYUnqlqjm 6WEb8ZiGcwJdwoB77+LTHWNJxT+EbYZRDU8HCl+nHF7k0Rm0x53FAFLEo8sGf5UnTGZQ99sjI nWBmyhhQVOM1zxA3TICKtU4zpIo0EtvPYZusQnsnD6cyGKgSpcxv9Rj3mjWRe4i71N4KckNBx PeDtnkmLB5KgVBf6jK7HmzfXkICT/cYukaJWVxnh/9eY1rtIRVAOuPa23/7F6jAcqdwjYsyi3 bx4tBNuNHupg1rpfxkufx6ZAs1lhr73a8nYqZTC5+NkqdBfoxMkfFI3fB7nbRXMkzunPoa8vz G36o4UP+Q56x7sQRCD8wdxGgCU636vYEseNPYkJ3GC6rH3Kyu2Dx+//TVnlOr6Iw3XoAZte+1 XMt9bPfvHztpBFThVTW5CJQrfGbBksNdoT8jJJt9pgNjQWP47BwawxKKZWNApvP9NucZfVzNH qy9MC835Ism8tdwPCxIEvqsE7BeRRtTIDpukGAkYkmxSamPI1PDlF75MTjumxDBXSg/KK7VNl qFlFoslmU8xC0j5lypH+8HyTy/v45Av2RXoKd6gjRWbDYGGpUvRJjWlbUfQ/MOkP7MQqso0Ho JtGpBIyjv+XSVtvbVKaBIC8HPpsEAAGNseG9IpGwWVWnWB5aaDyC/coNFb3D9qmxUTMHnEtfc x30Y+7BH1peKP1Ohqbr0SgvzM6LZiy9dB6WPRGEucnwHWTNkKQDpHbdhbbdzCDelSttCgYUIg sNzO/qBjeOWJIE= Received-SPF: pass client-ip=212.227.17.22; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Guix! Since the GCC update, dovecot doesn't build on aarch64 because the test_backtrace() tests fail :-/. What happens is the backtrace() function works but only contains addresses and no real symbol names, which the tests expect. I was going to propose disabling them, but doing some searching I found that debian fixed this by using the -rdynamic linker flag [0], and indeed, looking at GCC's documentation, they suggest using this flag for symbols to work [1]. I'm not sure why it works OK on other platforms, this flag might be on by default there. OK to push? [0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962630 [1]: https://www.gnu.org/software/libc/manual/html_node/Backtraces.html From 4a282547821196ba6d5ec494334144b528c6c9cd Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Thu, 24 Feb 2022 22:09:45 +0000 Subject: [PATCH] gnu: dovecot: Fix backtrace test on aarch64. * gnu/packages/mail.scm (dovecot)[arguments]: Add LDFLAGS=-rdynamic to make-flags. --- gnu/packages/mail.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 7a146a8603..8dce9d55b5 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -1900,6 +1900,10 @@ (define-public dovecot "--localstatedir=/var" "--with-sqlite" ; not auto-detected "--with-lucene") ; not auto-detected + ;; The -rdynamic linker flag is needed for the backtrace() function to + ;; have symbol names rather than just addresses. Dovecot's tests rely + ;; on this, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962630. + #:make-flags (list "LDFLAGS=-rdynamic") #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-file-names -- 2.34.0