From patchwork Tue Nov 12 01:21:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Divya Ranjan X-Patchwork-Id: 70268 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A4AA327BBE2; Tue, 12 Nov 2024 01:23:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7805A27BBE9 for ; Tue, 12 Nov 2024 01:23:11 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAfcY-0000z7-0o; Mon, 11 Nov 2024 20:23:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAfcU-0000yr-Ih for guix-patches@gnu.org; Mon, 11 Nov 2024 20:23:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAfcU-00079W-A4 for guix-patches@gnu.org; Mon, 11 Nov 2024 20:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=DCj6j3mycDvYq7VYLUQuddqjsynTg818YjPY412lhCc=; b=pPXgVJkub3gu1SCxnQXULM/86NqhmcMU0omrrHtuVkEvy3km14kqqIQ23mIqHw/74ifQQcH+3BUPrxpFci1dvzvO78wYdPy5qRgl63jxqkpWfqN7nFBlix4/eZ0qMSSt27yIHRA1T1y6/gSAtKNL7RzVThSzobVM3xLXDsRwIClmPii8lgDjvJfkepoVUWlYsIIsObm2Um0p5oxzZzImxsBUctwkumYAOoGf6WccBGZiMN5DT4e7FJy0drXn1xXNgu8BJV9bryPq2VVy4HBGVdInrPVsXbC3bcjfT3Nq8EfAF/eN+H15e3lFW/4pnhObchfJ5AgerxCJkO7iZwYeXg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAfcU-0007J3-4A for guix-patches@gnu.org; Mon, 11 Nov 2024 20:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74251] [PATCH] Adding jack-mixer audio package Resent-From: Divya Ranjan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Nov 2024 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74251 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga Cc: 74251@debbugs.gnu.org Received: via spool by 74251-submit@debbugs.gnu.org id=B74251.173137452928019 (code B ref 74251); Tue, 12 Nov 2024 01:23:02 +0000 Received: (at 74251) by debbugs.gnu.org; 12 Nov 2024 01:22:09 +0000 Received: from localhost ([127.0.0.1]:59786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAfbc-0007Hq-Eu for submit@debbugs.gnu.org; Mon, 11 Nov 2024 20:22:09 -0500 Received: from confino.investici.org ([93.190.126.19]:41991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAfbZ-0007Hh-Tk for 74251@debbugs.gnu.org; Mon, 11 Nov 2024 20:22:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=subvertising.org; s=stigmate; t=1731374524; bh=DCj6j3mycDvYq7VYLUQuddqjsynTg818YjPY412lhCc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RugEEpW8HosaDrQ9abO8xeksZYBl4VdjbJ7U0+RNHwqQAFeIFUmjGtP30+WZrOTR/ x/lFHPJWf6uywzydaYHXMDlAAVIVynTVDJkR4sKLr1wIh4sZrZNZktgn2zbmorMSMa YVUr+DVjfNxCc2w+z5EF4+1umFJwS8vjT/8wNO1w= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4XnTCw3sqkz10yH; Tue, 12 Nov 2024 01:22:04 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: divya@subvertising.org) by localhost (Postfix) with ESMTPSA id 4XnTCv5z9wz10yC; Tue, 12 Nov 2024 01:22:03 +0000 (UTC) In-Reply-To: (Ekaitz Zarraga's message of "Mon, 11 Nov 2024 22:19:06 +0100") References: <87r07ibmcs.fsf@subvertising.org> <4258e857-4d68-4692-81c4-099fb4adc1fe@elenq.tech> <87jzd9zqv5.fsf@subvertising.org> <51729a6a-e1f9-48e6-814a-b1a28f0558df@elenq.tech> <875xotzhdx.fsf@subvertising.org> Date: Tue, 12 Nov 2024 01:21:57 +0000 Message-ID: <87y11pxn4a.fsf@subvertising.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Divya Ranjan X-ACL-Warn: , Divya Ranjan via Guix-patches X-Patchwork-Original-From: Divya Ranjan via Guix-patches via From: Divya Ranjan Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Ekaitz Zarraga writes: > On 2024-11-11 20:42, Divya Ranjan wrote: >> Ekaitz Zarraga writes: >> >>> Sorry mate I didn't explain it properly. >>> >>> The commit message has two parts: a title and a body. >>> >>> The title you used before was correct, you were only missing the >>> body. This is how the whole commit message should look like: >>> >>> gnu: audio: Add jack-mixer >>> >>> * gnu/packages/audio.scm (jack-mixer): New variable. >>> >> Okay, I think this is the final patch. >> Regards, > > Yes, this is almost there but there are still a couple of warnings by > `guix lint`: > > jack-mixer@19: the source file name should contain the package name > > This is complaining because when it clones the source code it is > called "jack_mixer" but your package is called "jack-mixer" > instead. You could fix it using something like this in the `origin`: > > (file-name (git-file-name name version)) > > If you add that and fix the indentation (you can use `guix style` for > that), I think this is ready to go. > > You are almost there! > > PS: The other warning I think we can ignore for the moment. We have > some other packages with the same warning I think it's because of the > expansion of the `(,gtk+ "bin") > Added the necessary changes. Regards, From df1ddf6d262f432f6b777cd6b9999679679749a8 Mon Sep 17 00:00:00 2001 From: Divya Ranjan Date: Mon, 11 Nov 2024 23:44:44 +0000 Subject: [PATCH] gnu: audio: Add jack-mixer * gnu/packages/audio.scm (jack-mixer): New variable Change-Id: I0b278f8674c84a4f43f9d23afc900b0a53e11f7c --- gnu/packages/audio.scm | 59 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 467dc4a74f..8ef87264a0 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2772,6 +2772,65 @@ (define-public jacktrip audio signal streaming.") (license (list license:gpl3+ license:lgpl3 license:expat)))) +(define-public jack-mixer + (package + (name "jack-mixer") + (version "19") + (source + (origin + (file-name (git-file-name name version)) + (method git-fetch) + (uri (git-reference + (url "https://github.com/jack-mixer/jack_mixer") + (commit (string-append "release-" version)))) + (sha256 + (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj")))) + (build-system meson-build-system) + (arguments + (list + #:build-type "release" + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'path-patch + (lambda _ + (substitute* '("meson.build") + (("'/', 'etc', 'xdg'") + (string-append "'" + #$output "'"))))) + (add-after 'install 'wrap-path + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin/")) + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (version #$(version-major+minor (package-version + (this-package-input + "python")))) + (lib (string-append out "/lib/python" version + "/site-packages"))) + (wrap-program (string-append bin "jack_mixer") + `("GUIX_PYTHONPATH" ":" prefix + (,(getenv "GUIX_PYTHONPATH") ,lib)) + `("GI_TYPELIB_PATH" ":" prefix + (,gi-typelib-path))))))))) + (native-inputs (list pkg-config python-cython python-docutils + gettext-minimal glib)) + (inputs (list bash-minimal)) + (propagated-inputs (list gtk+ + `(,gtk+ "bin") + python + python-wrapper + python-pygobject + python-pycairo + python-platformdirs + jack-2)) + (synopsis + "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit") + (description + "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling +similar to hardware mixing desks. It has lot of useful features, apart +from being able to mix multiple JACK audio streams.") + (home-page "https://rdio.space/jackmixer/") + (license license:gpl2+))) + (define-public jalv (package (name "jalv") -- 2.46.0