From patchwork Wed Nov 6 10:46:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariqq X-Patchwork-Id: 69921 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 82C9B27BBEA; Wed, 6 Nov 2024 11:05:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3FD4B27BBE2 for ; Wed, 6 Nov 2024 11:05:27 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8dqa-0005FB-Uh; Wed, 06 Nov 2024 06:05:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dqY-0005DD-LN for guix-patches@gnu.org; Wed, 06 Nov 2024 06:05:10 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8dqY-0005Aq-1C; Wed, 06 Nov 2024 06:05:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=0Po3pIUmPxkCEJGAFHRVRL+3DxlUrWMlKVyqjhSNN3E=; b=ccaLTowU/eMMEvb/lo+u2BpDV/4lRU407rPdxRmWxZoBRbl/PRReg8sPSrtosLPiEoc4D7Kmd/zhrAN4m839yVXVOeZam50zkbVNVT0AUoSKqh1qJ7N/MvAta7q9VJHwI2MpKf1tevl2gd/DhqzoVvUmxA75Pt8xTxroaFKlSujsTzNPDR7VsHHwezTs4VMI7sOElL09LU0rY0Pii+p4AgsarmYyCsBsq/HM6QjZClKQCI/AyVGjfTKp88hVuZNTBsaXGVn/lP24u2cmDcOE2IzA89Pm/DK6Nb0A0CTPr9ovEWi7UZc38HK6n0JnbF3QsbmE/KSEeGhaqUmf7w+VTA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t8dqQ-0001P5-Fh; Wed, 06 Nov 2024 06:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Wed, 06 Nov 2024 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74225@debbugs.gnu.org Cc: Dariqq , Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.17308910675344 (code B ref -1); Wed, 06 Nov 2024 11:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Nov 2024 11:04:27 +0000 Received: from localhost ([127.0.0.1]:39827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dpq-0001O7-Ri for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:52142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8dpp-0001O0-5l for submit@debbugs.gnu.org; Wed, 06 Nov 2024 06:04:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dpo-00050K-2a for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:24 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dpl-0003Pv-V9 for guix-patches@gnu.org; Wed, 06 Nov 2024 06:04:23 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5B6BB240101 for ; Wed, 6 Nov 2024 12:04:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730891058; bh=MeVpO/FJe0uvlSAVeGsygioCK66q4Tysb/ENi28fL7c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=LpTUtv/Qqc5FQW0Sk4ayxWo4KxYYgshMb3e76TASbS2WNi1LCkLlLNP1oDGkgDy7M al+V6smaA+8S+5Fexv2ytcMED83sthtEMlfBwDguX3RZlw0QxE5ZC4p/tUbpEfXAYT LfxQSaqwCXb6XRagIKwBt4JE0HclhiYWZBE2fpg7hCr6/bzufJO2lnzhNISy6IyPA+ ytJV3QxBZ/dQzTkbSzNmSuSshekAfIFDXi2TGAAz9oC/qJ+BwKcaF3mk23oNDZ5ysh WZQKj5mL68tzJXTpamTmcaFpK/KAiOXv/smLfqISiDrfRaNHvjbnFWG31IGkfSWWHp 2TAqmez5u6agQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Xk2QT5tf4z9rxQ; Wed, 6 Nov 2024 12:04:17 +0100 (CET) From: Dariqq Date: Wed, 6 Nov 2024 10:46:48 +0000 Message-ID: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> MIME-Version: 1.0 Received-SPF: pass client-ip=185.67.36.66; envelope-from=dariqq@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * guix/lint.scm (check-optional-tests): Also check for add-before and add-after when adding custom 'check phases. Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a --- Hi, Stumbled upon a test failure in u-boot-utils today which is not using #:tests? for its custom 'check phase but not being detected by the linter. Reason is that the 'check phase is added after 'install and not just replacing it. This little patch makes it it possible to detect it and adds 38 more warnings. guix/lint.scm | 4 ++++ 1 file changed, 4 insertions(+) base-commit: 0c1a6db8094dc6b20762eceae369daae545fc5e4 diff --git a/guix/lint.scm b/guix/lint.scm index 8c6c20c723..4ba728da33 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) (match delta (`(replace 'check ,expression) (check-check-procedure expression)) + (`(add-after ,_ 'check ,expression) + (check-check-procedure expression)) + (`(add-before ,_ 'check ,expression) + (check-check-procedure expression)) (_ '()))) (define (check-phases-deltas deltas) (append-map check-phases-delta deltas))