From patchwork Fri Dec 20 18:37:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Martin Becze X-Patchwork-Id: 16585 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 48B531794E; Fri, 20 Dec 2019 18:38:19 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 182ED17940 for ; Fri, 20 Dec 2019 18:38:18 +0000 (GMT) Received: from localhost ([::1]:60498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiNAH-0006W8-GT for patchwork@mira.cbaines.net; Fri, 20 Dec 2019 13:38:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58254) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiNA8-0006Tg-8v for guix-patches@gnu.org; Fri, 20 Dec 2019 13:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiNA3-00011f-Vn for guix-patches@gnu.org; Fri, 20 Dec 2019 13:38:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iiNA2-00010C-8f for guix-patches@gnu.org; Fri, 20 Dec 2019 13:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iiNA2-00051s-5a for guix-patches@gnu.org; Fri, 20 Dec 2019 13:38:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38408] [PATCH v4 1/6] gnu: added new function, find-packages-by-name*/direct Resent-From: Martin Becze Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Dec 2019 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38408 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: 38408@debbugs.gnu.org Received: via spool by 38408-submit@debbugs.gnu.org id=B38408.157686706919314 (code B ref 38408); Fri, 20 Dec 2019 18:38:02 +0000 Received: (at 38408) by debbugs.gnu.org; 20 Dec 2019 18:37:49 +0000 Received: from localhost ([127.0.0.1]:47244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiN9j-00051M-NA for submit@debbugs.gnu.org; Fri, 20 Dec 2019 13:37:49 -0500 Received: from mx1.riseup.net ([198.252.153.129]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiN9g-00051C-4m for 38408@debbugs.gnu.org; Fri, 20 Dec 2019 13:37:41 -0500 Received: from capuchin.riseup.net (capuchin-pn.riseup.net [10.0.1.176]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 47fctW0t5lzDvqM; Fri, 20 Dec 2019 10:37:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1576867059; bh=cHP+xD+ZJ0K9c5IqwHCPSiboA8DUMHdb4ztokfzcUAA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HcM+lr5ACXtF6AOkAIlMct9ppm+zfoLevz6o6l0dfc7z4DaUrtw625SHkS3r/2OkH 5rs/PquiumW2apo3Etmddvlk4UK4y8sd68NnT6nI0B/J0/2+8msWzSVDt/s5Y8zeJE BOQOSQDJSC7jNzxfXjIIh83o2xUdcUDUZqlfuHFc= X-Riseup-User-ID: 591F6F048A878B74046AF108F741057D19F41DCBC0972CA6AB297849DBF35AB6 Received: from [127.0.0.1] (localhost [127.0.0.1]) by capuchin.riseup.net (Postfix) with ESMTPSA id 47fctV5TNgz8tXp; Fri, 20 Dec 2019 10:37:38 -0800 (PST) MIME-Version: 1.0 Date: Fri, 20 Dec 2019 10:37:38 -0800 From: Martin Becze In-Reply-To: <877e2sm0vv.fsf@gnu.org> References: <877e2sm0vv.fsf@gnu.org> Message-ID: <6e56589639ea75bfec2c97f7e9e31ad9@riseup.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches > > Providing an explicit cache bypassing method also sounds worrying to me: > the cache is supposed to be transparent and semantics-preserving. > > More generally, I think adding new features to an importer shouldn’t > require modifications in this area, as a matter of separating concerns. > > WDYT? > > Thanks, > Ludo’. yes I agree, I removed that in the last version! Which also rebases off the new topological sort procedure. I'll attach the latest patches here, in case you missed it. From aa6aaeacb5f91508f4158999ba6e7f95e8309bed Mon Sep 17 00:00:00 2001 From: Martin Becze Date: Mon, 16 Dec 2019 18:11:38 -0500 Subject: [PATCH v5 4/4] gnu: scripts: import: crate: Remove `define-public` generation from UI * guix/scripts/import/crate.scm (guix-import-crate): Remove `define-public` generation from UI --- guix/scripts/import/crate.scm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/guix/scripts/import/crate.scm b/guix/scripts/import/crate.scm index 92034dab3c..9a08c9b8b4 100644 --- a/guix/scripts/import/crate.scm +++ b/guix/scripts/import/crate.scm @@ -95,12 +95,7 @@ Import and convert the crate.io package for PACKAGE-NAME.\n")) (package-name->name+version spec)) (if (assoc-ref opts 'recursive) - (map (match-lambda - ((and ('package ('name name) . rest) pkg) - `(define-public ,(string->symbol name) - ,pkg)) - (_ #f)) - (crate-recursive-import name)) + (crate-recursive-import name version) (let ((sexp (crate->guix-package name version))) (unless sexp (leave (G_ "failed to download meta-data for package '~a'~%") -- 2.24.1