From patchwork Thu Dec 19 12:44:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Prikler X-Patchwork-Id: 16564 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D3A331794C; Thu, 19 Dec 2019 13:13:47 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 7D0501794A for ; Thu, 19 Dec 2019 13:13:47 +0000 (GMT) Received: from localhost ([::1]:40924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihvcg-00077H-Kt for patchwork@mira.cbaines.net; Thu, 19 Dec 2019 08:13:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33967) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihvAu-0001jV-8Y for guix-patches@gnu.org; Thu, 19 Dec 2019 07:45:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihvAs-0005Iu-P5 for guix-patches@gnu.org; Thu, 19 Dec 2019 07:45:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38375) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihvAs-0005FK-7b for guix-patches@gnu.org; Thu, 19 Dec 2019 07:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihvAs-00068w-5U for guix-patches@gnu.org; Thu, 19 Dec 2019 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38538] [PATCH] gnu: Add gnome-shell-extension-hide-app-icon Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Dec 2019 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38538 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 38538@debbugs.gnu.org Received: via spool by 38538-submit@debbugs.gnu.org id=B38538.157675950123592 (code B ref 38538); Thu, 19 Dec 2019 12:45:02 +0000 Received: (at 38538) by debbugs.gnu.org; 19 Dec 2019 12:45:01 +0000 Received: from localhost ([127.0.0.1]:44348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihvAq-00068R-Nn for submit@debbugs.gnu.org; Thu, 19 Dec 2019 07:45:01 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:16795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihvAm-00068G-Q5 for 38538@debbugs.gnu.org; Thu, 19 Dec 2019 07:44:58 -0500 Received: from nijino.local (193-81-98-224.hdsl.highway.telekom.at [193.81.98.224]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 47ds5x0svNz1LgH5; Thu, 19 Dec 2019 13:44:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 47ds5x0svNz1LgH5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1576759493; bh=y7tb9B2zaudBshVnw4bXqHxIMUQRygF5gH2pZvty338=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=bB2ycRF3BpV6IQcPQ67xiAVtSICi1EbyGJ2pufPRRCPqeC4bamcFbIvdCnMVP4Q3Q olD/O0shdnIHb3QxMjRc3Tmet6fFW5msQRJ8C55gqP2MwJ/cWpSk81MQ4lqOI0FYb6 k7uwjz/OQr9wPogvPgqXpRXD55XBKi1Ndgv/6rjk= Message-ID: <15831159f236fe1a0e31d5882580c4d049a9522b.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 19 Dec 2019 13:44:47 +0100 In-Reply-To: References: <20191208201249.5479-1-leo.prikler@student.tugraz.at> <20191219092004.GE917@E5400> User-Agent: Evolution 3.32.4 MIME-Version: 1.0 X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Am Donnerstag, den 19.12.2019, 12:00 +0100 schrieb Leo Prikler: > Am Donnerstag, den 19.12.2019, 11:20 +0200 schrieb Efraim Flashner: > > What does this need glib and glib:bin for? Is it just for building > > the > > schemas or does it actually need it at runtime? > To be honest, I'm not quite sure. I've copied this part from my > dash- > to-dock extension, wherein I copied it from the gnome-shell- > extensions > package. > > As far as I'm aware both packages do build schemas, but I'm not sure > how extensions handle them at runtime. Perhaps this is already wrong > in the package I originally copied the snippet from. I'll try to see > how far I can get with depropagation. > > Regards, > Leo Upon closer inspection, it appears depropagation is indeed possible. See the attached patch. From 8b468ac52e55560e8581a4b93ddefba00dbfab62 Mon Sep 17 00:00:00 2001 From: Leo Prikler Date: Thu, 19 Dec 2019 13:31:58 +0100 Subject: [PATCH 2/2] gnu: Depropagate glib from GNOME Shell extensions * gnu/packages/gnome.scm (gnome-shell-extensions): Drop propagated inputs, move them to more appropriate place. [propagated-inputs]: Removed field. [native-inputs] : New input. [inputs] : New input. * gnu/packages/gnome-xyz.scm (gnome-shell-extension-dash-to-dock): Likewise. (gnome-shell-extension-hide-app-icon): Likewise. --- gnu/packages/gnome-xyz.scm | 16 ++++++++-------- gnu/packages/gnome.scm | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index 148f1db646..9dff38fa39 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -140,11 +140,11 @@ the Obsidian icon theme.") (delete 'bootstrap) (delete 'configure)))) (native-inputs - `(("intltool" ,intltool) + `(("glib:bin" ,glib "bin") + ("intltool" ,intltool) ("pkg-config" ,pkg-config))) - (propagated-inputs - `(("glib" ,glib) - ("glib" ,glib "bin"))) + (inputs + `(("glib" ,glib))) (synopsis "Transforms GNOME's dash into a dock") (description "This extension moves the dash out of the overview, transforming it into a dock for easier application launching and @@ -182,12 +182,12 @@ faster window switching.") (mkdir-p (string-append (assoc-ref outputs "out") "/share/gnome-shell/extensions"))))))) (native-inputs - `(("intltool" ,intltool) + `(("glib:bin" ,glib "bin") + ("intltool" ,intltool) ("unzip" ,unzip) ("zip" ,zip))) - (propagated-inputs - `(("glib" ,glib) - ("glib" ,glib "bin"))) + (inputs + `(("glib" ,glib))) (synopsis "Hide app icon from GNOME's panel") (description "This extension allows to hide the icon and/or title of the currently focused application in the top panel of the GNOME shell.") diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 77d96987d6..117937a9ba 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -7537,11 +7537,11 @@ GNOME Shell appearance and extension, etc.") (arguments '(#:configure-flags '("-Dextension_set=all"))) (native-inputs - `(("intltool" ,intltool) + `(("glib" ,glib "bin") + ("intltool" ,intltool) ("pkg-config" ,pkg-config))) - (propagated-inputs - `(("glib" ,glib) - ("glib" ,glib "bin"))) + (inputs + `(("glib" ,glib))) (synopsis "Extensions for GNOME Shell") (description "GNOME Shell extensions modify and extend GNOME Shell functionality and behavior.") -- 2.24.1