From patchwork Tue Apr 9 11:06:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Graves X-Patchwork-Id: 62888 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CACD327BBE9; Tue, 9 Apr 2024 12:08:29 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6078127BBE2 for ; Tue, 9 Apr 2024 12:08:28 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ru9KW-0003cP-3L; Tue, 09 Apr 2024 07:07:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru9KU-0003c6-Hx for guix-patches@gnu.org; Tue, 09 Apr 2024 07:07:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru9KU-0005VS-8m for guix-patches@gnu.org; Tue, 09 Apr 2024 07:07:54 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ru9Kb-00005B-VT for guix-patches@gnu.org; Tue, 09 Apr 2024 07:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70308] [PATCH] guix: http tests: Log bad requests. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Apr 2024 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70308 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70308@debbugs.gnu.org Cc: ngraves@ngraves.fr X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171266083732563 (code B ref -1); Tue, 09 Apr 2024 11:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Apr 2024 11:07:17 +0000 Received: from localhost ([127.0.0.1]:48462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru9Jr-0008Su-TC for submit@debbugs.gnu.org; Tue, 09 Apr 2024 07:07:17 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru9Jf-0008Re-Mt for submit@debbugs.gnu.org; Tue, 09 Apr 2024 07:07:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru9JO-0002pO-7l for guix-patches@gnu.org; Tue, 09 Apr 2024 07:06:47 -0400 Received: from 1.mo560.mail-out.ovh.net ([46.105.63.121]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru9JK-0004xJ-EC for guix-patches@gnu.org; Tue, 09 Apr 2024 07:06:45 -0400 Received: from director2.ghost.mail-out.ovh.net (unknown [10.108.25.248]) by mo560.mail-out.ovh.net (Postfix) with ESMTP id 4VDNSY3rQJz1SmQ for ; Tue, 9 Apr 2024 11:06:37 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-5j9bm (unknown [10.111.182.240]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id EA2381FD7A; Tue, 9 Apr 2024 11:06:35 +0000 (UTC) Received: from ngraves.fr ([37.59.142.110]) by ghost-submission-6684bf9d7b-5j9bm with ESMTPSA id 5zxSLDshFWbjcQ0A5fxlpg (envelope-from ); Tue, 09 Apr 2024 11:06:35 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-110S004580f7955-ada2-490e-994b-6e2b8ed4fd8d, E694A2EEB8DE3E60D9283BD588F72EE4EA3BAC6A) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 81.67.146.208 Date: Tue, 9 Apr 2024 13:06:32 +0200 Message-ID: <20240409110632.31710-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Ovh-Tracer-Id: 2395070579422782178 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrudehtddgtdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepkeffgeetfffgffejgeejvdffgfdtvdeuueetgfefuedvjeegvdegjeejveeuueevnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugeeirddvtdekpdefjedrheelrddugedvrdduuddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheeitddpmhhouggvpehsmhhtphhouhht Received-SPF: pass client-ip=46.105.63.121; envelope-from=ngraves@ngraves.fr; helo=1.mo560.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches X-Patchwork-Original-From: Nicolas Graves via Guix-patches via From: Nicolas Graves Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * guix/test/http.scm (call-with-http-server): Log bad requests to make debugging easier. Change-Id: I2bb7231db1e5cd9a6e1c4cf76d256fa7c9e50776 --- guix/tests/http.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/guix/tests/http.scm b/guix/tests/http.scm index 17485df9ef..e02f91923c 100644 --- a/guix/tests/http.scm +++ b/guix/tests/http.scm @@ -132,8 +132,10 @@ (define-server-impl stub-http-server http-write (@@ (web server http) http-close)) - (define bad-request - (build-response #:code 400 #:reason-phrase "Unexpected request")) + (define (bad-request req) + (build-response + #:code 400 + #:reason-phrase (string-append "Unexpected request: " req))) (define (server-body) (define (handle request body) @@ -144,7 +146,7 @@ (define (handle request body) ((((? string?) response data) ...) (let ((path (uri-path (request-uri request)))) (match (assoc path responses) - (#f (values bad-request "")) + (#f (values (bad-request path) "")) ((_ response data) (if (eq? 'GET (request-method request)) ;; Note: Use 'assoc-remove!' to remove only the first entry @@ -153,7 +155,7 @@ (define (handle request body) (let ((rest (assoc-remove! responses path))) (set! responses rest) (values response data)) - (values bad-request "")))))))) + (values (bad-request path) "")))))))) (let-values (((socket port) (open-http-server-socket))) (set! %http-real-server-port port)