From patchwork Sat Jan 20 09:06:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vivien Kraus X-Patchwork-Id: 59176 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AD59127BBE9; Sat, 20 Jan 2024 09:07:16 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2C24027BBE2 for ; Sat, 20 Jan 2024 09:07:14 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rR7Jd-0002un-VU; Sat, 20 Jan 2024 04:07:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR7Jc-0002uY-CS for guix-patches@gnu.org; Sat, 20 Jan 2024 04:07:00 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rR7Jc-0002l8-4A for guix-patches@gnu.org; Sat, 20 Jan 2024 04:07:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rR7Je-0003kg-D3 for guix-patches@gnu.org; Sat, 20 Jan 2024 04:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68556] [PATCH gnome-team v3 3/7] gnu: gnome-shell-extension-noannoyance: Switch to fork. Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Jan 2024 09:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68556 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 68556@debbugs.gnu.org Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com Received: via spool by 68556-submit@debbugs.gnu.org id=B68556.170574160414392 (code B ref 68556); Sat, 20 Jan 2024 09:07:02 +0000 Received: (at 68556) by debbugs.gnu.org; 20 Jan 2024 09:06:44 +0000 Received: from localhost ([127.0.0.1]:60810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7JL-0003k2-T4 for submit@debbugs.gnu.org; Sat, 20 Jan 2024 04:06:44 -0500 Received: from planete-kraus.eu ([89.234.140.182]:48486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7JJ-0003jk-38 for 68556@debbugs.gnu.org; Sat, 20 Jan 2024 04:06:42 -0500 Received: from planete-kraus.eu (localhost [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 5829becc; Sat, 20 Jan 2024 09:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version; s=albinoniA; bh=HQsX8XSAdufjE1+BLlBl t2aNx80=; b=hgTWyRYEySCCF6Kx1bzdJVFauUMH8Tb0nNwnZotKRrVrbCoEFOE3 mULOtgtOqPrqUaBxnVc/GmHcmx0LQjCEPJ/M+UxumHshEkdVI6eyG037HjJUwrmS +Cq2WiHwhAlfo5WSS5OQiNXRTsinXJVIQdHzsK64jdyWqma/wOdmVz9UfTIi176z iXnS8gCFnJa+OYQC+BqTxXYsCSk9NEVX1shHCrQs6NYS75Tvk49e6q3sh8YZnG9j UUNJBvLmkKsuPr9WgC58JMbLDLuuOa7NyhKb11JGef7eLL9VX34SDE0K247k4zFb PPoX1R0izImlsgoLo3TPtpHJltFoXmFikA== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 96c89b14 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sat, 20 Jan 2024 09:06:31 +0000 (UTC) Message-ID: Date: Sat, 20 Jan 2024 10:06:29 +0100 In-Reply-To: <9b94f2224fb2d05071d260870bc03cbebdef5854.camel@gmail.com> References: <577b4b7594e011fb93f1c8c030281759e3e7affa.1705709466.git.vivien@planete-kraus.eu> <9b94f2224fb2d05071d260870bc03cbebdef5854.camel@gmail.com> User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches X-Patchwork-Original-From: Vivien Kraus via Guix-patches via From: Vivien Kraus Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello! Le samedi 20 janvier 2024 à 01:40 +0100, Liliana Marie Prikler a écrit : > >  (define-public gnome-shell-extension-noannoyance > >    (let ((revision "1") > > -        (commit "b759d10fd2799bc084007fdd927b62637c3dbd2c")) > > +        (commit "5e9e6a1878d2a1d961f5d59505f15339c5b7e17e")) > Remember to bump the revision. > >      (package > > +      ;; This is the “fork” version: > > +      ;; > > https://extensions.gnome.org/extension/6109/noannoyance-fork/ > The comment here is not great.  What does "This is the fork version" > mean when standing alone?  To me, it means absolutely nothing, > despite > knowing the context behind. > > Maybe explain "While the original version at is not > updated to current gnome, this fork supports newer > versions." or something like that. The situation is not very easy to explain. I discovered that our commit is 6 ahead of the commit published as version 17 for NoAnnoyance v2. I don’t really want to know how it relates to “NoAnnoyance” the original extension, because it has been forked around 2017 between f21d09a (“change to GPL v2 license”) and 866084e (“Rewrite”), which may be something like version 4 in extensions.gnome.org. In any case, since we are continuing the version number scheme of NoAnnoyance v2, this is version 17-6. I tried to explain this as quickly as possible, what do you think? Best regards, Vivien From 9d1d9c5f74f43ea60ed2ce9842cf821529ad6f27 Mon Sep 17 00:00:00 2001 Message-ID: <9d1d9c5f74f43ea60ed2ce9842cf821529ad6f27.1705740965.git.vivien@planete-kraus.eu> From: Vivien Kraus Date: Wed, 17 Jan 2024 23:32:42 +0100 Subject: [PATCH] gnu: gnome-shell-extension-noannoyance: Switch to fork. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The NoAnnoyance “v2” project has not been ported to GNOME 44, so we switch to a maintained fork. The version number is computed in continuity with NoAnnoyance v2. * gnu/packages/gnome-xyz.scm (gnome-shell-extension-noannoyance): Switch to the fork. Bump version to 17 and revision to 6. [arguments]: Convert to list of G-Expressions. Change-Id: Ic74d832020dfe3857e1abf450f5d7876cc921a28 --- gnu/packages/gnome-xyz.scm | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm index b6c1f6d3cb..026aaefd64 100644 --- a/gnu/packages/gnome-xyz.scm +++ b/gnu/packages/gnome-xyz.scm @@ -952,26 +952,32 @@ (define-public gnome-shell-extension-dash-to-panel (license license:gpl2+))) (define-public gnome-shell-extension-noannoyance - (let ((revision "1") - (commit "b759d10fd2799bc084007fdd927b62637c3dbd2c")) + ;; There are different forks of the NoAnnoyance extension. This is the one + ;; named “NoAnnoyance (fork)” at + ;; https://extensions.gnome.org/extension/6109/noannoyance-fork/ because it + ;; supports newer GNOME Shell versions than the previously used “NoAnnoyance + ;; v2”. + (let ((revision "6") + ;; “NoAnnoyance v2” version 17 correlates with + ;; c6804a47063659f9f48d13a0942b78ce98aac72b + (commit "5e9e6a1878d2a1d961f5d59505f15339c5b7e17e")) (package (name "gnome-shell-extension-noannoyance") - ;; XXX: There is no version noted anywhere in the source. Thus, infer it - ;; from . - (version (git-version "16" revision commit)) + (version (git-version "17" revision commit)) (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/bdaase/noannoyance") + (url "https://github.com/jirkavrba/noannoyance") (commit commit))) (sha256 (base32 - "0hh7fdqvx54h9j41ia2jl0nq1d5i66k7blw41ya6hkh7201r4anp")) + "0br9zrwvn499kh3db84hhw1kl02jpchwb5ldfp892p15vwih8yrf")) (file-name (git-file-name name version)))) (build-system copy-build-system) (arguments - '(#:install-plan - '(("." "share/gnome-shell/extensions/noannoyance@daase.net")))) + (list + #:install-plan + #~'(("." "share/gnome-shell/extensions/noannoyance@vrba.dev")))) (synopsis "Remove 'Window is ready' annotation") (description "One of the many extensions that remove this message. It uses ES6 syntax and claims to be more actively maintained than others.") base-commit: 49897f2dde7f469c83c496fad2699d3a05f72701 prerequisite-patch-id: 3faeeda7e58b64d088b388b6ebb44b927964912b prerequisite-patch-id: bc167ce608743cf16b648091eb5775e57b9e0953 -- 2.41.0