From patchwork Thu Jan 11 23:45:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomas Volf <~@wolfsden.cz> X-Patchwork-Id: 58812 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 275CA27BBEA; Thu, 11 Jan 2024 23:46:18 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6CA4527BBE2 for ; Thu, 11 Jan 2024 23:46:17 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rO4kV-0006La-3j; Thu, 11 Jan 2024 18:46:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO4kR-0006HK-V1 for guix-patches@gnu.org; Thu, 11 Jan 2024 18:46:08 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rO4kR-0000OQ-2W; Thu, 11 Jan 2024 18:46:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rO4kL-0008Fg-Ol; Thu, 11 Jan 2024 18:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68392] [PATCH v2] scripts: pack: Set correct default value for entry-point-argument. References: <6c246d4964dfc383d7f8dff5184772fd09553050.1705016507.git.~@wolfsden.cz> In-Reply-To: <6c246d4964dfc383d7f8dff5184772fd09553050.1705016507.git.~@wolfsden.cz> Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Thu, 11 Jan 2024 23:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68392 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68392@debbugs.gnu.org Cc: Tomas Volf <~@wolfsden.cz>, Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 68392-submit@debbugs.gnu.org id=B68392.170501675330908 (code B ref 68392); Thu, 11 Jan 2024 23:46:01 +0000 Received: (at 68392) by debbugs.gnu.org; 11 Jan 2024 23:45:53 +0000 Received: from localhost ([127.0.0.1]:34317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO4kD-00081l-9Y for submit@debbugs.gnu.org; Thu, 11 Jan 2024 18:45:53 -0500 Received: from wolfsden.cz ([37.205.8.62]:38994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rO4kB-0007wZ-1V for 68392@debbugs.gnu.org; Thu, 11 Jan 2024 18:45:52 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 2573124E86C; Thu, 11 Jan 2024 23:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705016752; bh=M2E8vVGcmDpyqUxCNaI05F3B6yUKoEEZk5NNKccZFF4=; h=From:To:Cc:Subject:Date; b=eKsmtCYydCzp99JSpThVUgKqEDmkYSHzgZjckjM/MWPal1mawHzgVbZfwlCu9j08z dlqBpZNNim/cmZ1ukXE6CAJL9sIbJWs+IRQU+5VUKv6pBnXXwDYBoVrNWOdVn8u7ww qfjWdcg6GW2KAXOJElmW4NmMgNBkIHBT5bACbQvGrxFDENtv3vrUGbWjzfPjLe5MAY teWogVC/fc7r1nFSLZ0A1F4YSFvdZBT/z4uAtSo69JAqYGcwbPe8KI/x7n6YqycCdu JoX5An6NATdLJ3KKGKzrhRkzEnNzdx1nI3LuFHUoGIMm5r3mpqpqNXzC9XNLEYzE2A Jg7YSMqvp0lisSfxchTZqnSaLsmeIa499Xet/wdENhrhn1XK+X1WvhMUPEsKxEOu0P JfpZ/fAKg2j4xmVhq+GqCFJ41tR4/4YtslsQj06TuAYalY+q+CoQmCCWWzHsyCe8Qm s0KWFihy7J1HPvS8UG1WQm3QWYDuBrJKviCG+c1vYBQ2JWr14b/G2OUj5URXbfJq2F a9TNmd609OSwQR5HP7zfbyJIhWGrAaQjbmHVwRwjis5nKnQ16qQi4MjYU7oSqd7N3t Rbl9lk7qm89nrtyL88jO6WLAgJDQ8YGKyFir6/btYBHdGn+eOFHYyPmxMIHS5H5GLN yiNXYEdh0qQwb8uPqmVd4rOI= Received: from localhost (unknown [193.32.127.158]) by wolfsden.cz (Postfix) with ESMTPSA id B57A024FBD9; Thu, 11 Jan 2024 23:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705016751; bh=M2E8vVGcmDpyqUxCNaI05F3B6yUKoEEZk5NNKccZFF4=; h=From:To:Cc:Subject:Date; b=HnMtoDiCgPw3mwYeANSmC6ibj1gRh/RaL4Xh/S/CrM/Ef3xhwtg9ro7XYQ87RTg65 2Psw+CPnqQPAY858Sa6o4xSyQ5H3Yl2rAsEpXjwkUXwb/BQ60wVSYOGPmsiAQjPZk+ K7y+SePj8NJPuj1J4LdeIQ3y4ieVGXK/1qFw2fNfJmaBLBTohm9RWoUAxG6IErkliw 2Qlbr9ybhz3l3j5P4q/dDnokY3COBcw1pDjzyGd5oHB2nJCh+0VnUvUmI2Hqapx20N Pw9DPwP3lEOttVyKyRy0ndS2PxK8VJc52QGTWgyuQR48Kk0sCiULiHwjRdRcoqfC3t cP8RkkgI4D6bUl3hvzm7mQuXsicXehchCEhuN3zkhrDE3n3XkpAbkdV16s7QlUe7J3 +C81iKfM27Ut1fCTssut5Uz9gMIyDOxRx9m3kRjNDja1bWIDMZ4x9KfTJ0aaFJE8gK 9G+XMyAeMXm7FX+5fAFAcqgI43Q35RLaEkf3fD06VO2DcdzUoCtVsuHFZOvT47ELWv WRbNanRsxNg4PJfMwZ/ttVdzUaSTifJu3h1v0ZM7aCOo8iksqpMnvXG8YR/0EuGEgD oYywLGlfdM8zvmzFf64OfSVWmtR9NvqEnT39Zr8B1KrDVYGsXYc4WAMucW0yaoU6ML 7Yr0A8GuuzIkNCcPS7oO6JqI= From: Tomas Volf <~@wolfsden.cz> Date: Fri, 12 Jan 2024 00:45:34 +0100 Message-ID: <9fdaf2f5f26ab0ccb7821f521743cabfc55323dc.1705016734.git.~@wolfsden.cz> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches The default value of #f led to ("..." . #f) being passed further down as an entry point. That is not an issue for command line invocation, since in that code path '() was already used as a default value, but it broke docker system test with the following error: building /gnu/store/dll8jj6h5pfgf6ya9skk1g1546smwbib-docker-pack.tar.gz.drv... tar: Removing leading `/' from member names Backtrace: 6 (primitive-load "/gnu/store/g8hqzccfvn4mkm41jqs65c27gs7?") In ./guix/docker.scm: 268:6 5 (build-docker-image "/gnu/store/zi2f5dfdrhviinm6jxp3cj?" ?) In ice-9/ports.scm: 433:17 4 (call-with-output-file _ _ #:binary _ #:encoding _) 476:4 3 (_ _) In ./guix/docker.scm: 270:21 2 (_) 123:40 1 (config "1996ead589ab366473d935c4d5bd0c38b998f3b299847?" ?) In unknown file: 0 (list->vector ("/gnu/store/1pvqd30qi1aigjdf7s7l8v7?" . #)) ERROR: In procedure list->vector: In procedure vector: Wrong type argument in position 1: ("/gnu/store/1pvqd30qi1aigjdf7s7l8v7wpvrrhfkj-profile/bin/guile" . #f) note: keeping build directory `/tmp/guix-build-docker-pack.tar.gz.drv-16' builder for `/gnu/store/dll8jj6h5pfgf6ya9skk1g1546smwbib-docker-pack.tar.gz.drv' failed with exit code 1 build of /gnu/store/dll8jj6h5pfgf6ya9skk1g1546smwbib-docker-pack.tar.gz.drv failed View build log at '/var/log/guix/drvs/dl/l8jj6h5pfgf6ya9skk1g1546smwbib-docker-pack.tar.gz.drv.gz'. cannot build derivation `/gnu/store/dq9qk1ba0f07572m8ck3xws28x1b3rif-docker-test.drv': 1 dependencies couldn't be built guix build: error: build of `/gnu/store/dq9qk1ba0f07572m8ck3xws28x1b3rif-docker-test.drv' failed make: *** [Makefile:7044: check-system] Error 1 Breakage was introduced in 7d5168a2af3ed922c6a46985124fb73402cc8844. * guix/scripts/pack.scm (docker-image)[entry-point-argument]: Default to '(). Change-Id: If5fc1f8bcb0981df11409636e71f2ca91b05612f --- Spelling. guix/scripts/pack.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 5c0f77f4241c9beac0c82deae946bfdc70b49ff0 diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm index d0acc6cfd8..3e45c34895 100644 --- a/guix/scripts/pack.scm +++ b/guix/scripts/pack.scm @@ -597,7 +597,7 @@ (define* (docker-image name profile (let-keywords '#$extra-options #f ((image-tag #f) - (entry-point-argument #f) + (entry-point-argument '()) (max-layers #f)) (build-docker-image #$output