From patchwork Sun Dec 17 13:38:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Baum X-Patchwork-Id: 57661 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A876227BBE9; Sun, 17 Dec 2023 16:07:59 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 98BC927BBE2 for ; Sun, 17 Dec 2023 16:07:58 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEtfy-0005yV-IS; Sun, 17 Dec 2023 11:07:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEtRt-0002vu-LX for guix-patches@gnu.org; Sun, 17 Dec 2023 10:53:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEtRt-0003bv-Dk for guix-patches@gnu.org; Sun, 17 Dec 2023 10:53:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEtRu-0005sv-Ll for guix-patches@gnu.org; Sun, 17 Dec 2023 10:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67867] [PATCH shepherd] service: fix ownership+permissions on Unix sockets Resent-From: Ulrich Baum Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 Dec 2023 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67867@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.170282832622534 (code B ref -1); Sun, 17 Dec 2023 15:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Dec 2023 15:52:06 +0000 Received: from localhost ([127.0.0.1]:58900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEtQz-0005rI-D8 for submit@debbugs.gnu.org; Sun, 17 Dec 2023 10:52:05 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rErM0-0003a1-Sk for submit@debbugs.gnu.org; Sun, 17 Dec 2023 08:38:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rErLs-0002Vw-C5 for guix-patches@gnu.org; Sun, 17 Dec 2023 08:38:40 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1rErLZ-0005bR-LM for guix-patches@gnu.org; Sun, 17 Dec 2023 08:38:40 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4StPD46W3gz9sjT for ; Sun, 17 Dec 2023 14:38:12 +0100 (CET) Date: Sun, 17 Dec 2023 14:38:12 +0100 (CET) From: Ulrich Baum Message-ID: <656849315.83800.1702820292582@office.mailbox.org> MIME-Version: 1.0 X-Priority: 3 Importance: Normal Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=ulrich.baum@ubaum.de; helo=mout-p-101.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 17 Dec 2023 10:51:58 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sun, 17 Dec 2023 11:07:33 -0500 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Previously, ownership and permissions of AF_UNIX sockets created by make-inetd-constructor and make-systemd-constructor were not set, leaving the socket with root:root and 755 permissions. modules/shepherd/service.scm (endpoint->listening-socket): fix chown and chmod calls --- modules/shepherd/service.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.43.0 diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm index 41c6248..f22aaaf 100644 --- a/modules/shepherd/service.scm +++ b/modules/shepherd/service.scm @@ -1867,8 +1867,8 @@ retrying to bind it in one second.") (listen sock backlog) (when (= AF_UNIX (sockaddr:fam address)) - (chown sock owner group) - (chmod sock #o666)) + (chown (sockaddr:path address) owner group) + (chmod (sockaddr:path address) #o666)) sock))))