From patchwork Sun Nov 19 09:52:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Junjie X-Patchwork-Id: 56626 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E971C27BBE9; Sun, 19 Nov 2023 09:55:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1B98E27BBE2 for ; Sun, 19 Nov 2023 09:55:19 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4eW9-0006eG-5u; Sun, 19 Nov 2023 04:55:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4eW5-0006e4-Ls for guix-patches@gnu.org; Sun, 19 Nov 2023 04:55:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4eW5-0001Cg-DD for guix-patches@gnu.org; Sun, 19 Nov 2023 04:55:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4eW5-0005ro-Qz; Sun, 19 Nov 2023 04:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67271] [PATCH] gnu: at-spi2-core: Honor tests? flag.. Resent-From: Zheng Junjie Original-Sender: "Debbugs-submit" Resent-CC: liliana.prikler@gmail.com, maxim.cournoyer@gmail.com, rg@raghavgururajan.name, guix-patches@gnu.org Resent-Date: Sun, 19 Nov 2023 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67271 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67271@debbugs.gnu.org Cc: Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan Received: via spool by submit@debbugs.gnu.org id=B.170038764622473 (code B ref -1); Sun, 19 Nov 2023 09:55:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Nov 2023 09:54:06 +0000 Received: from localhost ([127.0.0.1]:49949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4eVC-0005qP-68 for submit@debbugs.gnu.org; Sun, 19 Nov 2023 04:54:06 -0500 Received: from lists.gnu.org ([2001:470:142::17]:38628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4eV8-0005pq-CV for submit@debbugs.gnu.org; Sun, 19 Nov 2023 04:54:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4eUz-0006Xi-B0 for guix-patches@gnu.org; Sun, 19 Nov 2023 04:53:53 -0500 Received: from smtp21.cstnet.cn ([159.226.251.21] helo=cstnet.cn) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1r4eUv-0008GF-KF for guix-patches@gnu.org; Sun, 19 Nov 2023 04:53:52 -0500 Received: from localhost.localdomain (unknown [183.247.5.179]) by APP-01 (Coremail) with SMTP id qwCowAA3PnZG2lll56KnAA--.34237S2; Sun, 19 Nov 2023 17:50:00 +0800 (CST) From: Zheng Junjie Date: Sun, 19 Nov 2023 17:52:27 +0800 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-CM-TRANSID: qwCowAA3PnZG2lll56KnAA--.34237S2 X-Coremail-Antispam: 1UD129KBjvJXoWxCr1DXFWDCw1DKr17tw43Jrb_yoW5Xr4Dpa ySkw12kry8C3Z5tanagr1jg343Krn5GrWfAws3Aw1vk3y3u3WUArWfKr48ZFy3Xay2gw43 uanYqw13GryqyrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyab7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I 8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xv F2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r 4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwIxGrwCF x2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14 v26r106r1rMI8E67AF67kF1VAFwI0_Jr0_JrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY 67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2 IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_ Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU5PpnJUUUUU== X-Originating-IP: [183.247.5.179] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ Received-SPF: pass client-ip=159.226.251.21; envelope-from=zhengjunjie@iscas.ac.cn; helo=cstnet.cn X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/gtk.scm (at-spi2-core)[arguments]<#:phases>: Honor tests? flag. Change-Id: Ie38226c0ceacd7afb54adff073c1f71eb596e10d --- gnu/packages/gtk.scm | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-) base-commit: 1cc3b7e80f60a2a5a6a1400ed0b025efeae7a523 diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index 67611efaae..745c3a9a55 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -811,31 +811,31 @@ (define-public at-spi2-core (delete 'check) ;; The CI test suite fails completely on powerpc-linux. ;; The name org.gnome.SessionManager was not provided by any .service - ;; TODO: Wrap 'check phase with 'tests?'. #$@(if (not (target-ppc32?)) #~((add-after 'install 'check - (lambda _ - ;; xfconfd requires a writable HOME - (setenv "HOME" (getenv "TMPDIR")) - ;; dbus-run-session may crash if XDG_DATA_DIRS has too - ;; many entries, maybe related to - ;; https://gitlab.freedesktop.org/dbus/dbus/-/issues/481. - (setenv "XDG_DATA_DIRS" - (string-append - #$output "/share:" - #$(this-package-native-input - "gsettings-desktop-schemas") - "/share")) - ;; Don't fail on missing '/etc/machine-id'. - (setenv "DBUS_FATAL_WARNINGS" "0") - (with-directory-excursion (string-append "../at-spi2-core-" - #$version "") - (invoke "dbus-run-session" "--" "ci/run-registryd-tests.sh") - (substitute* "ci/run-tests.sh" - (("ps auxwww") "") ;avoid a dependency on procps - (("meson test -C _build") - "meson test -C ../build")) ;adjust build directory - (invoke "dbus-run-session" "--" "ci/run-tests.sh"))))) + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + ;; xfconfd requires a writable HOME + (setenv "HOME" (getenv "TMPDIR")) + ;; dbus-run-session may crash if XDG_DATA_DIRS has too + ;; many entries, maybe related to + ;; https://gitlab.freedesktop.org/dbus/dbus/-/issues/481. + (setenv "XDG_DATA_DIRS" + (string-append + #$output "/share:" + #$(this-package-native-input + "gsettings-desktop-schemas") + "/share")) + ;; Don't fail on missing '/etc/machine-id'. + (setenv "DBUS_FATAL_WARNINGS" "0") + (with-directory-excursion (string-append "../at-spi2-core-" + #$version "") + (invoke "dbus-run-session" "--" "ci/run-registryd-tests.sh") + (substitute* "ci/run-tests.sh" + (("ps auxwww") "") ;avoid a dependency on procps + (("meson test -C _build") + "meson test -C ../build")) ;adjust build directory + (invoke "dbus-run-session" "--" "ci/run-tests.sh")))))) #~())))) (inputs (list bash-minimal libxml2))