From patchwork Wed Nov 15 22:53:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Thompson, David" X-Patchwork-Id: 56504 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 7896B27BBEA; Wed, 15 Nov 2023 22:55:24 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3308127BBE2 for ; Wed, 15 Nov 2023 22:55:20 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3Omq-0008Ki-6f; Wed, 15 Nov 2023 17:55:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Omk-0008Ip-RZ for guix-patches@gnu.org; Wed, 15 Nov 2023 17:55:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3Omk-0005xi-Hu for guix-patches@gnu.org; Wed, 15 Nov 2023 17:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3Omj-0001Sg-OM for guix-patches@gnu.org; Wed, 15 Nov 2023 17:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67214] [PATCH] services: xvnc: Do not specify display number when using inetd Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Nov 2023 22:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67214 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67214@debbugs.gnu.org X-Debbugs-Original-To: Ryan Prior via Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.17000888515550 (code B ref -1); Wed, 15 Nov 2023 22:55:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2023 22:54:11 +0000 Received: from localhost ([127.0.0.1]:54118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Olu-0001RR-KN for submit@debbugs.gnu.org; Wed, 15 Nov 2023 17:54:10 -0500 Received: from lists.gnu.org ([2001:470:142::17]:56860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ols-0001RD-Fi for submit@debbugs.gnu.org; Wed, 15 Nov 2023 17:54:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Oll-0008FG-He for guix-patches@gnu.org; Wed, 15 Nov 2023 17:54:02 -0500 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3Olj-0005jx-Gb for guix-patches@gnu.org; Wed, 15 Nov 2023 17:54:01 -0500 Received: by mail-oi1-x22c.google.com with SMTP id 5614622812f47-3b2f4a5ccebso115971b6e.3 for ; Wed, 15 Nov 2023 14:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20230601.gappssmtp.com; s=20230601; t=1700088837; x=1700693637; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=TVMxE5/c5VOcKJIs6jsAbdrOiVEaVSSlniY0q2lI51E=; b=X+zZywZ++A992HZuBjRI9uO84IswYQEefL7e7hJeirTjigjKxP5Mke6Vm8e0rUHlfR nZBKHdvZHwUilMNdaYoFugqH4uq78ea/5jCVcuzqB07flR5AXSZJlgS1lblu8GWUix0S KqTuUzYTl3sedf9p5GrIMQEoNxeGgl5aw1mmOBmfajSi882TBvAICz1C5J9wJXKlKEVz CU6SMm5Y+AlLC3M804+XjsWvEK0hesJcxD9zBdp79qUWVZ41IqHqvWD0iClV9C4WfsZW 8d1/WZVDmkIskwX8ErdpK1IVWnd/v7RSpey4GN8ws1gB3m+0EzZPev1caI0CLL8yvKMy MIyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700088837; x=1700693637; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TVMxE5/c5VOcKJIs6jsAbdrOiVEaVSSlniY0q2lI51E=; b=NiMOFqym6QlFaL2gcjWZuppjNnPVjVdLOENZE7OHYWs9uw+DjMIgDiyaKTzRi+YNAl yrMnCX46JK6zOFV42jIKvWFWydFrzyKQplOmMbDiPktp6hm3t1BYmoIVmmCngTLxuXeP fo+dS5nCerFCT0Xg7k1D18+1qz9HJuKXAfWKa4k5ytZUtHNIxFzmlkV32ogT8hyhI0YW cvSAJAhn15DOm2dqXNmPEKMzd5eMt0vCAqtAk9bh5siQ8eWsnY/v6KV/Z/PtRtZtjVjH qdbPwl3OV15Bho6ady+Z/NXFLhS9dghsROOET4oQYCPuP9zrOJtJ6ojxd0SSyYg0fP8V O52A== X-Gm-Message-State: AOJu0YwrmeEVlEe4K9WWfvuQNqiS6K46mxwiP+uRFSoOQe7cKbR6Zrho m1ztdaeXIlRXETHmabFjggi5QZ8+ElQFwjpAcW/r+EQtITpcfOD/ X-Google-Smtp-Source: AGHT+IE+RdVOntc30D4jfDQ2zBHUZiKAwymRRnSQCMBdbXuXlLnZvx1EC6U33Dt0WP9O0nGZZDH20YfDz0cWKNYmK8w= X-Received: by 2002:a05:6358:713:b0:16b:f554:f359 with SMTP id e19-20020a056358071300b0016bf554f359mr7481696rwj.7.1700088837459; Wed, 15 Nov 2023 14:53:57 -0800 (PST) MIME-Version: 1.0 From: "Thompson, David" Date: Wed, 15 Nov 2023 17:53:46 -0500 Message-ID: Received-SPF: pass client-ip=2607:f8b0:4864:20::22c; envelope-from=dthompson2@worcester.edu; helo=mail-oi1-x22c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hey everyone, I've been struggling to get VNC working with multiple users. Upon digging into it I realized that it's because the X display number is fixed in the xvnc service, even when in inetd mode, so only the first user who connects gets a desktop and everyone else gets an error. By omitting the display number when using inetd, xvnc just picks an unused display and I'm now able to log in with multiple user accounts. The patch is a one-liner and hopefully not very controversial. :) - Dave From a7aa18cbb8050ae228aeca2b4a1f724a797983ac Mon Sep 17 00:00:00 2001 Message-ID: From: David Thompson Date: Wed, 15 Nov 2023 17:46:34 -0500 Subject: [PATCH] services: xvnc: Do not specify display number when using inetd. * gnu/services/vnc.scm (xvnc-configuration->command-line-arguments): Omit X display number when inetd? is #t. Change-Id: I0fc8e3068f3ae22421e60e96bd40e3b6e477ca99 --- gnu/services/vnc.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/vnc.scm b/gnu/services/vnc.scm index f90bd7258f..8b9ad0b179 100644 --- a/gnu/services/vnc.scm +++ b/gnu/services/vnc.scm @@ -149,7 +149,7 @@ (define (xvnc-configuration->command-line-arguments config) (xvnc display-number geometry depth port ipv4? ipv6? password-file xdmcp? inetd? frame-rate security-types localhost? log-level extra-options) #~(list #$(file-append xvnc "/bin/Xvnc") - #$(format #f ":~a" display-number) + #$@(if inetd? '() (list (format #f ":~a" display-number))) "-geometry" #$geometry "-depth" #$(number->string depth) #$@(if inetd? base-commit: d987b75618a62c95c030e7ca53e0972e700c4f06 -- 2.41.0