From patchwork Sun Dec 2 22:38:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Bavier X-Patchwork-Id: 372 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BAD5C16794; Sun, 2 Dec 2018 22:43:59 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,MISSING_HEADERS, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) by mira.cbaines.net (Postfix) with ESMTPS id E252E16760 for ; Sun, 2 Dec 2018 22:43:54 +0000 (GMT) Received: from localhost ([::1]:46050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTaSw-0004zW-5V for patchwork@mira.cbaines.net; Sun, 02 Dec 2018 17:43:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTaS8-0002sC-IC for guix-patches@gnu.org; Sun, 02 Dec 2018 17:43:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTaPD-0007tE-Fu for guix-patches@gnu.org; Sun, 02 Dec 2018 17:40:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54213) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTaPD-0007t8-CU for guix-patches@gnu.org; Sun, 02 Dec 2018 17:40:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gTaPD-00077G-4n for guix-patches@gnu.org; Sun, 02 Dec 2018 17:40:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33572] Guile-JSON now seems to be a required dependency Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Dec 2018 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33572 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch Received: via spool by 33572-submit@debbugs.gnu.org id=B33572.154379035527271 (code B ref 33572); Sun, 02 Dec 2018 22:40:02 +0000 Received: (at 33572) by debbugs.gnu.org; 2 Dec 2018 22:39:15 +0000 Received: from localhost ([127.0.0.1]:58466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTaOJ-00075X-UU for submit@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:15 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:29054 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTaO9-00074u-Hr for 33572@debbugs.gnu.org; Sun, 02 Dec 2018 17:39:06 -0500 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543790332; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=ARB14/aSgGIlT3Wq10y/Df2dhmQ=; b=fs+famDjifK53RW01UrVvxBgugnyBn5m31hz9Vf6RNWUs1ehbyB+eXDgiPK5WLHV x+3PA9sQKVHutQltxObFzX+/JhaTAXj9MB8MemgcwDhVDEY4i5UYKMmIDAJjgmg/ FKwR63vTGD57VyVctEScEK8dU1hoQh0szrbWIxMc69hJgwZH9Afbg/ctHacRIA+l XcMz9k84z5tyCzKpDNyVFE/hYaoXO3bB8g93PUXFb5fAx5zyCffxEvVQjrH0MnZv I224l+a/8p9YL52ph0UMkZkeFVylguwD/cdmRLKJHOwFQoSyIVJTMemILJKuVAaD BvJ0poVZsptNNaBsCo5sSA==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=SPAAb6nH c=1 sm=1 tr=0 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17 a=KGjhK52YXX0A:10 a=9cW_t1CCXrUA:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=I_5RNyk1AAAA:8 a=mDV3o1hIAAAA:8 a=ZLGELXoPAAAA:8 a=xyPz4MZXAAAA:8 a=jkeNA5DuGbtvc2G82hMA:9 a=QEXdDO2ut3YA:10 a=inoG4m36AAAA:8 a=CcLUTRNvAAAA:8 a=FFLdh5n2AAAA:20 a=fXms6y0vAAAA:8 a=69wJf7TsAAAA:8 a=YlWAI3VNwFMpwfLTPFcA:9 a=sA05eG8pRY_Lc50BeKYA:9 a=Eh9yxdLE6B1twWrs3SXz:22 a=_FVE-zBwftR9WsbkzFJk:22 a=CFiPc5v16LZhaT-MVE1c:22 a=MgilOBo1dlhwZn2HC1h_:22 a=_Qgj-RFg6mImvLaOgLPg:22 a=obhdfE27RNN5ZnF-s2K5:22 a=c6Zb8eaUoX5VaqycxFvw:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp01.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.107.116] ([97.116.107.116:51186] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 5C/94-05378-BFE540C5; Sun, 02 Dec 2018 17:38:51 -0500 Date: Sun, 2 Dec 2018 16:38:50 -0600 From: Eric Bavier Message-ID: <20181202163850.63cb6d9e@centurylink.net> In-Reply-To: <20181202162225.500e1721@centurylink.net> References: <87y399am9b.fsf@ngyro.com> <20181201091658.720e1f20@centurylink.net> <87sgzh9ivq.fsf@ngyro.com> <87woorg3hk.fsf@fastmail.com> <87a7lnlhd8.fsf@gnu.org> <20181202162225.500e1721@centurylink.net> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Joshua Branson , 33572@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On Sun, 2 Dec 2018 16:22:25 -0600 Eric Bavier wrote: > On Sun, 02 Dec 2018 22:59:47 +0100 > ludo@gnu.org (Ludovic Courtès) wrote: > > > Hello, > > > > Joshua Branson skribis: > > > > > Timothy Sample writes: > > > > > >> Hi Eric, > > >> > > >> Eric Bavier writes: > > > > [...] > > > > >>> Yes, we decided to make it a hard requirement. I'm working on a patch > > >>> to follow through. > > > > > > I believe I created such a patch. > > > > Eric, could you consider merging your patch with Joshua’s? Making > > Guile-JSON a hard dependency takes more than updating guix.texi, though. > > Here's an updated patch. Oops, messed up the texinfo formatting; this patch is better. `~Eric From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001 From: Eric Bavier Date: Sat, 1 Dec 2018 20:46:22 -0600 Subject: [PATCH] Make Guile-JSON a required dependency. * README (Requirements): Remove "optional" verbiage. * doc/guix.texi (Requirements): Move Guile-JSON from optional to required. * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. (have_guile_json): Error if not "yes". * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests unconditionally. * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave guile-json input. --- Makefile.am | 72 ++++++++++++----------------- README | 2 +- configure.ac | 6 ++- doc/guix.texi | 8 +--- gnu/packages/package-management.scm | 2 +- 5 files changed, 37 insertions(+), 53 deletions(-) diff --git a/Makefile.am b/Makefile.am index e14ac57f2..32cebd591 100644 --- a/Makefile.am +++ b/Makefile.am @@ -62,7 +62,9 @@ MODULES = \ guix/base16.scm \ guix/base32.scm \ guix/base64.scm \ + guix/ci.scm \ guix/cpio.scm \ + guix/docker.scm \ guix/records.scm \ guix/pki.scm \ guix/progress.scm \ @@ -186,15 +188,24 @@ MODULES = \ guix/build/make-bootstrap.scm \ guix/search-paths.scm \ guix/packages.scm \ - guix/import/print.scm \ - guix/import/utils.scm \ - guix/import/gnu.scm \ - guix/import/snix.scm \ guix/import/cabal.scm \ + guix/import/cpan.scm \ guix/import/cran.scm \ - guix/import/hackage.scm \ + guix/import/crate.scm \ guix/import/elpa.scm \ + guix/import/gem.scm \ + guix/import/github.scm \ + guix/import/gnome.scm \ + guix/import/gnu.scm \ + guix/import/hackage.scm \ + guix/import/json.scm \ + guix/import/opam.scm \ + guix/import/print.scm \ + guix/import/pypi.scm \ + guix/import/snix.scm \ + guix/import/stackage.scm \ guix/import/texlive.scm \ + guix/import/utils.scm \ guix/scripts.scm \ guix/scripts/download.scm \ guix/scripts/perform-download.scm \ @@ -216,46 +227,29 @@ MODULES = \ guix/scripts/system/search.scm \ guix/scripts/lint.scm \ guix/scripts/challenge.scm \ + guix/scripts/import/crate.scm \ guix/scripts/import/cran.scm \ + guix/scripts/import/elpa.scm \ + guix/scripts/import/gem.scm \ guix/scripts/import/gnu.scm \ - guix/scripts/import/nix.scm \ guix/scripts/import/hackage.scm \ - guix/scripts/import/elpa.scm \ + guix/scripts/import/json.scm \ + guix/scripts/import/nix.scm \ + guix/scripts/import/opam.scm \ + guix/scripts/import/pypi.scm \ + guix/scripts/import/stackage.scm \ guix/scripts/import/texlive.scm \ guix/scripts/environment.scm \ guix/scripts/publish.scm \ guix/scripts/edit.scm \ guix/scripts/size.scm \ guix/scripts/graph.scm \ + guix/scripts/weather.scm \ guix/scripts/container.scm \ guix/scripts/container/exec.scm \ guix.scm \ $(GNU_SYSTEM_MODULES) -if HAVE_GUILE_JSON - -MODULES += \ - guix/ci.scm \ - guix/docker.scm \ - guix/import/cpan.scm \ - guix/import/crate.scm \ - guix/import/gem.scm \ - guix/import/github.scm \ - guix/import/gnome.scm \ - guix/import/json.scm \ - guix/import/opam.scm \ - guix/import/pypi.scm \ - guix/import/stackage.scm \ - guix/scripts/import/crate.scm \ - guix/scripts/import/gem.scm \ - guix/scripts/import/json.scm \ - guix/scripts/import/opam.scm \ - guix/scripts/import/pypi.scm \ - guix/scripts/import/stackage.scm \ - guix/scripts/weather.scm - -endif - if HAVE_GUILE_SSH MODULES += \ @@ -335,7 +329,10 @@ SCM_TESTS = \ tests/base16.scm \ tests/base32.scm \ tests/base64.scm \ + tests/cpan.scm \ tests/cpio.scm \ + tests/crate.scm \ + tests/gem.scm \ tests/pki.scm \ tests/print.scm \ tests/sets.scm \ @@ -389,22 +386,13 @@ SCM_TESTS = \ tests/services.scm \ tests/scripts-build.scm \ tests/containers.scm \ + tests/opam.scm \ tests/pack.scm \ + tests/pypi.scm \ tests/import-utils.scm \ tests/store-database.scm \ tests/store-deduplication.scm -if HAVE_GUILE_JSON - -SCM_TESTS += \ - tests/pypi.scm \ - tests/opam.scm \ - tests/cpan.scm \ - tests/gem.scm \ - tests/crate.scm - -endif - SH_TESTS = \ tests/guix-build.sh \ tests/guix-build-branch.sh \ diff --git a/README b/README index a7a818c5c..e7871917f 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ GNU Guix currently depends on the following packages: - [[https://notabug.org/guile-sqlite3/guile-sqlite3][Guile-SQLite3]], version 0.1.0 or later - [[https://gitlab.com/guile-git/guile-git][Guile-Git]] - [[http://www.zlib.net/][zlib]] - - optionally [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]], for the 'guix import pypi' command + - [[https://savannah.nongnu.org/projects/guile-json/][Guile-JSON]] Unless `--disable-daemon' was passed, the following packages are needed: diff --git a/configure.ac b/configure.ac index 2a1edbc32..2817e6e24 100644 --- a/configure.ac +++ b/configure.ac @@ -122,9 +122,11 @@ if test "x$have_guile_git" != "xyes"; then AC_MSG_ERROR([Guile-Git is missing; please install it.]) fi -dnl Guile-JSON is used in various places. +dnl Check for Guile-JSON. GUILE_MODULE_AVAILABLE([have_guile_json], [(json)]) -AM_CONDITIONAL([HAVE_GUILE_JSON], [test "x$have_guile_json" = "xyes"]) +if test "x$have_guile_json" != "xyes"; then + AC_MSG_ERROR([Guile-JSON is missing; please install it.]) +fi dnl Guile-Sqlite3 is used by the (guix store ...) modules. GUIX_CHECK_GUILE_SQLITE3 diff --git a/doc/guix.texi b/doc/guix.texi index fff5dfe0b..6cb63edb9 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -653,6 +653,7 @@ or later; @c FIXME: Specify a version number once a release has been made. @uref{https://gitlab.com/guile-git/guile-git, Guile-Git}, from August 2017 or later; +@item @uref{https://savannah.nongnu.org/projects/guile-json/, Guile-JSON}; @item @url{http://zlib.net, zlib}; @item @url{http://www.gnu.org/software/make/, GNU Make}. @end itemize @@ -660,13 +661,6 @@ or later; The following dependencies are optional: @itemize -@item -Installing -@url{http://savannah.nongnu.org/projects/guile-json/, Guile-JSON} will -allow you to use the @command{guix import pypi} command (@pxref{Invoking -guix import}). It is of -interest primarily for developers and not for casual users. - @item @c Note: We need at least 0.10.2 for 'channel-send-eof'. Support for build offloading (@pxref{Daemon Offload Setup}) and diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index 141d0e52f..c4e917102 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -389,7 +389,7 @@ the Nix package manager.") (propagated-inputs (fold alist-delete (package-propagated-inputs guix) - '("guile-json" "guile-ssh"))))))) + '("guile-ssh"))))))) (define (source-file? file stat) "Return true if FILE is likely a source file, false if it is a typical -- 2.19.1