From patchwork Mon Oct 21 21:05:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 15804 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1E8E2175FB; Mon, 21 Oct 2019 22:06:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id D5D2A1734B for ; Mon, 21 Oct 2019 22:06:24 +0100 (BST) Received: from localhost ([::1]:47932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMesh-0001ag-Tz for patchwork@mira.cbaines.net; Mon, 21 Oct 2019 17:06:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43525) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMesO-0001SK-Qq for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMesM-0001sw-MM for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49155) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMesM-0001sp-E9 for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMesM-0005IB-7v for guix-patches@gnu.org; Mon, 21 Oct 2019 17:06:02 -0400 Subject: bug#37750: Fixup: Documentation Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 21 Oct 2019 21:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 37750 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Tim Gesthuizen Cc: 37750-done@debbugs.gnu.org Mail-Followup-To: 37750@debbugs.gnu.org, ludo@gnu.org, tim.gesthuizen@yahoo.de Received: via spool by 37750-done@debbugs.gnu.org id=D37750.157169193420287 (code D ref 37750); Mon, 21 Oct 2019 21:06:01 +0000 Received: (at 37750-done) by debbugs.gnu.org; 21 Oct 2019 21:05:34 +0000 Received: from localhost ([127.0.0.1]:57975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMeru-0005H9-G9 for submit@debbugs.gnu.org; Mon, 21 Oct 2019 17:05:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMers-0005Gq-7l for 37750-done@debbugs.gnu.org; Mon, 21 Oct 2019 17:05:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMerm-0001gX-C6; Mon, 21 Oct 2019 17:05:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52898 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMerl-0000IS-Mp; Mon, 21 Oct 2019 17:05:26 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: <87d0ezb5g1.fsf@yahoo.de> <87blujb46u.fsf@yahoo.de> Date: Mon, 21 Oct 2019 23:05:23 +0200 In-Reply-To: <87blujb46u.fsf@yahoo.de> (Tim Gesthuizen's message of "Mon, 14 Oct 2019 19:57:29 +0200") Message-ID: <875zkhzu5o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Tim, Tim Gesthuizen skribis: >>From 544ae60c79134be980d6ee0430deb6abe4cad8ca Mon Sep 17 00:00:00 2001 > From: Tim Gesthuizen > Date: Thu, 10 Oct 2019 18:38:36 +0200 > Subject: [PATCH] gnu: Add baud-rate parameter to inputattach-service > > * gnu/services/desktop.scm (inputattach-configuration): Add baud-rate field. > (inputattach-shepherd-service): Add baud-rate to parameters when specified. > * doc/guix.texi (Miscellaneous Services): [inputattach Service] Document > baud-rate parameter. Neat. I took the liberty to apply it with the minor change below (we don’t usually call ‘error’; eventually I think we should use contracts à la Racket in such situations.) Thanks! Ludo’. diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index 20e89c0dea..08acb79ed6 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1037,9 +1037,7 @@ as expected."))) (match-lambda (($ type device baud-rate log-file) (let ((args (append (if baud-rate - (if (number? baud-rate) - (list "--baud-rate" (number->string baud-rate)) - (error "Expected baud-rate to be a number or #f" baud-rate)) + (list "--baud-rate" (number->string baud-rate)) '()) (list (string-append "--" type) device))))