From patchwork Mon Aug 21 04:33:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hilton Chain X-Patchwork-Id: 53060 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4588627BBE9; Mon, 21 Aug 2023 05:36:37 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 86BAB27BBE2 for ; Mon, 21 Aug 2023 05:36:36 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXwe3-0007Ke-Qf; Mon, 21 Aug 2023 00:36:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXwe1-0007F3-6W for guix-patches@gnu.org; Mon, 21 Aug 2023 00:36:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXwe0-0003S6-7A; Mon, 21 Aug 2023 00:36:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXwe1-0004oq-S0; Mon, 21 Aug 2023 00:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, guix-patches@gnu.org Resent-Date: Mon, 21 Aug 2023 04:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65413 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 65413@debbugs.gnu.org Cc: Hilton Chain , Ludovic =?utf-8?q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by submit@debbugs.gnu.org id=B.169259255018504 (code B ref -1); Mon, 21 Aug 2023 04:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2023 04:35:50 +0000 Received: from localhost ([127.0.0.1]:55172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXwdq-0004oO-0A for submit@debbugs.gnu.org; Mon, 21 Aug 2023 00:35:50 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXwdn-0004o8-VX for submit@debbugs.gnu.org; Mon, 21 Aug 2023 00:35:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXwdg-0007AA-2F for guix-patches@gnu.org; Mon, 21 Aug 2023 00:35:40 -0400 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXwdd-0003HY-Ud for guix-patches@gnu.org; Mon, 21 Aug 2023 00:35:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1692592507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yHI4UQsIeMNzqTCUzHRa/fMiZd/jVa0OkCB8bhlDBa0=; b=KsofTSR6cSLOUDMqHam/s5rc1+7qGavi7jA2mx0i+VYjjRRNjc/KAlfIkoisDMfieYHput /lErw10HViqtRC8twHTx4rGxqtJdBlyFZmaxMhnqU8LcdXVPJsqTp5yFDRrK/A0GODJhT+ Jv5i4LgvQGLq+Sj5IcJcv+sNRmTdAEJsn9sCHz+sLSWyYiWtZGjOmAjUpkK6hZptDfCvCe W3Tn1AxSdT3bqb5C250wJyfWV7xFeN3rQYRVzzlgDfb4dl547ZbCGQRoZ1T25qOyBggR62 uHjEiWoOki44Cby5IMAATDTON2srSEWEUvRCzXb+JNT9yCDC+OtTUweINsnHLg== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Date: Mon, 21 Aug 2023 12:33:22 +0800 Message-ID: MIME-Version: 1.0 X-Spamd-Bar: + Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches X-Patchwork-Original-From: Hilton Chain via Guix-patches via From: Hilton Chain Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add (shepherd support) for home service. --- This patch fixes the following error: Loading /gnu/store/...-shepherd.conf. herd: error: exception caught while executing 'load' on service 'root': Unbound variable: %user-log-dir I wasn't fully sure to report the issue in #65119 since the error didn't occur in a home container, sorry for my hesitation. gnu/services/mcron.scm | 3 +++ 1 file changed, 3 insertions(+) base-commit: 7cad70566322262f6acdbbb965e867e34010eb55 diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm index db8b539ff5..efb7465549 100644 --- a/gnu/services/mcron.scm +++ b/gnu/services/mcron.scm @@ -165,6 +165,9 @@ (define (mcron-shepherd-services config) (ice-9 popen) ;for the 'schedule' action (ice-9 rdelim) (ice-9 match) + ,(if home-service? + '(shepherd support) ;for '%user-log-dir' + '()) ,@%default-modules)) (start #~(make-forkexec-constructor (list #$(file-append mcron "/bin/mcron")