From patchwork Tue Jul 11 16:19:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Kehayias X-Patchwork-Id: 51675 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5AF6127BBEA; Tue, 11 Jul 2023 17:20:21 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id A687027BBE2 for ; Tue, 11 Jul 2023 17:20:20 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJG5t-0004rj-5d; Tue, 11 Jul 2023 12:20:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJG5r-0004rG-2T for guix-patches@gnu.org; Tue, 11 Jul 2023 12:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJG5q-0008GU-NA for guix-patches@gnu.org; Tue, 11 Jul 2023 12:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJG5q-0001Dk-It for guix-patches@gnu.org; Tue, 11 Jul 2023 12:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64519] [PATCH] gnu: Add freetype-brotli. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Jul 2023 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64519 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: 64519@debbugs.gnu.org Received: via spool by 64519-submit@debbugs.gnu.org id=B64519.16890923974677 (code B ref 64519); Tue, 11 Jul 2023 16:20:02 +0000 Received: (at 64519) by debbugs.gnu.org; 11 Jul 2023 16:19:57 +0000 Received: from localhost ([127.0.0.1]:50946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJG5k-0001DM-S6 for submit@debbugs.gnu.org; Tue, 11 Jul 2023 12:19:57 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:27379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJG5f-0001D6-Pm for 64519@debbugs.gnu.org; Tue, 11 Jul 2023 12:19:56 -0400 Date: Tue, 11 Jul 2023 16:19:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1689092383; x=1689351583; bh=eu0AsGpUL4/ggbmA7H4em6TdvM9NaoK5ZkhVpXhAI3I=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=H8ZrAUDEYw8LbwSR3xWeySZPAFPqm9Fi7NvdNPsb43PO81MzTtm9zJJk9UUHdK9Il nlqkw/lQXemCUJ1tesgXXtgy5DSnKWsuBMlBZ2Q7QEMLo0sngfYTXiDVymSYroj1hx uIgM6mSkRZw0mgPqNpRa6wO2a2D8CUoOnHdmwNefANH9RSA90Qgp9fuDqW9sWKmLkK ygfynw2uxHmRrFZ5MwzWZrupL5gXs/4UNez8Eny1sa8Pm3uujfDbDuNkoa28xRhY1+ nWxk8s2QxVgMQlhcRDW/usZq2g7a75HVqt54Q8bF90QB+80Mvhxye9RiqtfrLkjkAB o7q3Nrm4CMIdg== Message-ID: <87sf9u1kvm.fsf@protonmail.com> In-Reply-To: <87r0pe4kug.fsf@gnu.org> References: <875y6vlmaw.fsf@protonmail.com> <87r0pe4kug.fsf@gnu.org> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches X-Patchwork-Original-From: John Kehayias via Guix-patches via From: John Kehayias Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Ludo, On Tue, Jul 11, 2023 at 03:51 PM, Ludovic Courtès wrote: > Hi John, > [snip] > Looks like the arguments and snippet are too different to be factorized > via inheritance. However, one could still inherit from the other to > factorize license/synopsis/description? > Yes, thought of that afterwards and made that change locally now. > Apart from this minor issue, LGTM! > I completely forgot there is another patch needed here, one to add freetype-brotli. That is just our freetype package with brotli added as a propagated-input for WOFF font support (if I recall). Attaching the patch now. Actually I think our freetype package should do that as well, but since has nearly 18k dependents that should be grouped with other large changes. I brought this up on guix-devel [0] but didn't get any responses about this change. I think it is not controversial, just how to manage the rebuilds. Perhaps on the next mesa/related branch? [0] Thanks! John From f5622c12a84d208efefc53af88fe5f284485f2ff Mon Sep 17 00:00:00 2001 Message-Id: From: John Kehayias Date: Fri, 7 Jul 2023 12:05:16 -0400 Subject: [PATCH] gnu: Add freetype-brotli. * gnu/packages/fontutils.scm (freetype-brotli): New variable. --- gnu/packages/fontutils.scm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm index 1b4e0064f4..ab81499dcb 100644 --- a/gnu/packages/fontutils.scm +++ b/gnu/packages/fontutils.scm @@ -16,6 +16,7 @@ ;;; Copyright © 2021 Sarah Morgensen ;;; Copyright © 2022 Felipe Balbi ;;; Copyright © 2023 gemmaro +;;; Copyright © 2023 John Kehayias ;;; ;;; This file is part of GNU Guix. ;;; @@ -124,6 +125,14 @@ (define-public freetype (license license:freetype) ; some files have other licenses (home-page "https://freetype.org/"))) +(define-public freetype-brotli + (package + (inherit freetype) + (name "freetype-brotli") + (propagated-inputs + (modify-inputs (package-propagated-inputs freetype) + (prepend brotli))))) + (define-public opentype-sanitizer (package (name "opentype-sanitizer") base-commit: 7179d09d0d9762e7463c053ea958832944801ab0 -- 2.40.1