From patchwork Wed Jun 28 18:57:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Liliana Marie Prikler X-Patchwork-Id: 51402 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 94E5C27BBE9; Wed, 28 Jun 2023 20:09:20 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9521727BBE2 for ; Wed, 28 Jun 2023 20:09:17 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEaXK-0003Mi-4J; Wed, 28 Jun 2023 15:09:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEaXG-0003MG-F9 for guix-patches@gnu.org; Wed, 28 Jun 2023 15:09:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEaXG-0006J1-6N for guix-patches@gnu.org; Wed, 28 Jun 2023 15:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEaXF-00050I-MQ for guix-patches@gnu.org; Wed, 28 Jun 2023 15:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64338] [PATCH RFC] gnu: ungoogled-chromium: Build with h264. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: , guix-patches@gnu.org Resent-Date: Wed, 28 Jun 2023 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64338 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64338@debbugs.gnu.org Cc: ( , Christopher Baines , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: ( , Christopher Baines , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart Received: via spool by submit@debbugs.gnu.org id=B.168797932619212 (code B ref -1); Wed, 28 Jun 2023 19:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jun 2023 19:08:46 +0000 Received: from localhost ([127.0.0.1]:51720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEaX0-0004zn-DT for submit@debbugs.gnu.org; Wed, 28 Jun 2023 15:08:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:51936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEaWv-0004zb-3o for submit@debbugs.gnu.org; Wed, 28 Jun 2023 15:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEaWu-0003Jy-FC for guix-patches@gnu.org; Wed, 28 Jun 2023 15:08:40 -0400 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEaWs-00068L-6E for guix-patches@gnu.org; Wed, 28 Jun 2023 15:08:40 -0400 Received: by mail-lj1-x242.google.com with SMTP id 38308e7fff4ca-2b6a152a933so2628591fa.1 for ; Wed, 28 Jun 2023 12:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687979315; x=1690571315; h=to:content-transfer-encoding:mime-version:subject:date:from :message-id:from:to:cc:subject:date:message-id:reply-to; bh=OZiCSHr1rDFPNdRnL9fjcE5Y+iuatH2RMS0N9aVLg2U=; b=Z4dFeShQzBWq5009zRIzttXApeo9nvNBxe1+6XlGdBFAfNcgnzwmj1C9/V8Mjyj03/ 2a6g/Zd0I4aUvHBMgJeqLozgO/KecRtbTXGGMP/tVzCzC1Iusj4LF5cMxUZ02JQbIgnT Y6F8LhlL2XM6SJ98oV8ZNUAK8mxzEdewAQmtaogccl4GObibE+Xo4ONa5Auhw+wabAEL 17RKjcgMqiqnO4AelkjWevGqEokcxKRZgD76A/MgCFOoCY5BlOQp+O2dSp/JvAP6Bw+k 8J6zP4OlFbjb/nP3cDvg6w8weslRLNqnw75Z1rAzepay7jTKoF7VUvwM9+vSNwjlpofv fpUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687979315; x=1690571315; h=to:content-transfer-encoding:mime-version:subject:date:from :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OZiCSHr1rDFPNdRnL9fjcE5Y+iuatH2RMS0N9aVLg2U=; b=Qv2/ayxVMKrChLGMkmq1snedj0BKWXCK5Fc8Dmk7MeCiTL4NIVWL/V/PdV9lGrWunp rubiBJHE1m3VMGIOIfjY2BrLxxs1fxEmlajfkQNe/UOqu8kJLWfgO8lYZxSb8fDnzJ/I 1L+0X7seVyqVrxRJYpkyONRLhbByskLX6CkCwB8bJzBNnPg09K46siAKdlPFe6/Vjfiv iXfQL5oeYzxLZacWc5aWAnjX8H5c2cHyyiQ76Og3CJCKNifO5BR6Jr7sUO9b8YzasgHO 4uHxYdeW1ZxcD+a3z2vJe8pzoPNg5V2N30M/rdiYIv8AUz829/ouZYAWCOCk0HkG+6+2 XsEQ== X-Gm-Message-State: AC+VfDwSed2P5JI2kbujG1UaQktOcGtXfxWqUmIZx7QW8mgTeMq6mjXR EhYuxtVdD8/8HhP1VHmmWKjOS09TmuBCzg== X-Google-Smtp-Source: ACHHUZ4u8acLvcjV2TCdxuyk4ch6jMcialSwkntWqW+fd8dzipeslJVwWSDzjGSXtFP+UemKkUDXlg== X-Received: by 2002:a2e:9cc4:0:b0:2b4:7c31:ab8a with SMTP id g4-20020a2e9cc4000000b002b47c31ab8amr19505075ljj.23.1687979315065; Wed, 28 Jun 2023 12:08:35 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j17-20020a170906279100b0099248468c4esm1597518ejc.21.2023.06.28.12.08.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 12:08:34 -0700 (PDT) Message-Id: <587c8308f3fa585f5f93426e9d0b646170dfe4f0.1687978766.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler Date: Wed, 28 Jun 2023 20:57:37 +0200 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::242; envelope-from=liliana.prikler@gmail.com; helo=mail-lj1-x242.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/chromium.scm (ungoogled-chromium)[configure-flags]: Change “rtc_use_h264=false” to “rtc_use_h264=true”. --- Hi Guix, we haven't had a browser with a working WebRTC implementation for quite some time now (basically, both icecat and ungoogled-chromium choke on h264, which is very important for actually seeing video in video conferences). Looking at chromium in particular, the comment next to the flag disabling this feature appears wrong/possibly outdated. As far as I can tell, our ungoogling script already unbundles openh264, so there is nothing to be afraid of. WDYT? BTW, it would of course be nice to have the same for icecat, and possibly have a GStreamer-based WebRTC once GNOME browsers actually come around to support this use case. I simply looked at chromium first because I recalled it to work perfectly fine before this flag was added. Cheers @ mentors: Sorry to CC you all, but I really want at least 2 LGTMs before pushig. gnu/packages/chromium.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: b24a05830d11e3011eee4bc5f60a41e26188cde1 diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm index cef21a4fd1..6a9f113831 100644 --- a/gnu/packages/chromium.scm +++ b/gnu/packages/chromium.scm @@ -584,7 +584,7 @@ (define-public ungoogled-chromium "ffmpeg_branding=\"Chrome\"" ;; WebRTC stuff. - "rtc_use_h264=false" ;XXX needs bundled openh264 + "rtc_use_h264=true" "rtc_use_pipewire=true" "rtc_link_pipewire=true" ;; Don't use bundled sources.