From patchwork Thu Jun 8 21:27:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 50776 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6C08527BBEB; Thu, 8 Jun 2023 22:28:38 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8B9EA27BBE2 for ; Thu, 8 Jun 2023 22:28:36 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7NB1-0000Bp-MC; Thu, 08 Jun 2023 17:28:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7NAw-0000BO-D5 for guix-patches@gnu.org; Thu, 08 Jun 2023 17:28:11 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7NAo-0000ly-P5 for guix-patches@gnu.org; Thu, 08 Jun 2023 17:28:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7NAo-0006Zb-Kw for guix-patches@gnu.org; Thu, 08 Jun 2023 17:28:02 -0400 Subject: bug#61682: [PATCH] gnu: buildah: Add 'buildah' package Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 08 Jun 2023 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61682 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zongyuan Li Cc: 61682-done@debbugs.gnu.org, liliana.prikler@gmail.com Mail-Followup-To: 61682@debbugs.gnu.org, ludo@gnu.org, zongyuan.li@c0x0o.me Received: via spool by 61682-done@debbugs.gnu.org id=D61682.168625967325248 (code D ref 61682); Thu, 08 Jun 2023 21:28:02 +0000 Received: (at 61682-done) by debbugs.gnu.org; 8 Jun 2023 21:27:53 +0000 Received: from localhost ([127.0.0.1]:57759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7NAf-0006ZA-6N for submit@debbugs.gnu.org; Thu, 08 Jun 2023 17:27:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7NAc-0006Ys-JO for 61682-done@debbugs.gnu.org; Thu, 08 Jun 2023 17:27:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7NAW-0000iD-P8; Thu, 08 Jun 2023 17:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cKMbeaQffaoZIkoXICjGZE3dy2hCpEXuf2lEwTrpjTc=; b=hRFuicN+dYJTTKpDOVYy VpoFqHxZTwigizab8olb4YaXP5FZ9j3R8VPo67jz5Gq34YDvYgo/3Thk4XYPlesWE+BbSX9YaVeGi luhKXcYQ+15gmqTJ+wXJYqVZO8kMnknLg4jXYXpL8BOF4SW2gSSlirKFUv8/OUBxDFVnQCvL/sCWr G77KM9pow1zihdDgNVeK72Wo9x+zjyRKUh9ZLPunz1d0JruTa0iVTXUaFLagZTTzVfN4FGfj/J+IV db70g73/B0R2r3LaR04JKukOzKc15cC5KrV83up/64kKJm79+FWO75sTVMZI0lHRiPYa2/wsXYzJJ rAuVhCD541rOAg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7NAS-0003ES-DX; Thu, 08 Jun 2023 17:27:44 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: Date: Thu, 08 Jun 2023 23:27:39 +0200 In-Reply-To: (Zongyuan Li's message of "Sat, 25 Mar 2023 10:25:05 +0000") Message-ID: <87edmlzltg.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi, Zongyuan Li skribis: > gnu: buildah: Add 'buildah' package > > Introduce new 'buildah' package > > * gnu/packages/containers.scm: New 'buildah' package Finally applied with the changes below, most of which were suggested by Liliana. Thanks, Ludo’. diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm index 839d81cd0e..eb7699c505 100644 --- a/gnu/packages/containers.scm +++ b/gnu/packages/containers.scm @@ -414,8 +414,10 @@ (define-public buildah (arguments (list #:import-path "github.com/containers/buildah/cmd/buildah" #:unpack-path "github.com/containers/buildah" - ; Some dependencies require go-1.18 to build + + ;; Some dependencies require go-1.18 to build. #:go go-1.18 + #:tests? #f #:install-source? #f #:phases @@ -433,14 +435,12 @@ (define-public buildah (("/usr/local") (string-append #$output))))) (add-after 'build 'build-docs (lambda* (#:key unpack-path #:allow-other-keys) - (let* - ((doc-path (string-append "src/" unpack-path "/docs"))) - (invoke "make" "-C" doc-path)))) + (let ((doc (string-append "src/" unpack-path "/docs"))) + (invoke "make" "-C" doc)))) (add-after 'install 'install-docs (lambda* (#:key unpack-path #:allow-other-keys) - (let* - ((doc-path (string-append "src/" unpack-path "/docs"))) - (invoke "make" "-C" doc-path "install"))))))) + (let ((doc (string-append "src/" unpack-path "/docs"))) + (invoke "make" "-C" doc "install"))))))) (inputs (list btrfs-progs cni-plugins conmon @@ -455,10 +455,23 @@ (define-public buildah (list go-github-com-go-md2man gnu-make pkg-config)) - (synopsis - "Build Open Container Initiative images") + (synopsis "Build @acronym{OCI, Open Container Initiative} images") (description - "Buildah is used to build Open Container Initiative -@acronym{OCI, Open Container Initiative} compatible containers.") + "Buildah is a command-line tool to build @acronym{OCI, Open Container +Initiative} container images. More generally, it can be used to: + +@itemize +@item +create a working container, either from scratch or using an image as a +starting point; +@item +create an image, either from a working container or via the instructions +in a @file{Dockerfile}; +@item +mount a working container's root filesystem for manipulation; +@item +use the updated contents of a container's root filesystem as a filesystem +layer to create a new image. +@end itemize") (home-page "https://buildah.io") (license license:asl2.0)))