From patchwork Mon Jun 5 12:03:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 50683 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6A58F27BBEA; Mon, 5 Jun 2023 13:04:19 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C4AE827BBE2 for ; Mon, 5 Jun 2023 13:04:18 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q68wP-0005KK-VB; Mon, 05 Jun 2023 08:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68wO-0005JM-1K for guix-patches@gnu.org; Mon, 05 Jun 2023 08:04:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q68wN-00062B-Ng for guix-patches@gnu.org; Mon, 05 Jun 2023 08:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q68wN-0002zH-JR for guix-patches@gnu.org; Mon, 05 Jun 2023 08:04:03 -0400 Subject: bug#63860: [PATCH] Shepherd: Add Bash completion file. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 05 Jun 2023 12:04:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: 63860-done@debbugs.gnu.org, Liliana Marie Prikler Mail-Followup-To: 63860@debbugs.gnu.org, ludo@gnu.org, go.wigust@gmail.com Received: via spool by 63860-done@debbugs.gnu.org id=D63860.168596662411421 (code D ref 63860); Mon, 05 Jun 2023 12:04:03 +0000 Received: (at 63860-done) by debbugs.gnu.org; 5 Jun 2023 12:03:44 +0000 Received: from localhost ([127.0.0.1]:48313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q68w3-0002y8-M3 for submit@debbugs.gnu.org; Mon, 05 Jun 2023 08:03:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q68w1-0002xi-KW for 63860-done@debbugs.gnu.org; Mon, 05 Jun 2023 08:03:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68vw-0005xo-Da; Mon, 05 Jun 2023 08:03:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=39uzgMGquLIn8M7b89P+AryZ+Ia7HMgpkcS7ZOpv4ug=; b=hQA3Jm+UclLyW52FgW9f KgNmpz0aRa9Ykzzi7yfnn6fiyvwpnoqYPTp/B+paZgBBdF1l7QM9Hv4FGpBDxPIXWos9Sc7M+usBS qGU3vnb9Ckn2ieaXgkQHJEEZr/llwYjdA8PQHQ3Iid8bd6qv2kG36U+abAmn9l3OyNVA3zpnGJMfW 4PioHOjxQ32s3boKbAPip3uR5OOajS3F/9GfSh8PA/6UkP5OszFlmZBgd9j7yHwXLEQQUnVqRQMdj +Q5Ak3DatLYlPP4NePTS0qMxbJXSyf50cFWf9G9Dks9DBV2I3Fnj0OGthSK68is5TlP8n+CrS+qp9 LrMu8sX3IqJuDg==; Received: from [193.50.110.155] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68vu-00070N-LL; Mon, 05 Jun 2023 08:03:36 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= References: <940cd99ec2de7a9d6b6e0ea98670f0031891cdda.camel@gmail.com> <20230604085716.31735-1-go.wigust@gmail.com> Date: Mon, 05 Jun 2023 14:03:32 +0200 In-Reply-To: <20230604085716.31735-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sun, 4 Jun 2023 11:57:16 +0300") Message-ID: <873536jeuj.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello, Oleg Pykhalov skribis: > * etc/completion/bash/herd: New file. > * Makefile.am (dist_bashcompletion_DATA): New variable. > * configure.ac: Add --with-bash-completion-dir. Excellent! Applied with the changes below. Thank you & thanks Liliana for reviewing! Ludo’. diff --git a/NEWS b/NEWS index d6c2fc0..b644adb 100644 --- a/NEWS +++ b/NEWS @@ -13,6 +13,11 @@ Please send Shepherd bug reports to bug-guix@gnu.org. * Changes in 0.10.2 +** New Bash completion + +A Bash completion file is now installed, providing tab completion for the +‘herd’ command. + ** ‘herd’ shows a hint when the service and action are likely swapped The hint is printed for instance when typing ‘herd foobar start’. diff --git a/etc/completion/bash/herd b/etc/completion/bash/herd index f006b86..74e7a24 100644 --- a/etc/completion/bash/herd +++ b/etc/completion/bash/herd @@ -44,8 +44,8 @@ _herd_complete_3() local command="${COMP_WORDS[2]}" case "$command" in guix-daemon) - complitions="on off" - mapfile -t COMPREPLY < <(compgen -W "$complitions" -- "${COMP_WORDS[$COMP_CWORD]}") + completions="on off" + mapfile -t COMPREPLY < <(compgen -W "$completions" -- "${COMP_WORDS[$COMP_CWORD]}") ;; *) ;;