From patchwork Wed Apr 26 22:28:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Kehayias X-Patchwork-Id: 49557 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 45A4627BBE9; Wed, 26 Apr 2023 23:29:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D73CB27BBE2 for ; Wed, 26 Apr 2023 23:29:22 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prndH-0008Dh-BS; Wed, 26 Apr 2023 18:29:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prndG-0008DY-HP for guix-patches@gnu.org; Wed, 26 Apr 2023 18:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prndG-0007M4-9G for guix-patches@gnu.org; Wed, 26 Apr 2023 18:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1prndF-0003Ca-Nh for guix-patches@gnu.org; Wed, 26 Apr 2023 18:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63098] [PATCH] gnu: guitarix: Update to 0.44.1. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 26 Apr 2023 22:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63098 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner Cc: guix-devel@gnu.org, 63098@debbugs.gnu.org X-Debbugs-Original-Cc: guix-devel@gnu.org, Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.168254813412292 (code B ref -1); Wed, 26 Apr 2023 22:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Apr 2023 22:28:54 +0000 Received: from localhost ([127.0.0.1]:57142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prnd7-0003CB-CG for submit@debbugs.gnu.org; Wed, 26 Apr 2023 18:28:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:38046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prnd4-0003C3-VP for submit@debbugs.gnu.org; Wed, 26 Apr 2023 18:28:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prnd4-0008CZ-Ir for guix-patches@gnu.org; Wed, 26 Apr 2023 18:28:50 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prnd0-0007Ku-VG for guix-patches@gnu.org; Wed, 26 Apr 2023 18:28:50 -0400 Date: Wed, 26 Apr 2023 22:28:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1682548124; x=1682807324; bh=T9l3YV5F9lLndZPMnSYZWcDSFI7BTa9+BNcEOjUT8Y8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=EaCI9HSg0Lop6qk4CE0Ik7yiqyFnXS0blZa5HT7P1kVgMAS3xlX7EtPiJ38JkuyaF 53vccgkErm/JDV3at1JS4mBcwCSYqXaCZK2dve61N/47KAE1AAH5a8GX2SEESlzHj9 VM+u1Ach7KlYPZDwLVgNsUKHcgA77wa0cNyxzaY+JPLTs7IbrVeHdtw31MfGfAKPBT JtHaxKJHMXjb40hUmX6QoTR+a0HqiFb4S+lcMYQKgYo8gGM7eE1baqcGKEpEmWyyK8 ZNFb6hT1TzKx8PlwDgoPHS33vd1L7tQYADhqsZwe0J+B4GWAvAWJRA1+gQDecQJvGp MTHglZg71Sblw== Message-ID: <87cz3q5ldh.fsf@protonmail.com> In-Reply-To: References: Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Received-SPF: pass client-ip=185.70.43.22; envelope-from=john.kehayias@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches X-Patchwork-Original-From: John Kehayias via Guix-patches via From: John Kehayias Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Felix, On Wed, Apr 26, 2023 at 02:57 PM, Felix Lechner via \"Development of GNU Guix and the GNU System distribution.\" wrote: > Hi, > > With a recent checkout of Guix, guitarix fails to build from source. > It may be a Python issue. A pertinent excerpt of the log is below. > > Without a patch ready, I wasn't sure where and how to file this report. Thanks! > The usual bug-guix@gnu.org list will do just fine I would say. In any event, I'm cc'ing the patch list with a quick patch that updates the package which builds fine for me locally; I didn't test running it though. I also updated to gexps and removed the native-inputs label. Since this was an update and the package currently doesn't build, I put it as one patch, but maybe it should be split up? I'm not sure (I think usually as separate commit, but here a fix/update for broken package seemed opportune), feel free to chime in anyone. I also did this super quickly, apologies for any silly mistakes. Thanks for the report! John > Kind regards > Felix > > * * * > > [ 477/1048] Compiling src/gx_head/engine/gx_resampler.cpp > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gi18n.h:21, > from > /gnu/store/cbjgz6f8nrb7804nnmmlvpd4y78p8zf3-glibmm-2.64.5/include/glibmm-2.4/glibmm/i18n.h:23, > from ../src/headers/engine.h:43, > from ../src/gx_head/engine/gx_resampler.cpp:27: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30, > from ../src/headers/guitarix.h:35, > from ../src/gx_head/gui/gx_main_boxes.cpp:25: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30, > from ../src/headers/guitarix.h:35, > from ../src/gx_head/gui/gx_main_midi.cpp:25: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In file included from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gthread.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gasyncqueue.h:32, > from > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib.h:32, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdkconfig.h:8, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gdk/gdk.h:30, > from > /gnu/store/3cl87br64f94fr6w45cpwzyn1kv9ma2p-gtk+-3.24.37/include/gtk-3.0/gtk/gtk.h:30, > from ../src/headers/guitarix.h:35, > from ../src/headers/avahi_discover.h:26, > from ../src/gx_head/gui/avahi_discover.cpp:21: > ../src/headers/gx_system.h: In function ‘bool > gx_system::atomic_compare_and_exchange(volatile int*, int, int)’: > /gnu/store/nb40pwd37v6i1g4b1fq4l6q4h9px3asr-glib-2.72.3/include/glib-2.0/glib/gatomic.h:163:44: > error: invalid conversion from ‘volatile void*’ to ‘void*’ > [-fpermissive] > 163 | __atomic_compare_exchange_n ((atomic), &gaicae_oldval, > (newval), FALSE, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST) ? TRUE : FALSE; \ > | ^~~~~~~~~~~~~~ > | | > | volatile void* > ../src/headers/gx_system.h:115:12: note: in expansion of macro > ‘g_atomic_int_compare_and_exchange’ > 115 | return g_atomic_int_compare_and_exchange(p, oldv, newv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Waf: Leaving directory > `/tmp/guix-build-guitarix-0.43.1.drv-0/guitarix-0.43.1/build' > Build failed > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > -> task in 'guitarix' failed with exit status 1 (run with -v to > display more information) > error: in phase 'build': uncaught exception: > %exception #<&invoke-error program: "python" arguments: ("waf" > "build") exit-status: 1 term-signal: #f stop-signal: #f> > phase `build' failed after 68.7 seconds > command "python" "waf" "build" failed with status 1 From c652ee7b7339d287b623692190d66c3f5f3a90ee Mon Sep 17 00:00:00 2001 From: John Kehayias Date: Wed, 26 Apr 2023 18:25:35 -0400 Subject: [PATCH] gnu: guitarix: Update to 0.44.1. * gnu/packages/audio.scm (guitarix): Update to 0.44.1. [arguments]: Use gexps. [native-inputs]: Remove labels --- gnu/packages/audio.scm | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index dca5e516a1..c369fe1bd4 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -2314,7 +2314,7 @@ (define-public freepats-gm (define-public guitarix (package (name "guitarix") - (version "0.43.1") + (version "0.44.1") (source (origin (method url-fetch) (uri (string-append @@ -2322,14 +2322,14 @@ (define-public guitarix version ".tar.xz")) (sha256 (base32 - "1bsjlfd7x09p3iiljilyfbns6hpqn9cgp6psl4ccd6i1lwascfrm")))) + "063cdvrzrpnj08dm22z651hy5cz5bnsywf1z8b2kib2i9xskvs3p")))) (build-system waf-build-system) (arguments - `(#:tests? #f ; no "check" target - #:configure-flags - (list - ;; Add the output lib directory to the RUNPATH. - (string-append "--ldflags=-Wl,-rpath=" %output "/lib")))) + (list #:tests? #f ; no "check" target + #:configure-flags + #~(list + ;; Add the output lib directory to the RUNPATH. + (string-append "--ldflags=-Wl,-rpath=" #$output "/lib")))) (inputs (list libsndfile boost @@ -2347,12 +2347,12 @@ (define-public guitarix zita-resampler zita-convolver)) (native-inputs - `(("gperf" ,gperf) - ("faust" ,faust) - ("intltool" ,intltool) - ("gettext" ,gettext-minimal) - ("pkg-config" ,pkg-config) - ("sassc" ,sassc))) + (list gperf + faust + intltool + gettext-minimal + pkg-config + sassc)) (native-search-paths (list (search-path-specification (variable "LV2_PATH") -- 2.39.2