From patchwork Sat May 17 17:48:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Divya Ranjan X-Patchwork-Id: 42656 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5877F27BC4B; Sat, 17 May 2025 18:49:35 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1AABA27BC49 for ; Sat, 17 May 2025 18:49:35 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uGLem-0003IQ-CJ; Sat, 17 May 2025 13:49:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uGLeh-0003Hv-5k for guix-patches@gnu.org; Sat, 17 May 2025 13:49:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uGLeg-00078q-Sj for guix-patches@gnu.org; Sat, 17 May 2025 13:49:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=z3v4oxgG7/vfS7H92DgqLQvby8jNGvODQH/9EdU8ajs=; b=JRLa17wJ36+n1SV+Hz8pmBbjz8NLGD+3vqcgosZBphsCO4FKTp/jz9H1vxoXDWxrlxxFS4UnzAGz0ZBEJhl9k8DC+Mf4b7/jeW2EHMu8iXhdv3X2h9IrO3tosrd+ZXaNiQTYHdrKt2FmlrDQC8jE+E+CeHpmAHB+XVjGfTLbfkaow7szInvw7KrBGmxXLjfQqLDTGZDUfE2hRfDLPgJ+S8XZ8q2RnFshQ0QDzb2uQ/EkwO/a4J9EqJNTxlOh8pT0gJI9Pi1cj8Bu8Nvx6O7/dz12LPbe33SbWyS6xmCpf0adsuh6IRFHWB5HziuRZZ5Wae5QytsajTxmoCCTPaObFg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1uGLeg-0006I2-JZ for guix-patches@gnu.org; Sat, 17 May 2025 13:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#78401] [PATCH] gnu: mupdf: Update to 1.26.0., [PATCH] gnu: mupdf: Update to 1.26.0., [PATCH] gnu: mupdf: Modify #:make-flags Resent-From: Divya Ranjan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 May 2025 17:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 78401 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Maxim Cournoyer Cc: 78401@debbugs.gnu.org Received: via spool by 78401-submit@debbugs.gnu.org id=B78401.174750413924168 (code B ref 78401); Sat, 17 May 2025 17:49:02 +0000 Received: (at 78401) by debbugs.gnu.org; 17 May 2025 17:48:59 +0000 Received: from localhost ([127.0.0.1]:50724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGLec-0006Hj-De for submit@debbugs.gnu.org; Sat, 17 May 2025 13:48:58 -0400 Received: from confino.investici.org ([93.190.126.19]:29221) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uGLeY-0006HS-JF for 78401@debbugs.gnu.org; Sat, 17 May 2025 13:48:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=subvertising.org; s=stigmate; t=1747504132; bh=z3v4oxgG7/vfS7H92DgqLQvby8jNGvODQH/9EdU8ajs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jYMVzs/vGugKMVggSrNshWaVEw+uiK0NwBgeMreMvPlR9nd29UBsJfqL7ETWbvygO yyCAoXaEz9ZQntZ4/ULXtFm3VNm9c56bWwGJ9yI7aou3CqVfMq7MfoeJjEQC7Bf6c5 vVAauyASpxhIJjD1pRC7XTsO84qMmYfqzteJmaZE= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4b0BJh4mRnz11Hn; Sat, 17 May 2025 17:48:52 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: divya@subvertising.org) by localhost (Postfix) with ESMTPSA id 4b0BJg5vDCz11Gm; Sat, 17 May 2025 17:48:51 +0000 (UTC) In-Reply-To: <87wmagfw36.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Fri, 16 May 2025 23:50:53 +0900") References: <871psrmh3l.fsf@gmail.com> <87sel52i8k.fsf@subvertising.org> <87wmagfw36.fsf_-_@gmail.com> Date: Sat, 17 May 2025 17:48:45 +0000 Message-ID: <87h61jyvpe.fsf@subvertising.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Divya Ranjan X-ACL-Warn: , Divya Ranjan via Guix-patches X-Patchwork-Original-From: Divya Ranjan via Guix-patches via From: Divya Ranjan Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Maxim Cournoyer writes: > Hi Divya, > > Divya Ranjan writes: > > [...] > >>>> * gnu/packages/pdf.scm (mupdf): Update to 1.26.0. >>> >>> Various changes done here are not listed in the change log. Please >>> consult other commits for examples or (info "(standards) Style of Change >>> Logs"). >> >> Please find the updated patch with the indentation and commit message fixed. > > Thanks for you efforts, but the change log is still missing many > entries. It should list for example every input added or remove, every > configure flag added or removed, every phase added or removed, etc. For > some examples, you can install the 'standards' package and consult (info > "(standards) Style of Change Logs"), or simply read examples through > 'git log'. > > While the whitespace is fixed in v2, it seems you ran the package > through 'guix style', which sadly is not always optimal and adds noise > to the diff. Could you please keep this commit to just modify what's > needed? Hello Maxim, Apologies, indeed I had used guix style since I considered that it’d be appropriate. I’ve restricted the patch to now only include the necessary changes. Also find the patch for mupdf-1.24, without which several packages break (as suggested by the QA). From 27443887660f0179610a37c5ca8137021a8afef2 Mon Sep 17 00:00:00 2001 Message-ID: <27443887660f0179610a37c5ca8137021a8afef2.1747504078.git.divya@subvertising.org> From: Divya Ranjan Date: Sat, 17 May 2025 17:47:04 +0000 Subject: [PATCH] * gnu: mupdf-1.24: Modify #:make-flags [arguments]: Disable SONAME Change-Id: I7557a5d8c9638acfc40abd79a78c196eb30f6baa --- gnu/packages/pdf.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm index 017609b338..f716da4d74 100644 --- a/gnu/packages/pdf.scm +++ b/gnu/packages/pdf.scm @@ -969,7 +969,14 @@ (define-public mupdf-1.24 ; Needed for sioyek (for-each delete-file-recursively (lset-difference string=? (scandir ".") - (cons* "." ".." keep)))))))))) + (cons* "." ".." keep)))))))) + (arguments + (substitute-keyword-arguments (package-arguments mupdf) + ((#:make-flags flags) + #~(append (filter (lambda (flag) + (not (string-prefix? "USE_SONAME=" flag))) + #$flags) + (list "USE_SONAME=no"))))))) (define-public qpdf base-commit: efac01f19b65d7d77a98bbfd57fe2073fb13064a prerequisite-patch-id: bc8c7d6415d46bb7e474e6c50bf33339c41defd3 -- 2.49.0