From patchwork Wed Mar 22 01:12:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: TakeV X-Patchwork-Id: 48558 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D4F0B16F94; Wed, 22 Mar 2023 01:13:31 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 25C5B16D28 for ; Wed, 22 Mar 2023 01:13:28 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pen2H-0006cB-KM; Tue, 21 Mar 2023 21:13:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pen2F-0006c2-FO for guix-patches@gnu.org; Tue, 21 Mar 2023 21:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pen2E-00045D-Vt for guix-patches@gnu.org; Tue, 21 Mar 2023 21:13:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pen2E-0002yS-LY for guix-patches@gnu.org; Tue, 21 Mar 2023 21:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62362] [PATCH] gnu: remmina: Update to 1.4.29. Resent-From: TakeV Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 01:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62362 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62362@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167944756011389 (code B ref -1); Wed, 22 Mar 2023 01:13:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Mar 2023 01:12:40 +0000 Received: from localhost ([127.0.0.1]:32985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pen1r-0002xd-OD for submit@debbugs.gnu.org; Tue, 21 Mar 2023 21:12:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:37092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pen1q-0002xV-18 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 21:12:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pen1p-0006J9-HF for guix-patches@gnu.org; Tue, 21 Mar 2023 21:12:37 -0400 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pen1n-0003tw-18 for guix-patches@gnu.org; Tue, 21 Mar 2023 21:12:37 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A2B79444CD for ; Wed, 22 Mar 2023 02:12:30 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5FKKhZKwbTEo for ; Wed, 22 Mar 2023 02:12:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1679447549; bh=eXtHe+eUTuR6d9Ful7uOa/UY69LTeAj/Kkjt+oertNY=; h=Date:To:From:Subject; b=KoJkshPcv/IG5+l0VW/J6H8niyyCIo+LqPDbJWRj4ZOgx8XqJrkrVUx9JHYSa0829 ru72FzljMEkj/dCYNdSDTYkGb3OIWvPCW99Ar+bAn9entJujy3Ig5LXMtkWiBAF6ts 7e+sYnNBKWi7+dHzUBgtFmIiyE/kdhWQMpqHX+/+Qmcbg5NysKUpZCKPNtdRbW+X1/ z9dVpDS67C5xBGFn+D6ODlgqb+FxINv1ATd+32KeVnEsoQd21x0dkI7Xewolqr4Kk8 F4laKfZaJn6ePed6q6gnuOhI7SRjrBzR+aHiGDgVhcq2T7rzwMf5bT5ZThzfCTSQjH kGhSo8Hjbrwnw== Message-ID: <8a32451a-d1c7-239a-5881-ff8040bea075@disroot.org> Date: Tue, 21 Mar 2023 18:12:25 -0700 MIME-Version: 1.0 Content-Language: en-US Received-SPF: pass client-ip=178.21.23.139; envelope-from=takev@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: TakeV X-ACL-Warn: , TakeV via Guix-patches X-Patchwork-Original-From: TakeV via Guix-patches via From: TakeV Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello there, I ran into a weird bug with remmina, where it was getting different libsoup symbols and being unable to start. Found the exact issue here: https://gitlab.com/Remmina/Remmina/-/issues/2756 Upgrading remmina (via guix refresh) as they suggested worked like a charm, though it did require adding a minimal python input, since there is a new plugin that remmina includes. I also ran it through guix style. Sending in a patch so anyone else affected can get the fix! :) - TakeV From d2f235c5ce67f876324837c3bf035ed5735e1028 Mon Sep 17 00:00:00 2001 Message-Id: From: TakeV Date: Tue, 21 Mar 2023 16:11:45 -0700 Subject: [PATCH] gnu: remmina: Update to 1.4.29. * gnu/packages/vnc.scm (remmina): Update to 1.4.29. --- gnu/packages/vnc.scm | 168 +++++++++++++++++++++---------------------- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/gnu/packages/vnc.scm b/gnu/packages/vnc.scm index fc272ae621..8008be5081 100644 --- a/gnu/packages/vnc.scm +++ b/gnu/packages/vnc.scm @@ -7,6 +7,7 @@ ;;; Copyright © 2021, 2022 Tobias Geerinckx-Rice ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022 Mehmet Tekman +;;; Copyright © 2023 TakeV ;;; ;;; This file is part of GNU Guix. ;;; @@ -72,94 +73,93 @@ (define-module (gnu packages vnc) (define-public remmina (package (name "remmina") - (version "1.4.23") - (source - (origin - (method git-fetch) - (uri - (git-reference - (url "https://gitlab.com/Remmina/Remmina") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) - (sha256 - (base32 "1j0fiz76z4y08w136vs8igqxxg42hx61r5hf6sylcr0c424sc9rk")))) + (version "1.4.29") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/Remmina/Remmina") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "098f33v5qq6p7zjynj1pdllpmbxvqhfvwgvl9fjqyqfflsp7s7gh")))) (build-system cmake-build-system) (arguments - `(#:tests? #f ; No target - #:configure-flags - (list - ;; Disable online version checking. - "-DWITH_NEWS=OFF") - #:imported-modules - ((guix build glib-or-gtk-build-system) - ,@%cmake-build-system-modules) - #:modules - (((guix build glib-or-gtk-build-system) - #:prefix glib-or-gtk:) - (guix build cmake-build-system) - (guix build utils)) - #:phases - (modify-phases %standard-phases - (add-after 'install 'glib-or-gtk-compile-schemas - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas)) - (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) - (add-after 'glib-or-gtk-wrap 'wrap-typelibs - (lambda* (#:key outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out"))) - (for-each - (lambda (name) - (let ((file (string-append out "/bin/" name)) - (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) - (wrap-program file - `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))) - '("remmina" "remmina-file-wrapper")))))))) - (native-inputs - (list gettext-minimal - `(,glib "bin") - gobject-introspection - `(,gtk+ "bin") - intltool - pkg-config)) - (inputs - (list libappindicator - atk - avahi - cairo - cups - ffmpeg - freerdp ; for rdp plugin - libgcrypt - librsvg - glib - gnome-keyring - gsettings-desktop-schemas - gtk+ - harfbuzz - json-glib - libsecret ; for secret plugin - libsoup-minimal-2 - libssh ; for ssh plugin - libvnc ; for vnc plugin - openssl - pango - pcre2 ; for exec plugin - shared-mime-info - libsodium - spice-gtk ; for spice plugin - telepathy-glib - vte ; for st plugin - wayland - webkitgtk ; for www plugin - libx11 - libxext ; for xdmcp plugin - xdg-utils - libxkbfile)) ; for nx plugin - (propagated-inputs - (list dconf)) + `(#:tests? #f ;No target + #:configure-flags (list + ;; Disable online version checking. + "-DWITH_NEWS=OFF") + #:imported-modules ((guix build glib-or-gtk-build-system) + ,@%cmake-build-system-modules) + #:modules (((guix build glib-or-gtk-build-system) + #:prefix glib-or-gtk:) + (guix build cmake-build-system) + (guix build utils)) + #:phases (modify-phases %standard-phases + (add-after 'install 'glib-or-gtk-compile-schemas + (assoc-ref glib-or-gtk:%standard-phases + 'glib-or-gtk-compile-schemas)) + (add-after 'glib-or-gtk-compile-schemas 'glib-or-gtk-wrap + (assoc-ref glib-or-gtk:%standard-phases + 'glib-or-gtk-wrap)) + (add-after 'glib-or-gtk-wrap 'wrap-typelibs + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (for-each (lambda (name) + (let ((file (string-append out "/bin/" + name)) + (gi-typelib-path (getenv + "GI_TYPELIB_PATH"))) + (wrap-program file + `("GI_TYPELIB_PATH" ":" + prefix + (,gi-typelib-path))))) + '("remmina" "remmina-file-wrapper")))))))) + (native-inputs (list gettext-minimal + `(,glib "bin") + gobject-introspection + `(,gtk+ "bin") + intltool + pkg-config)) + (inputs (list libappindicator + atk + avahi + cairo + cups + ffmpeg + freerdp ;for rdp plugin + libgcrypt + librsvg + glib + gnome-keyring + gsettings-desktop-schemas + gtk+ + harfbuzz + json-glib + libsecret ;for secret plugin + libsoup-minimal-2 + libssh ;for ssh plugin + libvnc ;for vnc plugin + openssl + pango + pcre2 ;for exec plugin + python-minimal-wrapper ;for python wrapper plugin + shared-mime-info + libsodium + spice-gtk ;for spice plugin + telepathy-glib + vte ;for st plugin + wayland + webkitgtk ;for www plugin + libx11 + libxext ;for xdmcp plugin + xdg-utils + libxkbfile)) ;for nx plugin + (propagated-inputs (list dconf)) (home-page "https://remmina.org/") (synopsis "Remote Desktop Client") - (description "Remmina is a client to use other desktops remotely. + (description + "Remmina is a client to use other desktops remotely. RDP, VNC, SPICE, NX, XDMCP, SSH and EXEC network protocols are supported.") (license license:gpl2+))) -- 2.39.2