From patchwork Thu Feb 23 06:37:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Tai X-Patchwork-Id: 47224 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id DA59F16BBF; Thu, 23 Feb 2023 06:38:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8321416BA9 for ; Thu, 23 Feb 2023 06:38:24 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pV5Ez-0002AP-VG; Thu, 23 Feb 2023 01:38:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV5Ey-0002A5-2O for guix-patches@gnu.org; Thu, 23 Feb 2023 01:38:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pV5Ew-0000aA-LX for guix-patches@gnu.org; Thu, 23 Feb 2023 01:38:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pV5Ew-0005rL-5s for guix-patches@gnu.org; Thu, 23 Feb 2023 01:38:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61592] [PATCH v2 1/2] gnu: meld: Update to 3.22.0 References: <20230218021218.10783-1-atai@atai.org> In-Reply-To: <20230218021218.10783-1-atai@atai.org> Resent-From: Andy Tai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Feb 2023 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61592 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: liliana.prikler@gmail.com, 61592@debbugs.gnu.org Cc: Andy Tai Received: via spool by 61592-submit@debbugs.gnu.org id=B61592.167713423622451 (code B ref 61592); Thu, 23 Feb 2023 06:38:02 +0000 Received: (at 61592) by debbugs.gnu.org; 23 Feb 2023 06:37:16 +0000 Received: from localhost ([127.0.0.1]:60985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV5EB-0005q2-KT for submit@debbugs.gnu.org; Thu, 23 Feb 2023 01:37:16 -0500 Received: from mail-pl1-f171.google.com ([209.85.214.171]:33626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV5E9-0005pn-Mk for 61592@debbugs.gnu.org; Thu, 23 Feb 2023 01:37:15 -0500 Received: by mail-pl1-f171.google.com with SMTP id s5so11573363plg.0 for <61592@debbugs.gnu.org>; Wed, 22 Feb 2023 22:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=Nq709yVXQ6tsBLR5e6t+qDjcatzHpeLxmv2zvvrdmHQ=; b=W3wWRbweoWMQu0GTFkF3rZ2KYgiqoegrokkGy0dx9tVhAMAComyFE6nQacWTlORZ0T 4Dlk3LPgyvnYsPHC7Em3IzQcZZyV5xmVwiVGEpAvPfs+EowW7bwMPOnpOHKhdas0u+Ak QsJrT6NUmC9ixnRS+uFSn6oh7k1QhrM02JSkF+Pu7LpNp/WbwIHajQnw9O01F8SDX1B4 EfwgHOkLr6I59hq8ZPxfT3F2iabvFG7xT1wVlhaDSHbpqXC8UJjag3LbYV9BrI1+DzuU w45XRIHs0Yr++smMmS7L+wrMh4XlUrYquptcAvks5IM78RG3isx8WS/DJEbh1N8DT3A7 8QBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nq709yVXQ6tsBLR5e6t+qDjcatzHpeLxmv2zvvrdmHQ=; b=3/XBnZDGiiqgxFD6rCmBREOODT211HKLINcmm86BkaCtwujOvnL8YkelMGmQulWYX5 kOHRFmqLGKMgL8CnoNw69BOWiyHia+4eUMXq+zpWeP9bTDCwJO6kd9msVDFgbyeJskPq P2SqqxdKvAp9yGo0bgZHhpcxSKOH2VCoTU8hLxzojVWQyhcUhND7guXm+s24YBtXTnVM X0tZbT3GRLD0vbdYxV5BpjzEHvsDgMAplzoNAY+/GXHLEvbWkoJKZ3nJzAS8e/hBsV9h pMGogzI5Ta3sHXV0AwujTr47UbXK0+xtGcQPl/491OfcAFLepQLfOAWDtJkBOtk9sxtM WK9g== X-Gm-Message-State: AO0yUKW7UaQGFFDMbEHMLAUY2sx8/KBfZAFNF4vRb70YtCv4PHJ+kR8U qkbj1B/Zr+dG8JL9+nUwdh0= X-Google-Smtp-Source: AK7set+lnS52mSXBqKsZ9vDbuiGljG5R3mnvv4dj2RoFYFNsUZeRDCGqVUO5rjwlEYLPBQJSYUL/7g== X-Received: by 2002:a17:902:fb4e:b0:19c:37ed:6517 with SMTP id lf14-20020a170902fb4e00b0019c37ed6517mr11141370plb.27.1677134227400; Wed, 22 Feb 2023 22:37:07 -0800 (PST) Received: from localhost.localdomain ([98.37.226.98]) by smtp.googlemail.com with ESMTPSA id iw6-20020a170903044600b0019a5aa7eab0sm669043plb.54.2023.02.22.22.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 22:37:06 -0800 (PST) From: Andy Tai Date: Wed, 22 Feb 2023 22:37:02 -0800 Message-Id: <20230223063702.5591-1-atai@atai.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/patchutils.scm (meld): Update to 3.22.0 --- gnu/packages/patchutils.scm | 79 ++++++++++++++++--------------------- 1 file changed, 35 insertions(+), 44 deletions(-) base-commit: 31735e0ccfbc61905eb8558c14747bfcaea9b50f diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm index dd5e6bae9a..d093391ce5 100644 --- a/gnu/packages/patchutils.scm +++ b/gnu/packages/patchutils.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2019 Christopher Baines ;;; Copyright © 2021 Xinglu Chen ;;; Copyright © 2022 jgart +;;; Copyright © 2023 Andy Tai ;;; ;;; This file is part of GNU Guix. ;;; @@ -29,6 +30,8 @@ (define-module (gnu packages patchutils) #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix build-system gnu) + #:use-module (guix build-system glib-or-gtk) + #:use-module (guix build-system meson) #:use-module (guix build-system python) #:use-module (gnu packages) #:use-module (gnu packages ed) @@ -37,6 +40,7 @@ (define-module (gnu packages patchutils) #:use-module (gnu packages check) #:use-module (gnu packages databases) #:use-module (gnu packages django) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages file) #:use-module (gnu packages gawk) #:use-module (gnu packages gettext) @@ -47,8 +51,11 @@ (define-module (gnu packages patchutils) #:use-module (gnu packages less) #:use-module (gnu packages mail) #:use-module (gnu packages ncurses) + #:use-module (gnu packages package-management) #:use-module (gnu packages perl) + #:use-module (gnu packages pkg-config) #:use-module (gnu packages python) + #:use-module (gnu packages python-build) #:use-module (gnu packages python-xyz) #:use-module (gnu packages version-control) #:use-module (gnu packages xml)) @@ -214,7 +221,7 @@ (define-public vbindiff (define-public meld (package (name "meld") - (version "3.20.4") + (version "3.22.0") (source (origin (method url-fetch) @@ -222,66 +229,50 @@ (define-public meld (version-major+minor version) "/meld-" version ".tar.xz")) (sha256 - (base32 "04vx2mdbcdin0g3w8x910czfch5vyrl8drv1f2l8gxh6qvp113pl")))) - (build-system python-build-system) + (base32 "03f4j27amyi28flkks8i9bhqzd6xhm6d3c6jzxc57rzniv4hgh9z")))) + (build-system meson-build-system) (native-inputs - `(("intltool" ,intltool) + `(("desktop-file-utils" ,desktop-file-utils) + ("intltool" ,intltool) + ("itstool" ,itstool) ("xmllint" ,libxml2) ("glib-compile-schemas" ,glib "bin") - ("python-pytest" ,python-pytest))) + ("gtk-update-icon-cache" ,gtk+ "bin") + ("gobject-introspection" ,gobject-introspection) + ("pkg-config" ,pkg-config) + ("python" ,python))) (inputs - `(("python-cairo" ,python-pycairo) + `(("bash-minimal" ,bash-minimal) + ("python" ,python) + ("python-cairo" ,python-pycairo) ("python-gobject" ,python-pygobject) ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) - ("gtksourceview" ,gtksourceview-3))) + ("gtksourceview" ,gtksourceview-4))) (propagated-inputs (list dconf)) (arguments - `(#:imported-modules ((guix build glib-or-gtk-build-system) - ,@%python-build-system-modules) - #:modules ((guix build python-build-system) - ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:) + (list + #:glib-or-gtk? #t + #:imported-modules `(,@%meson-build-system-modules + (guix build python-build-system)) + #:modules '((guix build meson-build-system) + ((guix build python-build-system) #:prefix python:) (guix build utils)) #:phases - (modify-phases %standard-phases - ;; This setup.py script does not support one of the Python build - ;; system's default flags, "--single-version-externally-managed". - (replace 'install - (lambda* (#:key outputs #:allow-other-keys) - (invoke "python" "setup.py" - ;; This setup.py runs gtk-update-icon-cache which we don't want. - "--no-update-icon-cache" - ;; "--no-compile-schemas" - "install" - (string-append "--prefix=" (assoc-ref outputs "out")) - "--root=/"))) - ;; The tests need to be run after installation. - (delete 'check) - (add-after 'install 'check - (lambda* (#:key inputs outputs #:allow-other-keys) - ;; Tests look for installed package - (add-installed-pythonpath inputs outputs) - ;; The tests fail when HOME=/homeless-shelter. - (setenv "HOME" "/tmp") - (invoke "py.test" "-v" "-k" - ;; TODO: Those tests fail, why? - "not test_classify_change_actions"))) + #~(modify-phases %standard-phases (add-after 'install 'copy-styles (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((styles "/share/gtksourceview-3.0/styles")) + (let ((styles "/share/gtksourceview-4/styles")) (copy-recursively (string-append (assoc-ref inputs "gtksourceview") styles) (string-append (assoc-ref outputs "out") styles)) #t))) - (add-after 'wrap 'glib-or-gtk-wrap - (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)) - (add-after 'wrap 'wrap-typelib - (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out"))) - (wrap-program (string-append out "/bin/meld") - `("GI_TYPELIB_PATH" prefix - ,(search-path-as-string->list (getenv "GI_TYPELIB_PATH")))) - #t)))))) + (add-after 'glib-or-gtk-wrap 'python-and-gi-wrap + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (search-input-file outputs "bin/meld") + `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH") + ,(python:site-packages inputs outputs))) + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))))))) (home-page "https://meldmerge.org/") (synopsis "Compare files, directories and working copies") (description "Meld is a visual diff and merge tool targeted at