From patchwork Fri Mar 7 13:02:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Baines X-Patchwork-Id: 39756 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 04FB127BBEA; Fri, 7 Mar 2025 13:05:04 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B42FF27BBE2 for ; Fri, 7 Mar 2025 13:05:03 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tqXNR-0000Ak-IY; Fri, 07 Mar 2025 08:04:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqXMx-0008L7-Gr for guix-patches@gnu.org; Fri, 07 Mar 2025 08:04:06 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tqXMx-00051y-2S for guix-patches@gnu.org; Fri, 07 Mar 2025 08:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=4XbqrAyk8Bn8Jf4fe2VfwAIygm1oTTfVEzOPaFu97YY=; b=SoAeSEn0BJhYP1Hc5Fb3AMLD5q8PudfnX4TuPX6QcVHE/ui6dz9V7vU/PS3St/9F/I52tjBGvAhbBIfdYRzawxOqveftj6mv/2kTowfcxyi1VTZtYW4muGDrBHGWsR+gm0uh1kbL7gW8nwa05Pr1NHD6f02yiqH4JS9Mf/U6WPu482UNA6hKJDz9zd2xqIwMNm0wlIxRYD+VvzxChDL+f8tP2bh3Rgm81NJ/4kPitVCujCfyVTVvfYgOaEQYtNYGZl+Ech1pP8QpLWZw8UsrE0kquRE35PRWOlS/DBlf5cX3huKScC05fJeiKYP6DGbgvNY113TJEKUD1JB4WM6anQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tqXMw-0000sq-I4 for guix-patches@gnu.org; Fri, 07 Mar 2025 08:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Mar 2025 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76811 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76811@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17413526003336 (code B ref -1); Fri, 07 Mar 2025 13:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Mar 2025 13:03:20 +0000 Received: from localhost ([127.0.0.1]:47410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqXMF-0000rj-IW for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:03:19 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55818) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqXMD-0000qa-Uh for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:03:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqXLK-0007ai-0g for guix-patches@gnu.org; Fri, 07 Mar 2025 08:02:26 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tqXLH-00045Y-9R for guix-patches@gnu.org; Fri, 07 Mar 2025 08:02:21 -0500 Received: from localhost (unknown [IPv6:2a02:6b67:e390:8b00::1ce5]) by mira.cbaines.net (Postfix) with ESMTPSA id 880D427BBE2 for ; Fri, 7 Mar 2025 13:02:16 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 21498c0b for ; Fri, 7 Mar 2025 13:02:15 +0000 (UTC) From: Christopher Baines Date: Fri, 7 Mar 2025 13:02:15 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches I'm not sure where invoke is coming from here, but it could be from (guix build utils), that uses system* which uses waitpid, which might cause problems with recent versions of the shepherd? At least I'm seeing issues on multiple machines where attempting to restart the nginx service sometimes causes the shepherd to hang. * gnu/services/web.scm (nginx-shepherd-service): Replace invoke with spawn-command. Change-Id: Ie9ce4be9a4df121465b28148612b4fbc45fb5126 --- gnu/services/web.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: 9bc4c9f521caab8aa8d88aa948a650945bb55838 diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 7593cd2eaa..b46a4db73f 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -870,7 +870,8 @@ (define (nginx-shepherd-service config) (nginx-action (lambda args #~(lambda _ - (invoke #$nginx-binary "-c" #$config-file #$@args) + (spawn-command + (list #$nginx-binary "-c" #$config-file #$@args)) (match '#$args (("-s" . _) #t) (_