From patchwork Sun Feb 16 17:21:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Josefsson X-Patchwork-Id: 38750 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E37AE27BBE9; Sun, 16 Feb 2025 17:23:22 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 167F127BBE2 for ; Sun, 16 Feb 2025 17:23:21 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tjiMD-0001dQ-52; Sun, 16 Feb 2025 12:23:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjiMA-0001cy-Vy for guix-patches@gnu.org; Sun, 16 Feb 2025 12:23:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tjiMA-0005Uj-Mh for guix-patches@gnu.org; Sun, 16 Feb 2025 12:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=7vWri9MAwqwXFg5KflWZ+KQzdWwqcLftNQSDBxmaF6g=; b=vq489TsTMccPr/Akat+TCCRvwA3NUmQV/YHeSIAr26gFRpxLxP5gUxhDhCXUADZp+SEuqrqW3xYIrY8IunNY26a/Nrg6q9SEHLbaMu5Zps0o2hHq9su8o1ymjZiAzoMZoX/PuMC1nG9GOKE/0zO/RSSXxlX6rJljwerTG4GdSIF6Oei1iHo8RInBVNWvo29fxPjGQvs50LYfIB21vQeO+dSaAitVMdQ8TbH18Ftih72E9gLluyMOWQLufPfSAXORKiA+RVFhTF4Tfi+PpL1dPxba8UYWEofrqo9DaerWX9Myt9KAReb1k5Y9IYwiWsM82NHw5647kG1I9yBiDUgaGw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tjiMA-0005BE-Fx for guix-patches@gnu.org; Sun, 16 Feb 2025 12:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#76342] [PATCH] build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. Resent-From: Simon Josefsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Feb 2025 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76342 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76342@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173972652719691 (code B ref -1); Sun, 16 Feb 2025 17:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Feb 2025 17:22:07 +0000 Received: from localhost ([127.0.0.1]:36764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjiLG-00057W-GY for submit@debbugs.gnu.org; Sun, 16 Feb 2025 12:22:06 -0500 Received: from lists.gnu.org ([2001:470:142::17]:54712) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tjiLB-00056L-Nn for submit@debbugs.gnu.org; Sun, 16 Feb 2025 12:22:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjiL2-00010n-N9 for guix-patches@gnu.org; Sun, 16 Feb 2025 12:21:52 -0500 Received: from uggla.sjd.se ([2001:9b1:8633::107]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjiKz-0005OK-MX for guix-patches@gnu.org; Sun, 16 Feb 2025 12:21:52 -0500 DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=ed2303; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description; bh=7vWri9MAwqwXFg5KflWZ+KQzdWwqcLftNQSDBxmaF6g=; t=1739726499; x=1740936099; b=4C5sJP/KLEPhLJCO/QGQnvvDdulfNeu3MVSQNaxhmifUPda 2WhVl70sSf1fne0Tx4czxmyzHpOJEQv+ZthncDw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=rsa2303; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description; bh=7vWri9MAwqwXFg5KflWZ+KQzdWwqcLftNQSDBxmaF6g=; t=1739726499; x=1740936099; b=K+EcIl+1R9V64cmM44Bc+Iivn0MxHfmLEqmOuySBjUTvC/1 S/Q2y+dmyNs06yFm1pDhECFsh6dqAjkQrN2YT6b2aKVIFLDUGwRLx/X/VDprIiw4Er30+asahGPQO OKpveDSfDzM1mGTSjjT5Zr/Gm9k1/t8GfeejSPlx7E/eisdx0x11r1NRalZE1VQ6lXyoBCj9ABYUj e9Ytq1mCPbaw/YaijsQTxcFRd2nEWTuOU5y7GTyLkSzHCk44rPZtJm9TcFklzZ8p9uKAKdltZYtZM ha66c367mFDdAsBUjkFU2qE2iOZmEVue5qDHP+CK06J90NewNDwIUvY40KKNIcN+V0bjLYOFqG1MW BwgfztWBkmnHRBesqbG8Grms9zsVwkp9PwXnVzHKWMIQ+ry82hyKbq2zYy5XZbOC/dtF1rsxeSMl1 JF2EjM3+7UnjZ8xEbcjOUDd8; Received: from h-178-174-130-130.a498.priv.bahnhof.se ([178.174.130.130]:57184 helo=kaka) by uggla.sjd.se with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tjiKk-00BIpw-7q for guix-patches@gnu.org; Sun, 16 Feb 2025 17:21:34 +0000 OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt X-Hashcash: 1:23:250216:guix-patches@gnu.org::gI+p0Q5b6/M0/xTs:ZVV0 Date: Sun, 16 Feb 2025 18:21:41 +0100 Message-ID: <87frkdls9m.fsf@josefsson.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Received-SPF: pass client-ip=2001:9b1:8633::107; envelope-from=simon@josefsson.org; helo=uggla.sjd.se X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Simon Josefsson X-ACL-Warn: , Simon Josefsson via Guix-patches X-Patchwork-Original-From: Simon Josefsson via Guix-patches via From: Simon Josefsson Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi The Debian QA linters noticed that some CC flags were missing, and this patch fixes it. It seems the default CFLAGS for me is '-O2 -g' when running ./configure so I dropped those since they were added twice otherwise. Maye -Wall should be moved to a Makefile.am AM_CFLAGS (or something), but the attached patch seems sufficient to silences Debian's "blhc" tool which is my main concern. https://salsa.debian.org/debian/shepherd/-/jobs/7100765 400:CFLAGS missing (-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection): \ gcc -O2 -g -Wall -shared -fPIC -o "etc/crash-handler.so" "etc/crash-handler.c" 400:CPPFLAGS missing (-D_FORTIFY_SOURCE=2): \ gcc -O2 -g -Wall -shared -fPIC -o "etc/crash-handler.so" "etc/crash-handler.c" 400:LDFLAGS missing (-Wl,-z,relro): \ gcc -O2 -g -Wall -shared -fPIC -o "etc/crash-handler.so" "etc/crash-handler.c" /Simon From fdaeac0a71f3bdd1daaafffc46647f05e019ac10 Mon Sep 17 00:00:00 2001 From: Simon Josefsson Date: Sun, 16 Feb 2025 16:11:04 +0100 Subject: [PATCH] build: Pass CFLAGS, CPPFLAGS and LDFLAGS to CC. * Makefile.am (etc/crash-handler.so): Do it. Signed-off-by: Simon Josefsson --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index aa2edd9..bc87404 100644 --- a/Makefile.am +++ b/Makefile.am @@ -107,7 +107,7 @@ install-crash-handler: etc/crash-handler.so: etc/crash-handler.c $(AM_V_GEN)$(MKDIR_P) etc; \ - $(CC) -O2 -g -Wall -shared -fPIC -o "$@" "$^" + $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -Wall -shared -fPIC -o "$@" "$^" CLEANFILES += etc/crash-handler.so -- 2.48.1