From patchwork Thu Jan 23 09:25:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vagrant Cascadian X-Patchwork-Id: 37620 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CC10527BBEA; Thu, 23 Jan 2025 09:26:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2123D27BBE2 for ; Thu, 23 Jan 2025 09:26:27 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tatTY-0007UG-UO; Thu, 23 Jan 2025 04:26:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tatTP-0007U2-TF for guix-patches@gnu.org; Thu, 23 Jan 2025 04:26:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tatTO-0006OZ-19 for guix-patches@gnu.org; Thu, 23 Jan 2025 04:26:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=43Lebd0RazL/uu6/kCmbO58pP6KLE7IuwzXCCPfKJAA=; b=MejNkeLPDv2b4ypgByeWcTa1w95y8thgaefR/0yz/F1Xt5/F8f+sYmMiq2RKwG7baaHZP09TZ8RR7r1Nf/16a70Cl7ux9fglUd1egmcydFImR7WQTHwA3g4Ltw57PzuOumVUcZKxcD6tNDGeBeaaLChl24Fw03bOJJ20BxyUgInWhkL7WbqCLRNphc59iMmMDJypjzCp8MbOnkmc14pO9xdlI84boX+e1Ml6xdrQ5uWMIT07hZaT5hTZs5uVHsUkLPf+Cb/f5ieVZySwB7arwpHf8SUD9qhOGfrF70iXukVLvbJ1kFZOVAC8e4c9gQm0P6zgKuVmAgFmDCATTSc28g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tatTN-0002oj-Re for guix-patches@gnu.org; Thu, 23 Jan 2025 04:26:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75781] Reduce unused native-inputs for grub-efi and grub-minimal Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jan 2025 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75781 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 75781@debbugs.gnu.org Cc: ludo@gnu.org, efraim@flashner.co.il X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173762433710762 (code B ref -1); Thu, 23 Jan 2025 09:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jan 2025 09:25:37 +0000 Received: from localhost ([127.0.0.1]:39297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tatSz-0002nW-4S for submit@debbugs.gnu.org; Thu, 23 Jan 2025 04:25:37 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48362) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tatSv-0002n4-Dl for submit@debbugs.gnu.org; Thu, 23 Jan 2025 04:25:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tatSi-00074y-SX for guix-patches@gnu.org; Thu, 23 Jan 2025 04:25:21 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tatSf-0006K6-E2; Thu, 23 Jan 2025 04:25:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1737624310; bh=Ir1ASBweco9hErI1phcG8efk+rOGE8sIE/L2w0bzQh0=; h=From:To:Cc:Subject:Date:From; b=YNPpgYoajict6SXg6YQpOFoqMatjXLEEn4gs1eY4i2X8d3iZpWExNgMjd9bmr7qxM 1ibFIT/5ZLTz2snZOMGUi6svkediq0uHFBhWRCNCEdVcpKrdXv7VWqTtNrzdaXr24E OivOZGbbN1cM4+DPfFiKcIWloJpFu8Y7Vr6Kv/MYqEX+Kvw8ILOQe7AH4jb5yFCjTS /HUUF+Y/3mjdriRC/+L1hS2HpsoKeqaXIj/8SUPcVx4CiQiEJ3pq6AAZliO4E/2vK1 /YP/bq8uH1VihUkwdEHyoY/PmKulR+oZjGFEwtcfY5VMh8SgaDpe+PZoBSOGQ3+vkc ZzvKrae+DJ8hQ== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id B20EF3102; Thu, 23 Jan 2025 01:25:10 -0800 (PST) From: Vagrant Cascadian Date: Thu, 23 Jan 2025 01:25:04 -0800 Message-ID: <87wmelubkf.fsf@wireframe> MIME-Version: 1.0 Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches The attached patch removes the native-inputs on qemu-minimal for both grub-efi and grub-minimal, neither of which actually use qemu-minimal it because tests are disabled. It is possible the removal of "qemu" was sufficient when using labels but the switch away from labels may have left grub-efi and grub-minimal with a fairly large dependency chain due to qemu-minimal, despite not really using it. I did not test all reverse dependents yet, but both grub-efi and grub-minimal still build. Dropping qemu-minimal from native-inputs really helps on architectures with poor substitute availability, such as aarch64! Since Efraim and Ludo were both authors of the relevent commits fixing and/or (re)introducing this issue, I reach out for your wisdom, or at least your thoughts! Efraim also happens to be on the embedded team, which technically covers gnu/packages/bootloaders.scm, although grub being an embedded thing seems a bit of a stretch, given it is a commonly used bootloader on a largely dominant mostly not embedded platform. I guess it is kind of an embedded project unto itself? sort of? hrmpf. live well, vagrant From c71df9ccf0ab9713a1fd9fd7070ed151c7588120 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Thu, 23 Jan 2025 00:56:40 -0800 Subject: [PATCH] gnu: grub-minimal, grub-efi: Reduce unused native-inputs. "qemu" was removed in e9c1ea84fcf4a7f3da9aea9fbfe6136c75643c07 in the code though the commit message claims to have removed "qemu-minimal". If that worked, it may have been broken by switching away from labels in b9c38f26f120e3e12b3bfbf29c6248a08fe1a62c. * gnu/packages/bootloaders.scm (grub-minimal)[native-inputs]: Remove qemu-minimal. (grub-efi)[native-inputs]: Remove qemu-minimal. --- gnu/packages/bootloaders.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index b5cfacca4b..4dab7bd0b7 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -323,7 +323,7 @@ (define-public grub-minimal (delete "lvm2" "mdadm" "fuse" "console-setup"))) (native-inputs (modify-inputs (package-native-inputs grub) - (delete "help2man" "texinfo" "parted" "qemu" "xorriso"))) + (delete "help2man" "texinfo" "parted" "qemu" "qemu-minimal" "xorriso"))) (arguments (substitute-keyword-arguments (package-arguments grub) ((#:tests? _ #t) #f) @@ -413,7 +413,7 @@ (define-public grub-efi (native-inputs ;; The tests are skipped in this package so we remove some test dependencies. (modify-inputs (package-native-inputs grub) - (delete "parted" "qemu" "xorriso"))) + (delete "parted" "qemu" "qemu-minimal" "xorriso"))) (arguments ;; TODO: Tests need a UEFI firmware for qemu. There is one at ;; https://github.com/tianocore/edk2/tree/master/OvmfPkg . base-commit: cc678d0e4d67073943e75053c5e450c4df700b42 -- 2.39.5