From patchwork Fri Nov 18 23:54:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergiu Ivanov X-Patchwork-Id: 44609 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 913EF27BBED; Fri, 18 Nov 2022 23:56:21 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6656027BBE9 for ; Fri, 18 Nov 2022 23:56:20 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owBDI-0007jh-GW; Fri, 18 Nov 2022 18:56:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owBDG-0007jY-RJ for guix-patches@gnu.org; Fri, 18 Nov 2022 18:56:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owBDG-0000Zv-Il for guix-patches@gnu.org; Fri, 18 Nov 2022 18:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owBDG-0003co-E1 for guix-patches@gnu.org; Fri, 18 Nov 2022 18:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 59352@debbugs.gnu.org Received: via spool by 59352-submit@debbugs.gnu.org id=B59352.166881575113918 (code B ref 59352); Fri, 18 Nov 2022 23:56:02 +0000 Received: (at 59352) by debbugs.gnu.org; 18 Nov 2022 23:55:51 +0000 Received: from localhost ([127.0.0.1]:38496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owBD5-0003cP-BL for submit@debbugs.gnu.org; Fri, 18 Nov 2022 18:55:51 -0500 Received: from marvid.fr ([163.172.81.107]:37164 helo=courriel.marvid.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owBD0-0003c8-QH for 59352@debbugs.gnu.org; Fri, 18 Nov 2022 18:55:50 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id 1BE1A79BF95B; Sat, 19 Nov 2022 00:55:40 +0100 (CET) References: <87v8ncbp09.fsf@colimite.fr> <87mt8oot15.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.8.11; emacs 28.2 From: Sergiu Ivanov Date: Sat, 19 Nov 2022 00:54:50 +0100 In-reply-to: <87mt8oot15.fsf@nicolasgoaziou.fr> Message-ID: <874juvg6mc.fsf@colimite.fr> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello Nicolas, Thank you for your review! I was starting to apply your suggestions and … I found that emacs-org-tree-slide was already packaged! I swear I checked before sending in the patch, but apparently I didn't check well enough :D :'( So, I decided to update the existing definition and improve it according to your suggestions. I attach the new patch. Nicolas Goaziou [2022-11-18T22:24:22+0100]: > Hello, > > Sergiu Ivanov writes: > >> Here's a patch adding emacs-org-tree-slide. > > Thank you. > >> It's my second Guix package ever, and I actually enjoyed following the >> instructions from the manual for building, linting and styling it. Tell >> me if I got it right :D > > Almost ;) Some comments follow. :D :'( >> Subject: [PATCH] gnu: Add emacs-org-tree-slide. >> >> --- >> gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ > > > Your commit message is missing a part about the module being modified: > > * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): New variable. A-ha! I looked at other commit messages, but forgot to not only look at their first lines. >> +(define-public emacs-org-tree-slide >> + (package >> + (name "emacs-org-tree-slide") >> + (version "20221016.1623") > > Latest version is 2.8.18, the version above is a fancy date tag from > MELPA unstable. > >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://melpa.org/packages/org-tree-slide-" >> + version ".el")) > > We don't use MELPA as upstream because it doesn't guarantee the tarball > will always be available. Use GitHub as upstream instead. Oh, good to know! >> + (synopsis "Emacs minor mode for giving presentations with Org-mode") > > Nitpick: Org-mode -> Org mode. I fixed this in the other package definition which I found. >> + (description >> + "This package provides the Org minor mode @code{org-tree-slide} which >> +allows for using an Org-mode document in presentations by >> +progressively revealing individual subtrees of the document. >> +org-tree-slide shows and hides parts of the Org buffer by narrowing.") > > I suggest: > > Org Tree Slide is a minor mode for using an Org document in > presentations by progressively revealing individual subtrees of the > document. I replaced the original text with yours, which I like more. >> + (license license:gpl3))) > > License is actually gpl3+ because the license in the org-tree-slide.el > file mention "or (at your option), any later version". Oh, OK, I'll read better next time. > Could you send an updated patch? > > Well done BTW! Thank you for your time! It was a nice and pleasant training. - Sergiu From 97e1307f0a8966149ecf29264ad205e55d29b502 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Sat, 19 Nov 2022 00:46:04 +0100 Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18. * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18. --- gnu/packages/emacs-xyz.scm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index fe0d9f1dc9..f827107b29 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode (license license:gpl3+)))) (define-public emacs-org-tree-slide - (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5") - (revision "2")) + (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f") + (revision "3")) (package (name "emacs-org-tree-slide") - (version (git-version "2.8.4" revision commit)) + (version (git-version "2.8.18" revision commit)) (source (origin (method git-fetch) (uri (git-reference @@ -18656,15 +18656,15 @@ (define-public emacs-org-tree-slide (commit commit))) (sha256 (base32 - "1r8ncx25xmxicgciyv5przp68y8qgy40fm10ba55awvql4xcm0yk")) + "1br32mpwarmrn158y2pkkmfl2ssv8q8spzknkg2avr16fil0j1pz")) (file-name (git-file-name name version)))) (build-system emacs-build-system) (home-page "https://github.com/takaxp/org-tree-slide") - (synopsis "Presentation tool for org-mode") + (synopsis "Presentation tool for Org mode") (description - "Org-tree-slide provides a slideshow mode to view org-mode files. Use -@code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and -@kbd{C-<} to jump to the next and previous slide.") + "Org Tree Slide is a minor mode for using an Org document in +presentations by progressively revealing individual subtrees of +the document.") (license license:gpl3+)))) (define-public emacs-scratch-el -- 2.38.1