From patchwork Mon Nov 14 16:23:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandr Vityazev X-Patchwork-Id: 44512 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id ED67127BBEA; Mon, 14 Nov 2022 23:36:33 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8731127BBE9 for ; Mon, 14 Nov 2022 23:36:33 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouilA-0005hL-Cu; Mon, 14 Nov 2022 18:21:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouifX-0006GP-5R for guix-patches@gnu.org; Mon, 14 Nov 2022 18:15:17 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouifW-0000bh-Nt for guix-patches@gnu.org; Mon, 14 Nov 2022 18:15:10 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouifW-0000A3-IO for guix-patches@gnu.org; Mon, 14 Nov 2022 18:15:10 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59097] v2[PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode. Resent-From: Aleksandr Vityazev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Nov 2022 23:15:10 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59097 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 59097@debbugs.gnu.org X-Debbugs-Original-Cc: 59097@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1668467708556 (code B ref -1); Mon, 14 Nov 2022 23:15:10 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2022 23:15:08 +0000 Received: from localhost ([127.0.0.1]:51395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouifT-00008d-JW for submit@debbugs.gnu.org; Mon, 14 Nov 2022 18:15:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:35374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouif3-0008T6-LM for submit@debbugs.gnu.org; Mon, 14 Nov 2022 18:14:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouiew-0001X6-Kf for guix-patches@gnu.org; Mon, 14 Nov 2022 18:14:36 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oucFf-00050I-Q6 for guix-patches@gnu.org; Mon, 14 Nov 2022 11:24:05 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7499E240027 for ; Mon, 14 Nov 2022 17:24:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1668443040; bh=9IjvkTQvxj84aQ1rDMJ4H44b3DJ+649fJA1X4stlKvI=; h=From:To:Cc:Subject:Date:From; b=gK5f8icji3+VyAdsmF8qOHGzxg2FrBjPhf+/xtcA7wOU3ZkeWpbPmYZygLiXg1VN/ b7f+HdHTH9dtj7zT1tj60DSsoJYafzQAsAW9BGT/iqB5GFo9xAIQoqcqhENjJyCP5Q YyyNNJl1+GhZaHEmww/8kL2e+bGnqZXML7Kk0Dx+OywWYOxcrd1Wg5LA1WjM+JnAxI qs9t6B7cjnVcMXiTJ3K5CJIcUdSzmmxYbFQMT8vQ2By4lyTJFeMdt7ENnPe0k+tTQZ B35SgeodPKXCP/1+n2fbb+y8890oaNdBSexeTlGumVZXs5rGfYTBWjLVJDegBXWqwG CfItmPaOOYMaA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9vkt4fFkz6tql; Mon, 14 Nov 2022 17:23:50 +0100 (CET) From: Aleksandr Vityazev In-Reply-To: <878rkmpmu5.fsf@cbaines.net> (Christopher Baines's message of "Mon, 07 Nov 2022 20:45:42 +0100") References: <878rkmpmu5.fsf@cbaines.net> Date: Mon, 14 Nov 2022 16:23:49 +0000 Message-ID: <874jv1qzca.fsf_-_@posteo.org> MIME-Version: 1.0 Received-SPF: pass client-ip=185.67.36.65; envelope-from=avityazev@posteo.org; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi, On 2022-11-07, 20:45 +0100, Christopher Baines wrote: > While writing the changelog in the commit is good (so thanks for that), > it's still often important to put something in the commit about why the > change is being made. fixed in patch v2 (in attachment). > That includes this case, I'm left wondering why this propagated-input is > being removed? > > Note that I'm not asking for some detailed and airtight argument for > making the change, I just want to why you think this is good to do, even > if that's just "it doesn't seem to be needed". I don't know exactly what to do in this situation, since emacs-skempo no longer has any packages on which it depends, I thought it logical to remove the propagated-inputs field. Is there any reason why this should not be done? From d0a4ad13cf6a2c55690626fbef4da42dbf0d0614 Mon Sep 17 00:00:00 2001 Message-Id: From: Aleksandr Vityazev Date: Mon, 7 Nov 2022 10:51:22 +0300 Subject: [PATCH] gnu: emacs-skempo: Remove dependency on emacs-parent-mode. * gnu/packages/emacs-xyz.scm (emacs-skempo)[propagated-inputs]: Remove dependency on emacs-parent-mode. As of a936f8d9fa0d42f17c64da9d2652a5f3e7c6546a commit skempo drop dependency for parent-mode. --- gnu/packages/emacs-xyz.scm | 2 -- 1 file changed, 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 4bbebd3cd6..27039609fd 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -4772,8 +4772,6 @@ (define-public emacs-skempo (base32 "0xsr6819qaad0y8rhfrf555c9w7cmgbgkf1a2svgbp7rhhnywl0a")))) (build-system emacs-build-system) - (propagated-inputs - (list emacs-parent-mode)) (home-page "https://github.com/xFA25E/skempo") (synopsis "Enhancements for skeleton/tempo + abbrev") (description -- 2.38.1