From patchwork Sat Nov 12 18:53:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: EuAndreh X-Patchwork-Id: 44477 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E76C727BBEA; Sat, 12 Nov 2022 19:09:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id CB20827BBE9 for ; Sat, 12 Nov 2022 19:09:11 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otvsH-0004DG-CZ; Sat, 12 Nov 2022 14:09:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otvsF-0004Ct-LH for guix-patches@gnu.org; Sat, 12 Nov 2022 14:09:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otvsF-0002Gb-47 for guix-patches@gnu.org; Sat, 12 Nov 2022 14:09:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otvsE-0006fz-E4 for guix-patches@gnu.org; Sat, 12 Nov 2022 14:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group Resent-From: EuAndreh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Nov 2022 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59223 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59223@debbugs.gnu.org Cc: EuAndreh X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166828010425617 (code B ref -1); Sat, 12 Nov 2022 19:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 19:08:24 +0000 Received: from localhost ([127.0.0.1]:49045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otvrc-0006f7-E9 for submit@debbugs.gnu.org; Sat, 12 Nov 2022 14:08:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:37434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otvra-0006ez-MN for submit@debbugs.gnu.org; Sat, 12 Nov 2022 14:08:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otvra-00049g-F7 for guix-patches@gnu.org; Sat, 12 Nov 2022 14:08:22 -0500 Received: from box.euandre.org ([46.101.160.115]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otvrU-0002DJ-GM for guix-patches@gnu.org; Sat, 12 Nov 2022 14:08:22 -0500 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 9DEB8FC406; Sat, 12 Nov 2022 16:08:08 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1668280089; bh=qCvfCVYwQcIjkUWr2XCIwzzGHOLD+Jn+7hYspv0EkAQ=; h=From:To:Cc:Subject:Date:From; b=kkG+BtjROOOQD0yoBCL37j6a2e2CAXuPfLqgNh1kuPkP1lOcqX9qu/N6D1skazQK4 xrs6lwMcsXUm8oR6jkRjfCYJxHwpdjVF33YrVilZu8nea6Q/mY239IH5KN0/c75wDy PXZ39cw3hvLwPMdVVgp8/NdOzVgA+maK1XyVeOTQjB/6R8Sq4fzNkFPj6v1/cbiYi3 J/928ozN2UQfj72gM5O2QMBPa1S3D1SLZvMbHHQejjnemZtXujiqSV+/1HDPo8+tSr 7kpVSKVrP5lnpE6+g+hdSb6pU8KcygvLoAhMFVkyF56Mmr6Zx/d4F+3ZOK95F9yPzq M89DxRtDuN9hA== Date: Sat, 12 Nov 2022 15:53:21 -0300 Message-Id: <20221112185321.17566-1-eu@euandre.org> MIME-Version: 1.0 Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: EuAndreh X-ACL-Warn: , EuAndreh via Guix-patches X-Patchwork-Original-From: EuAndreh via Guix-patches via From: EuAndreh Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches The default value for has "git" for both the values of the user and the group, as costumary, which means that unless someone uses a custom configuration and chooses different strings for user and group, this wouldn't show up. * gnu/services/version-control.scm (gitolite-accounts): Use the correct variable for the name of a (user-group ...). --- I did a "git grep user-group gnu/services/" and looked at the returned entries. After a quick cursory look, either all the entries had a hard-coded string value, or picked the correct variable for the group name. So I think this one is a one-off :) This surfaced after a debugging session with mirai on IRC earlier today. gnu/services/version-control.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm index b6b78e504e..86d40bdbe3 100644 --- a/gnu/services/version-control.scm +++ b/gnu/services/version-control.scm @@ -313,7 +313,7 @@ (define gitolite-accounts (($ package user group home-directory rc-file admin-pubkey) ;; User group and account to run Gitolite. - (list (user-group (name user) (system? #t)) + (list (user-group (name group) (system? #t)) (user-account (name user) (group group)