From patchwork Mon Jun 13 04:29:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Artyom V. Poptsov" X-Patchwork-Id: 2957 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0DF8727BBEA; Mon, 13 Jun 2022 05:31:18 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 414ED27BBE9 for ; Mon, 13 Jun 2022 05:31:17 +0100 (BST) Received: from localhost ([::1]:41224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0bjQ-0008Lj-Dj for patchwork@mira.cbaines.net; Mon, 13 Jun 2022 00:31:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0bjD-0008Ky-29 for guix-patches@gnu.org; Mon, 13 Jun 2022 00:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0bjC-0008PS-Cb for guix-patches@gnu.org; Mon, 13 Jun 2022 00:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0bjC-00040X-8o for guix-patches@gnu.org; Mon, 13 Jun 2022 00:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55929] [PATCH] gnu: maven: Add maven-doxia-sink-api Resent-From: "Artyom V. Poptsov" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Jun 2022 04:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55929 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 55929@debbugs.gnu.org Received: via spool by 55929-submit@debbugs.gnu.org id=B55929.165509460315254 (code B ref 55929); Mon, 13 Jun 2022 04:31:02 +0000 Received: (at 55929) by debbugs.gnu.org; 13 Jun 2022 04:30:03 +0000 Received: from localhost ([127.0.0.1]:56873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0biA-0003x4-RC for submit@debbugs.gnu.org; Mon, 13 Jun 2022 00:30:03 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:35608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0bi6-0003wp-Mi for 55929@debbugs.gnu.org; Mon, 13 Jun 2022 00:29:57 -0400 Received: by mail-lf1-f48.google.com with SMTP id a29so6992937lfk.2 for <55929@debbugs.gnu.org>; Sun, 12 Jun 2022 21:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xI+M/1OJkYsZEzbXqQLYPF17Xy3rPaG0IPmmjKOvglk=; b=Y28C7PUBawXckgjjdFPxsNVz2ZTBmJ5tiGV1sPNZWYYNFskksryduLUV1sei7Ub6k9 IqHQldaAUfh3CrrMeN+OFgLlhXWBzAir/davsYZN7baCQMyuAkmY+urggYvpHcVqYNJQ 97CaTnTdjSkP3MeiQob1LXyxIr1YbyHXNK6QxXUdVv8dbijkytp8nCOZw3Bejq6gtktZ gWzFSfKzgqFihfdaaxNyOpSTdz6XgDspY5h9cqIkXIKJOwln2h4h23ZuOox/Hf97us5D JN4qqXnDwCq2D6w7YXjrmx2yYy0bbNlhJ/moP4688uVBEojWgtmGzd8krm+6YmWPwFRU 6aBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xI+M/1OJkYsZEzbXqQLYPF17Xy3rPaG0IPmmjKOvglk=; b=gaO+d+GJwlWlSu/okGF1VUjhG51eLIQPLF5y04/7+bVTBH8K21uVXfR/jpgKz5Mtii peiwOLJrmeQbGP/MDo4iCkIA1o2EvFWKEUN9n2M3MtRi8pKwIjB300Pt1ozyOfM4IxqY QH/wP3OZ4zqqwurJeRy108O2Duar96ZhxJclcByfPIiPuKG7prjgZc2pw+ZuVnrYw1k7 kJyhmiwCGsprDQ0IzAwYoPs3cHOBouU7jcCYVSd+rGsRvxBzUUJ065fN864P4/h4tAmL IFBMJKF8WzZ0tVj84VIQYwcilI160Xqmf/7WzCSaHNEepLLMx3WiEDUkF/CuJadprgYp 80Ww== X-Gm-Message-State: AOAM533uE7da/NRfDJWvT3807mV1ue6UrewpRAEJ5ABpcNEsDbqIkvia LIcFE3O+5Yb2sAVODVMIvniylXeq324= X-Google-Smtp-Source: ABdhPJy9jDOd3ZCayQawHW46PAf/9Dy+DT7H7ncaTb7sPifRmxcXGMjUdGRPAu+dJa+Mf56PE3fGfQ== X-Received: by 2002:a05:6512:3b8d:b0:478:f9f3:962b with SMTP id g13-20020a0565123b8d00b00478f9f3962bmr35680878lfv.169.1655094588203; Sun, 12 Jun 2022 21:29:48 -0700 (PDT) Received: from elephant ([5.164.222.47]) by smtp.gmail.com with ESMTPSA id g1-20020a056512118100b0047ac01fc644sm831786lfr.44.2022.06.12.21.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jun 2022 21:29:47 -0700 (PDT) From: "Artyom V. Poptsov" References: <87h74pyc1s.fsf@gmail.com> <87czfdyb3j.fsf@gmail.com> <20220612230317.547a056f@sybil.lepiller.eu> Date: Mon, 13 Jun 2022 07:29:43 +0300 In-Reply-To: <20220612230317.547a056f@sybil.lepiller.eu> (Julien Lepiller's message of "Sun, 12 Jun 2022 23:03:22 +0200") Message-ID: <874k0pxk20.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Julien, first of all, thanks for reviewing my patches! I fixed my patch, at least the part I understood -- see below. > Great to see someone trying to package more maven-related stuff! I > think I've seen it in the dependency graph to the maven-plugin-plugin, > which I'd like to package at some point to make our life easier. Indeed, I started my work on packaging Doxia because I wanted to package 'maven-plugin-plugin' which in turn is required for 'maven-release-plugin'[1]. And 'maven-release-plugin' is required for 'java-json-simple'[2] ... So the dependency order looks like this: 0. 'ugs' (Universal G-Code sender) [3] 1. 'java-jts' 2. 'java-json-simple' 3. 'maven-release-plugin' 4. 'maven-plugin-plugin' <-- I'm here. ;-) Also, while we on it, I have the following questions: 0. How did you check the dependency graph for 'maven-plugin-plugin' without packaging it? 1. Is it possible with Guix to generate the reverse dependency graph to see that packages depend on the specified package? > Here the subject should omit "maven", so simply: Done. > Is this intentional? Shouldn't it be doxia-sink-api.jar? That was a mistake indeed. Fixed it. > Also I'm wondering, since this will be used by maven eventually, > shouldn't we install it to lib/m2 with its pom file? To do so, we would > change the install phase to something like this: > (replace 'install (install-from-pom "doxia-sink-api/pom.xml")) Done. > This might require a parent-pom (probably the top-level pom.xml and > maybe its own parent pom), so you'll have to provide a patch for it > as well. You can have a look at (gnu packages maven-parent) for > examples. This part I don't understand. Could you elaborate? > The description doesn't follow all our conventions, in particular, > double space between sentences :) Fixed. - Artyom References: 1. https://maven.apache.org/maven-release/maven-release-plugin/ 2. https://github.com/fangyidong/json-simple 3. https://github.com/winder/Universal-G-Code-Sender --- Artyom "avp" Poptsov Home page: https://memory-heap.org/~avp/ CADR Hackerspace co-founder: https://cadrspace.ru/ GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F From b4020bc283f18d7b7394976c4288d04130f1e651 Mon Sep 17 00:00:00 2001 From: "Artyom V. Poptsov" Date: Sun, 12 Jun 2022 21:42:33 +0300 Subject: [PATCH] gnu: maven: Add maven-doxia-sink-api * gnu/packages/maven.scm (maven-doxia-sink-api): New variable. --- gnu/packages/maven.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm index 817fee1c71..93c1538bae 100644 --- a/gnu/packages/maven.scm +++ b/gnu/packages/maven.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2019 Tobias Geerinckx-Rice ;;; Copyright © 2019 Björn Höfling ;;; Copyright © 2020 Efraim Flashner +;;; Copyright © 2022 Artyom V. Poptsov ;;; ;;; This file is part of GNU Guix. ;;; @@ -3887,3 +3888,31 @@ reports in two different file formats, plain text and xml."))) (description "This plugin provides the capability to build jars. If you would like to sign jars please use the Maven Jarsigner Plugin instead.") (license license:asl2.0))) + +(define-public maven-doxia-sink-api + (package + (name "maven-doxia-sink-api") + (version "2.0.0-M2") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://gitbox.apache.org/repos/asf/maven-doxia.git") + (commit (string-append "doxia-" version)))) + (file-name (git-file-name "doxia" version)) + (sha256 + (base32 + "0jx96lg0hgjsrm8mynhac4hwh2hmgiwjpwpx2k03yr14040zcr48")))) + (build-system ant-build-system) + (native-inputs + (list java-javax-inject)) + (arguments + (list #:jar-name "doxia-core.jar" + #:source-dir "doxia-sink-api/src/main/java" + #:tests? #f)) ; no tests + (home-page "https://maven.apache.org/doxia/index.html") + (synopsis "Generic markup language interface") + (description "The @code{Sink} interface is a generic markup language +interface provided as a Java API. It contains several methods that encapsulate +common text syntax. A start tag is denoted by @code{xxxx()} method and a end +of tag by @code{xxxx_()} method.") + (license license:asl2.0))) -- 2.25.1