From patchwork Mon Oct 17 21:33:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: EuAndreh X-Patchwork-Id: 43490 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C375727BBEA; Mon, 17 Oct 2022 22:34:22 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4C94F27BBE9 for ; Mon, 17 Oct 2022 22:34:22 +0100 (BST) Received: from localhost ([::1]:58284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okXkb-0002Mt-Em for patchwork@mira.cbaines.net; Mon, 17 Oct 2022 17:34:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okXkI-0002Jg-AG for guix-patches@gnu.org; Mon, 17 Oct 2022 17:34:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51232) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okXkI-0005lW-2D for guix-patches@gnu.org; Mon, 17 Oct 2022 17:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okXkH-0001Gm-TV for guix-patches@gnu.org; Mon, 17 Oct 2022 17:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58595] [PATCH 2/2] services: nginx: Improve reload action documentation. Resent-From: EuAndreh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Oct 2022 21:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58595 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58595@debbugs.gnu.org Cc: EuAndreh X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16660424324863 (code B ref -1); Mon, 17 Oct 2022 21:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Oct 2022 21:33:52 +0000 Received: from localhost ([127.0.0.1]:50310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okXk8-0001GN-0O for submit@debbugs.gnu.org; Mon, 17 Oct 2022 17:33:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:56576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okXk6-0001GG-Tm for submit@debbugs.gnu.org; Mon, 17 Oct 2022 17:33:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okXjr-0002HR-DZ for guix-patches@gnu.org; Mon, 17 Oct 2022 17:33:47 -0400 Received: from box.euandre.org ([46.101.160.115]:34037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okXjp-0005iG-O9 for guix-patches@gnu.org; Mon, 17 Oct 2022 17:33:35 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 36176FC4B2; Mon, 17 Oct 2022 18:33:29 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1666042411; bh=e4+322WglTfOegGau1vXZi3nhd49MVxvFewJhpcBIpw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aPlB9UKmgJJdTtX+DehyEMTqx5aMO7rycS6ZQb5Newb/u+Zqv9x2EhyZa+6UO7LAH NFQfJraeMa9schThmUdEZHq0w+cFU6wkSc8RUm3CAuxOkt2ZnoZTifKR+1a224UQHt CR3s5pZh8rqshusqut3rEyq2eRa4kBNRFr91p3Xce55+DrPt3XewDb16jtR9UZi3jI mTFZpjrGEiBf3Qt65fBjYJ2s9CPsXMiNCZf96Z8tz5AtNFp1XjX/4ejyAzf8V0FRrR ySJYWoe1hdfGoDP0PeevyJ3VkFh7lSb2UH3HCEj+cJvy9M7yMi1ro5vlmQpU7ehFP1 LifJPb8FnT4Wg== Date: Mon, 17 Oct 2022 18:33:25 -0300 Message-Id: <20221017213325.29154-1-eu@euandre.org> In-Reply-To: <58590@debbugs.gnu.org> References: <58590@debbugs.gnu.org> MIME-Version: 1.0 Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: EuAndreh X-ACL-Warn: , EuAndreh via Guix-patches X-Patchwork-Original-From: EuAndreh via Guix-patches via From: EuAndreh X-getmail-retrieved-from-mailbox: Patches * gnu/services/web.scm (nginx-shepherd-service): Be explicit about the reload action not changing the configuration file, but instead respawning worker processes. --- Correct placement of the second patch. I'll close the other bugs opened when I replied to my own email, instead of debbugs' email. gnu/services/web.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 7fde8824b3..2023119037 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -819,7 +819,11 @@ (define (nginx-shepherd-service config) (list (shepherd-action (name 'reload) - (documentation "Reload NGINX configuration file and restart worker processes.") + (documentation "Reload nginx configuration file and restart worker processes. +This has the effect of killing old worker processes and starting new ones, using +the same configuration file. It is useful for situations where the same nginx +configuration file can point to different things after a reload, such as +renewed TLS certificates, or @code{include}d files.") (procedure (nginx-action "-s" "reload")))))))))) (define nginx-service-type