From patchwork Mon Oct 17 18:03:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 43469 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 75D6027BBEA; Mon, 17 Oct 2022 19:04:50 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id F250127BBE9 for ; Mon, 17 Oct 2022 19:04:49 +0100 (BST) Received: from localhost ([::1]:58446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okUTp-0005qH-3b for patchwork@mira.cbaines.net; Mon, 17 Oct 2022 14:04:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okUT4-0005oS-T6 for guix-patches@gnu.org; Mon, 17 Oct 2022 14:04:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okUT4-0007mh-Eo for guix-patches@gnu.org; Mon, 17 Oct 2022 14:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okUT3-0001mY-Sx for guix-patches@gnu.org; Mon, 17 Oct 2022 14:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58035] sync-before-registering is false, possibly the cause of empty files in the store Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Oct 2022 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58035 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?utf-8?q?Court=C3=A8s?= , Maxime Devos Cc: 58035@debbugs.gnu.org Received: via spool by 58035-submit@debbugs.gnu.org id=B58035.16660298196817 (code B ref 58035); Mon, 17 Oct 2022 18:04:01 +0000 Received: (at 58035) by debbugs.gnu.org; 17 Oct 2022 18:03:39 +0000 Received: from localhost ([127.0.0.1]:49915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okUSh-0001lt-7s for submit@debbugs.gnu.org; Mon, 17 Oct 2022 14:03:39 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:40473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okUSf-0001lg-Oj for 58035@debbugs.gnu.org; Mon, 17 Oct 2022 14:03:38 -0400 Received: by mail-wr1-f42.google.com with SMTP id w18so19646809wro.7 for <58035@debbugs.gnu.org>; Mon, 17 Oct 2022 11:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=TSkj5AnC0mWICb+rYpg8w1HXXGMOrD/k+5YNfEM8Y4g=; b=GVpP8V2CxpT7Bit4BSe87RSyqXYiMOFTb9W06+OtCnoL5IA0kRuGTykhyIZTCzWKe2 7q6lrnFVXc4KuEam3UElNiAnitIlyURU0gVE/Lq7ta41QCphIkIqSk/bBksTfr2Kp9yY 2fSyLeiCYeiyfJeldFZnrvkKMXGQPWJkKa/FjVZJBuFGZSDtnMiN8t3eAI1U3jamq+a9 bnt6jSIc/YqCGiC1ASCJmDokjGtjMFODQDLQeqWtT3g66CADEv+nbm0w8zcyQ0fLT2zw Kzi5roTKPRk1PxP1cksrsKfbmZBhGQIkJCf25aYozySrai76ABvxG3E5U5NnlZnL+44E tDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TSkj5AnC0mWICb+rYpg8w1HXXGMOrD/k+5YNfEM8Y4g=; b=c8Wvpw4MKHB05NEq516IDYxO253qNbxwjGZBIPbuFPBvzPDboszoeGfypFAFCz9IZH jwxTCgrm4V69A8B3/r11vPbORne2+YejZBBa5W0PrRNEQuiUXnBc0FdYQMPvREnosY+Q MVwU/YXhY9lW9o14w7wi3VUvtjsL4PoO//2mOkj6LQUn0vSwdAcBTg/4OVyEObkZrx9G XLvLoLnd3VqaVcCS0uoPcHdBGQi5t2aHjb2XVEnkpRscaoFu94hmg0sI92ariBGVe/u1 KIh7JtYHwVSDZvHj/81XsVPgBcQIxeBGAIP3ps41+okPkRH2nSPpW0lDxO6cxfsJFAw4 JSTQ== X-Gm-Message-State: ACrzQf2PZ+6v0YatVGimLa+bgK/dDBUQq9UMalkgB2ZNNiZFZH0ts6wh uW4aKWuwIan7uaG8G53opGH9nXY4UXE= X-Google-Smtp-Source: AMsMyM6LzGd3AFF/CKbUvc78kM04/yI4Qq4JYUqeCRkHvyqiphiPt2mqA9fTD8DgyeM2pTlwwpRxnQ== X-Received: by 2002:a5d:59a3:0:b0:22e:4b62:7ceb with SMTP id p3-20020a5d59a3000000b0022e4b627cebmr7207060wrr.90.1666029811533; Mon, 17 Oct 2022 11:03:31 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id bi20-20020a05600c3d9400b003b49ab8ff53sm10756923wmb.8.2022.10.17.11.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:03:30 -0700 (PDT) From: zimoun In-Reply-To: <87zgebs1h5.fsf@gnu.org> References: <0530a80e-0a93-5a3a-ef98-5ba3683e810d@telenet.be> <874jwkvxdt.fsf@gnu.org> <6bd60f0b-ffac-dcc8-5225-df4b765522c5@telenet.be> <87zgebs1h5.fsf@gnu.org> Date: Mon, 17 Oct 2022 20:03:28 +0200 Message-ID: <878rlel43z.fsf@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, 3x time slower with my hardware. Closing? On mar., 04 oct. 2022 at 23:49, Ludovic Courtès wrote: > Maybe a good test would be to run a daemon on an “average” HDD with > sync-before-registering = true and to run ‘perf timechart record’ while > it’s fetching a large number of substitutes. That way we’d have > concrete data to talk about. + Comparison using the manifest below. + guix-daemon built using fd4cbcbed7; two flavors. + Guix revision f43a783. + Before the experiment, complete ’guix gc’. # test-58035/guix-daemon --build-users-group=guixbuild # perf timechart record $ time guix build -m some-packages.scm # perf timechart --highlight guix 1/ sync-before-registering = false real 6m24.215s user 0m10.627s sys 0m0.512s [ perf record: Woken up 1984 times to write data ] [ perf record: Captured and wrote 497.403 MB perf.data (5042727 samples)] 2/ sync-before-registering = true real 19m46.470s user 0m12.367s sys 0m0.557s [ perf record: Woken up 2625 times to write data ] [ perf record: Captured and wrote 658.066 MB perf.data (6712342 samples) ] Well, the charts are really big. $ du -sh {1,2}-build-*.svg 331M 1-build-false.svg 599M 2-build-true.svg Therefore, please find them using this link (alive for 15 days): https://filesender.renater.fr/?s=download&token=0e861286-ec0c-4815-bb49-2bce91b14462 Cheers, simon --8<---------------cut here---------------start------------->8--- (use-modules (guix build-system haskell) (guix build-system julia) (guix packages) (guix profiles) (gnu packages)) (manifest (map package->manifest-entry (fold-packages (lambda (package result) (if (or ;;(eq? (package-build-system package) haskell-build-system) (eq? (package-build-system package) julia-build-system)) (cons package result) result)) '()))) --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- --8<---------------cut here---------------end--------------->8--- diff --git a/nix/libstore/globals.cc b/nix/libstore/globals.cc index d4f9a46a74..5f8a3a3031 100644 --- a/nix/libstore/globals.cc +++ b/nix/libstore/globals.cc @@ -40,7 +40,7 @@ Settings::Settings() reservedSize = 8 * 1024 * 1024; fsyncMetadata = true; useSQLiteWAL = true; - syncBeforeRegistering = false; + syncBeforeRegistering = true; useSubstitutes = true; useChroot = false; impersonateLinux26 = false;