From patchwork Sun Oct 16 17:34:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "ashish.is--- via Guix-patches\" via" X-Patchwork-Id: 43448 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C835327BBE9; Sun, 16 Oct 2022 18:35:17 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2D79E27BBEA for ; Sun, 16 Oct 2022 18:35:14 +0100 (BST) Received: from localhost ([::1]:46940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ok7Xd-00052k-Aj for patchwork@mira.cbaines.net; Sun, 16 Oct 2022 13:35:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok7XS-00052b-Nl for guix-patches@gnu.org; Sun, 16 Oct 2022 13:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ok7XS-0003p9-Fh for guix-patches@gnu.org; Sun, 16 Oct 2022 13:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ok7XS-0004qZ-1X for guix-patches@gnu.org; Sun, 16 Oct 2022 13:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58569] [PATCH] gnu packages gnome-console: Remove nautilus extension Resent-From: =?utf-8?b?TcOhamEgVG9tw6HFoWVr?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Oct 2022 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58569 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58569@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166594167618588 (code B ref -1); Sun, 16 Oct 2022 17:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Oct 2022 17:34:36 +0000 Received: from localhost ([127.0.0.1]:46068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok7X1-0004pk-Oi for submit@debbugs.gnu.org; Sun, 16 Oct 2022 13:34:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:36680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok7X0-0004pc-1D for submit@debbugs.gnu.org; Sun, 16 Oct 2022 13:34:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok7Wz-0004zc-RF for guix-patches@gnu.org; Sun, 16 Oct 2022 13:34:33 -0400 Received: from knopi.disroot.org ([178.21.23.139]:36674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok7Wx-0003m6-KR for guix-patches@gnu.org; Sun, 16 Oct 2022 13:34:33 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 410614DC06 for ; Sun, 16 Oct 2022 19:34:26 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5kgBtzYXdGFY for ; Sun, 16 Oct 2022 19:34:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665941664; bh=czKhZO7+zJsi2AD4vLh/zAUxNS6vRenSQxFcQtj6Y1U=; h=From:To:Subject:Date; b=XIqM/zW3cRS2n5xtXdUzQeSWf7+dcUAEuy+wxafnLjTb1uF7PlEVB27oWD/c/lu+V V8NQPKjWg8M+NX2MNra4qIvSJpr3OSYMn/WjmtqM6/BVek/hZXUyS5qI8uMwzd8Ims tLKIO1r4KE/fAPwSa69xGUrxOR9A8Qac010TIby5gClck8hSHrNBjBamX9Dn9lnBS6 U5zxh2V+0mHFV4sFMzIzdfnoP9Cv9SE8CEGGjUuhU8BnGNrAvtPupkfulSRsRt4Rpj MGCJhZnTIeIdbLO9BHwnc3E9qsvSNxXAkbwCxL2zMH+XufPlPtkYsv7QtHN569REyZ tWZLv7ZzSfEMg== Date: Sun, 16 Oct 2022 19:34:21 +0200 Message-ID: <87sfjnad0i.fsf@disroot.org> Mime-Version: 1.0 Received-SPF: pass client-ip=178.21.23.139; envelope-from=maya.tomasek@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: =?utf-8?b?TcOhamEgVG9tw6HFoWVr?= X-ACL-Warn: , =?utf-8?q?M=C3=A1ja_Tom=C3=A1=C5=A1ek_via_Guix-patches?= X-Patchwork-Original-From: guix-patches--- via From: "ashish.is--- via Guix-patches\" via" X-getmail-retrieved-from-mailbox: Patches Hi, this patch removes the gnome-console nautilus extension as it crashes nautilus (at least on my machine). In my opinion it is safe to remove it, as this feature is implemented directly into nautilus-43 and the original code is purged from the gnome-console repo. (see https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/911 and https://gitlab.gnome.org/GNOME/console/-/commit/c4bd2312f4b432a33810a8dcdf3cadabae5169d7) This sadly means, that in nautilus-42 there will be no "Open in Console", but the issue is on some code that is already deprecated in the Console repo. (I have studied gdb info and it appears that kgx_nautilus_get_background_items() returns a GList* that is { .next = NULL, .prev = NULL, .data = NULL } but nautilus does only perform a check that GList* is NULL, otherwise it expects a valid list) I can maybe supply a patch to gnome-console, but I don't see a reason to. Kind regards, Maya --- gnu/packages/gnome.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index fbaef9eb6e..c71894bcb9 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5445,8 +5445,7 @@ (define-public gnome-console (build-system meson-build-system) (arguments (list #:glib-or-gtk? #t - #:configure-flags #~(list "-Dtests=true" - "-Dnautilus=enabled") + #:configure-flags #~(list "-Dtests=true") #:phases #~(modify-phases %standard-phases (add-after 'unpack 'patch-nautilus-extension-path (lambda _ -- 2.37.3