From patchwork Sat Oct 15 15:39:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "pelzflorian (Florian Pelz)" X-Patchwork-Id: 43429 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5286727BBE9; Sat, 15 Oct 2022 16:40:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id AF46427BBEA for ; Sat, 15 Oct 2022 16:40:22 +0100 (BST) Received: from localhost ([::1]:45350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojjGv-0007Ct-SW for patchwork@mira.cbaines.net; Sat, 15 Oct 2022 11:40:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojjGd-0007Cl-5R for guix-patches@gnu.org; Sat, 15 Oct 2022 11:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojjGc-0006zn-D9 for guix-patches@gnu.org; Sat, 15 Oct 2022 11:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojjGc-0002YS-0s for guix-patches@gnu.org; Sat, 15 Oct 2022 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58549] [PATCH draft] installer: welcome: Warn when uvesafb gets used. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 15 Oct 2022 15:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58549 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58549@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16658483589755 (code B ref -1); Sat, 15 Oct 2022 15:40:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Oct 2022 15:39:18 +0000 Received: from localhost ([127.0.0.1]:42514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojjFt-0002XH-MC for submit@debbugs.gnu.org; Sat, 15 Oct 2022 11:39:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:40896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojjFp-0002X4-KA for submit@debbugs.gnu.org; Sat, 15 Oct 2022 11:39:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojjFp-0007AX-Cu for guix-patches@gnu.org; Sat, 15 Oct 2022 11:39:13 -0400 Received: from relay.yourmailgateway.de ([188.68.63.98]:39937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojjFn-0006wS-AF for guix-patches@gnu.org; Sat, 15 Oct 2022 11:39:13 -0400 Received: from mors-relay-2501.netcup.net (localhost [127.0.0.1]) by mors-relay-2501.netcup.net (Postfix) with ESMTPS id 4MqS9724jvz5xFC for ; Sat, 15 Oct 2022 17:39:07 +0200 (CEST) Authentication-Results: mors-relay-2501.netcup.net; dkim=permerror (bad message/signature format) Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-2501.netcup.net (Postfix) with ESMTPS id 4MqS971b1Sz50mR for ; Sat, 15 Oct 2022 17:39:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4MqS962PBcz8sb7 for ; Sat, 15 Oct 2022 17:39:06 +0200 (CEST) Received: from florianrock64 (ip5b40552a.dynamic.kabel-deutschland.de [91.64.85.42]) by mxe217.netcup.net (Postfix) with ESMTPSA id 2A36F7FDB3 for ; Sat, 15 Oct 2022 17:39:04 +0200 (CEST) From: "pelzflorian (Florian Pelz)" Date: Sat, 15 Oct 2022 17:39:03 +0200 Message-ID: <87h7055c6g.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 X-Rspamd-Queue-Id: 2A36F7FDB3 X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: AD0t+RbXea67gpMlz2CUbm2xa20xzA0iQenFpkz1b9s8aX6PqTf7wdFy Received-SPF: none client-ip=188.68.63.98; envelope-from=pelzflorian@pelzflorian.de; helo=relay.yourmailgateway.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches There will be false positives: Because the Guix installer uses the kernel argument modprobe.blacklist=radeon,amdgpu and some AMD graphics actually work okay according to h-node, these users will get a false alarm. * gnu/installer/newt/welcome.scm (run-welcome-page): Warn before showing the welcome page. --- gnu/installer/newt/welcome.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) base-commit: d923cf1deac0b6762345d0d9e53822cbcb899365 diff --git a/gnu/installer/newt/welcome.scm b/gnu/installer/newt/welcome.scm index 7a7ddfb7bd..762fca96eb 100644 --- a/gnu/installer/newt/welcome.scm +++ b/gnu/installer/newt/welcome.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Mathieu Othacehe ;;; Copyright © 2020 Ludovic Courtès +;;; Copyright © 2022 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -17,6 +18,8 @@ ;;; along with GNU Guix. If not, see . (define-module (gnu installer newt welcome) + #:use-module ((gnu build linux-modules) + #:select (modules-loaded)) #:use-module (gnu installer steps) #:use-module (gnu installer utils) #:use-module (gnu installer newt page) @@ -121,6 +124,14 @@ (define (run-welcome-page logo) "Run a welcome page with the given textual LOGO displayed at the center of the page. Ask the user to choose between manual installation, graphical installation and reboot." + (begin + (when (member "uvesafb" (modules-loaded)) + (run-error-page (G_ "\ +This may be a false alarm, but possibly your graphics hardware does not +work well with only free software. Expect trouble. If after installation, +the system does not boot, perhaps you will need to add nomodeset to the +kernel arguments and need to configure the uvesafb kernel module.") + (G_ "Pre-install warning"))) (run-menu-page (G_ "GNU Guix install") (G_ "Welcome to GNU Guix system installer! @@ -148,3 +159,4 @@ (define (run-welcome-page logo) (newt-finish) (reboot)))) #:listbox-item->text car)) + )