From patchwork Mon Dec 9 20:25:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vagrant Cascadian X-Patchwork-Id: 34709 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A3B2227BBEA; Mon, 9 Dec 2024 20:26:26 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2355527BBE2 for ; Mon, 9 Dec 2024 20:26:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKkKS-0004Se-8v; Mon, 09 Dec 2024 15:26:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkKQ-0004SR-HT for guix-patches@gnu.org; Mon, 09 Dec 2024 15:26:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKkKQ-0001yX-9A for guix-patches@gnu.org; Mon, 09 Dec 2024 15:26:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=guwhzVc9t2gzIZ8OiA/sY8mmFwUyegocL1z2BJQv+sE=; b=nBfTPLpmKhw7fSuxCGYYr4u5cvH/gXRxXRAsHfujjvJL8TpgnNdp0lFMlWtoLDOTYl83D49Ztuy24FAMaLuwpD6AG2xj051EC8vv/Q0IP5GQAh2CbeUU9q0YqcJVIlXnX4DKsifxE5rTf8nhvRR7H+J05Ut9tmu/aNBM+mjxiw4dGPoNIOi3pZEDnMaL80ZFcKghemfkYPzeabYmgett7wuLwIjyQEnDjSmCxrQ7RmE2rtwTxIEauMHj8Xyk5kPJULJKKaPts8jSfk7ZtZTBNcTKlS0jc/rQnR1YHLe5/rvMe260kkm1WiinDTCzRsar/CRvZpNbkAr/IwSkEunu/w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKkKP-0004Uw-UN for guix-patches@gnu.org; Mon, 09 Dec 2024 15:26:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74755] etc/git/pre-push: Run guix git authenticate before check-channel-news Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Dec 2024 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 74755@debbugs.gnu.org Cc: vagrant@debian.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173377594817247 (code B ref -1); Mon, 09 Dec 2024 20:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Dec 2024 20:25:48 +0000 Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKkKB-0004U7-Ko for submit@debbugs.gnu.org; Mon, 09 Dec 2024 15:25:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:40568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKkK9-0004Tx-Oo for submit@debbugs.gnu.org; Mon, 09 Dec 2024 15:25:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkK8-0004RW-VQ for guix-patches@gnu.org; Mon, 09 Dec 2024 15:25:45 -0500 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKkK7-0001x7-43 for guix-patches@gnu.org; Mon, 09 Dec 2024 15:25:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1733775940; bh=GNmXlJy+TVwPiT2sQI0By2naaWg/O+BzLGqATDaD+9U=; h=From:To:Cc:Subject:Date:From; b=de5Plw0lA32Xw7ADqmGFTrrDi9Ytm9WGjYETWp3XHiDWeiYxONm1lNG4VwuwTe4MR ivWnGsCEqHIfnOoftVmU/a6CY6C4J9cXiI2xaCzlkuamblMFuMlmn3PP8lbm9DUfYm X2Qe/GdQqVlEjYyNxMt74uHAW8WaIZADeZplOt2Ubcgcld2zY5fodPKGeEIf+V0BCn cw6DdmbgLGna+M3lc9NkCerEcEbGkbFqLcE3Jj1MaubrPRZGxpATBjLIBBxq2UfI0j IKXYgVAMpejm5kRzhH2xRh+i3Ssu4YGouqwKqgdDaAjVNZpvkmn6gvs4BKcVomOXly 7F36X7jPmvBEg== Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) by cascadia.aikidev.net (Postfix) with ESMTPSA id D497E2705; Mon, 9 Dec 2024 12:25:40 -0800 (PST) From: Vagrant Cascadian Date: Mon, 09 Dec 2024 12:25:34 -0800 Message-ID: <878qsovc1t.fsf@wireframe> MIME-Version: 1.0 Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.489, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Running check-channel-news before authenticating the repository could result in running unauthenticated code; the attached patch switches the order they are run in. live well, vagrant From 42bd8ceceada3ad764a450c040bc2a9a1e3f7842 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Mon, 9 Dec 2024 12:21:30 -0800 Subject: [PATCH] etc: git: pre-push: Run guix git authenticate before check-channel-news. Running check-channel-news first could potentially be untrusted code, so authenticate first. * etc/git/pre-push: Run guix git authenticate before check-channel-news. --- etc/git/pre-push | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/git/pre-push b/etc/git/pre-push index 325b23854b..752310d854 100755 --- a/etc/git/pre-push +++ b/etc/git/pre-push @@ -33,8 +33,8 @@ do case "$2" in *.gnu.org*) set -e - make check-channel-news exec guix git authenticate + make check-channel-news exit 127 ;; *) base-commit: da3c8a963f83c044568d99921480259eaa26a923 -- 2.39.5