From patchwork Sun May 29 16:03:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bassam Saeed X-Patchwork-Id: 2741 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id DC32E27BBEA; Sun, 29 May 2022 20:56:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7448127BBE9 for ; Sun, 29 May 2022 20:56:13 +0100 (BST) Received: from localhost ([::1]:43284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvP1I-0007RJ-MA for patchwork@mira.cbaines.net; Sun, 29 May 2022 15:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvMe3-0007Jv-1W for guix-patches@gnu.org; Sun, 29 May 2022 13:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvMe2-0008AV-PS for guix-patches@gnu.org; Sun, 29 May 2022 13:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nvMe2-0001U8-K4 for guix-patches@gnu.org; Sun, 29 May 2022 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55710] [PATCH] gnu: quodlibet: Set GST_PLUGIN_SYSTEM_PATH. Resent-From: Bassam Saeed Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 May 2022 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55710 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55710@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16538450225676 (code B ref -1); Sun, 29 May 2022 17:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2022 17:23:42 +0000 Received: from localhost ([127.0.0.1]:41778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvMdi-0001TU-9U for submit@debbugs.gnu.org; Sun, 29 May 2022 13:23:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:58448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nvLO4-0005h1-0P for submit@debbugs.gnu.org; Sun, 29 May 2022 12:03:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvLO3-0006Aj-5I for guix-patches@gnu.org; Sun, 29 May 2022 12:03:27 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:39593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nvLO0-00057l-Lq for guix-patches@gnu.org; Sun, 29 May 2022 12:03:26 -0400 Received: by mail-io1-xd32.google.com with SMTP id s19so1291347ioa.6 for ; Sun, 29 May 2022 09:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=8T6ChKKhnzddxTI8Yk4lNccAvAUlrkIMiGg0QcP4vy4=; b=mC+VtGW93i4CwA+wdUgqnlZri1FdKoawYmjXTa6WglxgpUjeBgrRhoMdzpMoDqVERJ xdAPJWz3cs+ZEFDWwQ5aFQ/q/PrmgcNUsJnePwZ2Squ0PCmYDHH431F/sd4U8Xcuut/l 9urtDyx834F+DtxqYe9yMsxrjvQGA9zksd5SIjRo+NfDb3YMtX7JdugRu16+3yOZcY2v GW1VE2Jre4azlW7U1adHwmC3xfgp0dYniQa8ETB0UTmIpT5dT8+BpKyvcf8YkJ/Iivg8 vHW7NMoCJG5zjnwPIrKOTSHKGy7Ez9b+CCWVMtqU7wFeC5/rwiShddGRjJ2RTIfmsYcS /QBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8T6ChKKhnzddxTI8Yk4lNccAvAUlrkIMiGg0QcP4vy4=; b=mBg3cyzSEBEOWIOX167DPt/l+V3fdWKAfq6rmPhICrQFS32UW6iWFqa+IatrTNixCW fuuReCuE3BA22UO3GQzpgsdLQf5uTy0FiEwVsDDdSkOkdZKqlnKDOMDoIm90haLqp+pm jwk9f2W3BQe1sGYCDubQwPymabuV5+kemjAA48Dhozq9ZDvlkNzb4lW2sQYfP9RC0abo Y7oh/9x6nEzx1gvHsPgDoVPgPPKryu089Maw6OASVhlPvykzkrtsA7odHDEY5iZ7F7aa 5yjKS3vRkyS1fZd8uS5qPRLgjRDcG0hPBV3U81FWidGhwp/UN8rl/JmVjxfvh7sQ9m+N 0/iQ== X-Gm-Message-State: AOAM532olLDGD/jLDEoHIaftTlHjFL9UkzZr1RkhXvfiVMiDp3Sr0RW0 ln/tlCQo1+3h8aYhu5TaIai+rfpUhssjgQnOtNNLpKar X-Google-Smtp-Source: ABdhPJyId7z38rAgkqfU5zwgErn/qBY9vuavwh2aNwvcs1TnYCAlLrw2aPCSZlhJUApmXANGEzwnPrXcGYcv4VQk49s= X-Received: by 2002:a02:aa04:0:b0:32e:c9f8:87ba with SMTP id r4-20020a02aa04000000b0032ec9f887bamr17309163jam.254.1653840202811; Sun, 29 May 2022 09:03:22 -0700 (PDT) MIME-Version: 1.0 From: Bassam Saeed Date: Sun, 29 May 2022 12:03:12 -0400 Message-ID: Received-SPF: pass client-ip=2607:f8b0:4864:20::d32; envelope-from=daisuke2@gmail.com; helo=mail-io1-xd32.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 29 May 2022 13:23:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sun, 29 May 2022 15:56:05 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi all, Currently, quodlibet is unable to find a gstreamer audio sink when playing audio unless the relevant gst-plugins is explicitly installed in your profile. For me that's gst-plugins-good. Currently, existing packaged applications such as Strawberry and Clementine explicitly set the GST_PLUGIN_SYSTEM_PATH. I've adapted this for Quodlibet with my patch. I suppose an alternative might be to include the gst plugins as propagated-inputs but I'm not certain about that. I decided to just follow the current practice. Hope everything is right here. My first patch to guix. Cheers, Bassam From 1c0a33328b3475f39d10d9a668ba11f702b962dd Mon Sep 17 00:00:00 2001 Message-Id: <1c0a33328b3475f39d10d9a668ba11f702b962dd.1653839478.git.bassam.saeed@gmail.com> From: Bassam Saeed Date: Sun, 29 May 2022 11:35:57 -0400 Subject: [PATCH] gnu: quodlibet: Set GST_PLUGIN_SYSTEM_PATH. --- gnu/packages/music.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 9011f262a4..b4ff2bef0e 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -6904,6 +6904,13 @@ (define-public quodlibet ,@%glib-or-gtk-build-system-modules) #:phases #~(modify-phases %standard-phases + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) + (wrap-program (string-append out "/bin/quodlibet") + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))) + #t))) (add-before 'check 'pre-check (lambda _ (setenv "HOME" (getcwd)))) base-commit: 9cd22702b87f873f7e307c99b406fb758e5a307c -- 2.36.1