From patchwork Sat Jul 23 22:14:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joeke de Graaf X-Patchwork-Id: 40887 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3898427BBEB; Sat, 23 Jul 2022 23:21:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7EEB927BBEA for ; Sat, 23 Jul 2022 23:21:09 +0100 (BST) Received: from localhost ([::1]:50838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFNUi-0005Rr-Mp for patchwork@mira.cbaines.net; Sat, 23 Jul 2022 18:21:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFNPm-0005Bj-O0 for guix-patches@gnu.org; Sat, 23 Jul 2022 18:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFNPm-00066u-FJ for guix-patches@gnu.org; Sat, 23 Jul 2022 18:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFNPm-0005SP-Ah for guix-patches@gnu.org; Sat, 23 Jul 2022 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56668] [PATCH] gnu: Add wavbreaker References: <87r12gj8bt.fsf@bolo-santosi.mail-host-address-is-not-set> In-Reply-To: <87r12gj8bt.fsf@bolo-santosi.mail-host-address-is-not-set> Resent-From: Joeke de Graaf Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Jul 2022 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56668@debbugs.gnu.org Received: via spool by 56668-submit@debbugs.gnu.org id=B56668.165861450220870 (code B ref 56668); Sat, 23 Jul 2022 22:16:02 +0000 Received: (at 56668) by debbugs.gnu.org; 23 Jul 2022 22:15:02 +0000 Received: from localhost ([127.0.0.1]:46500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFNOn-0005QE-CF for submit@debbugs.gnu.org; Sat, 23 Jul 2022 18:15:02 -0400 Received: from mout01.posteo.de ([185.67.36.65]:36427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFNOi-0005Pu-Kb for 56668@debbugs.gnu.org; Sat, 23 Jul 2022 18:15:00 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7A4AC240026 for <56668@debbugs.gnu.org>; Sun, 24 Jul 2022 00:14:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1658614490; bh=m4z6QvECne4IW9fUqoYJ5eKMaOETuEto2Kj/ub+StmQ=; h=Date:From:To:Subject:From; b=PXVMJDAIfO5ID5pVg3huRpqEkPR/tvz965jRCzXdDLfBo29ZUqYcea4Tr1jFZeucr kzhbcgCXbaxns6mcaMvwBcF6UTZk2UrdBxLy07RJAT9MyYBM+gP5Os2BSdSp/p/7v/ zQMd7gJqFxwLD4jonAcEIlYFtg3AEhaqE6NQCrk/6BvhoD3nPcUd7FtZOIOL9fP1Nu G070cvuoe0oF9IUHxwYNrdiBS2qK4vlUeWbEqnwDSijTz5DEXpj6Lay0Ai2a0DqYoZ jwAP/DNKtA+BwQn8B9eV6ryFlql1gWKBDq4tzeE60bWjqwo0rrnS1YkFBRk9MgAw4k Jmlzul623gJ5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Lr0wT5KHBz6tmT for <56668@debbugs.gnu.org>; Sun, 24 Jul 2022 00:14:48 +0200 (CEST) MIME-Version: 1.0 Date: Sat, 23 Jul 2022 22:14:48 +0000 From: Joeke de Graaf Message-ID: <95b8983678dc2e08f40fcda54e1f47be@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sat, 23 Jul 2022 18:21:01 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On 23.07.2022 21:51, Maxime Devos wrote: > On 20-07-2022 14:07, Joeke de Graaf wrote: >> + (license license:gpl2))) > > Going by > https://github.com/thp/wavbreaker/blob/master/src/appconfig.c, it's > actually gpl2+, though I haven't verified whether that applies to all > files. You're right, I missed that. I attached a new patch. On 23.07.2022 21:50, Maxime Devos wrote: > On 20-07-2022 14:07, Joeke de Graaf wrote: > >> + (native-inputs >> + (list pkg-config cmake)) >> + (inputs (list glib gtk+ ao)) > > Please check that it works nicely (with, e.g., no missing icons, which > sometimes happens for GTK+ stuff) in a pure environment. Try: > > $ guix shell --pure wavbreaker -- > insert-the-binary-name-here,probably-wavbreaker > > If there are problems, we'll have to add some things to fix them. It seems that in the package's current state, it does not like being run in a pure environment, it simply crashes. The application seems to expect GTK icons to be in a certain place and it's not finding them. It's not immediately obvious to me what the solution for this is, but I gather from your previous e-mail that this is a known and fixable problem. In any case, I attached the output of $ guix shell --pure -- wavbreaker as a plain text attachment. Best regards, Joeke de Graaf $ guix shell --pure wavbreaker -- wavbreaker (wavbreaker:30189): Gtk-WARNING **: 23:42:50.230: Could not find the icon 'document-open-symbolic-ltr'. The 'hicolor' theme was not found either, perhaps you need to install it. You can get a copy from: http://icon-theme.freedesktop.org/releases (wavbreaker:30189): Gtk-WARNING **: 23:42:50.230: Could not load a pixbuf from /org/gtk/libgtk/icons/16x16/status/image-missing.png. This may indicate that pixbuf loaders or the mime database could not be found. ** Gtk:ERROR:gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /org/gtk/libgtk/icons/16x16/status/image-missing.png: Unrecognized image file format (gdk-pixbuf-error-quark, 3) Bail out! Gtk:ERROR:gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /org/gtk/libgtk/icons/16x16/status/image-missing.png: Unrecognized image file format (gdk-pixbuf-error-quark, 3) From d2a7b50cb8148355b725c90ac9068f103b94970e Mon Sep 17 00:00:00 2001 From: Joeke de Graaf Date: Sat, 23 Jul 2022 23:25:12 +0200 Subject: [PATCH] gnu: Add wavbreaker --- gnu/packages/mp3.scm | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 4a8bdad711..a42dc26ddf 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2020 Michael Rohleder ;;; Copyright © 2021 Simon Streit ;;; Copyright © 2021 Guillaume Le Vaillant +;;; Copyright © 2022 Joeke de Graaf ;;; ;;; This file is part of GNU Guix. ;;; @@ -50,13 +51,15 @@ (define-module (gnu packages mp3) #:use-module (gnu packages pulseaudio) #:use-module (gnu packages linux) ;alsa-lib #:use-module (gnu packages video) ;ffmpeg + #:use-module (gnu packages cmake) #:use-module (guix packages) #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system gnu) #:use-module (guix build-system python) - #:use-module (guix build-system cmake)) + #:use-module (guix build-system cmake) + #:use-module (guix build-system-meson)) (define-public libmad (package @@ -710,3 +713,30 @@ (define-public python-pytaglib cross-platform, works with all Python versions, and is very simple to use yet fully featured.") (license license:gpl3))) + +(define-public wavbreaker + (package + (name "wavbreaker") + (version "0.15") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/thp/wavbreaker/") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "16h0sfcb8av6a368giizzwv9m0lq5c3bnf4b9vyyh9nkbbsc7c3j")))) + (build-system meson-build-system) + (native-inputs + (list pkg-config cmake)) + (inputs (list glib gtk+ ao)) + (home-page "https://wavbreaker.sourceforge.io/") + (synopsis "WAV and MP3 file splitter with a GUI") + (description + "Wavbreaker is a WAV and MP3 file splitter. It can be used to +break up a WAV or MP3 audio file into multiple WAV files. +Wavbreaker contains a helpful waveform display of the audio file +being edited, to help the user in splitting the file at the right +point. Wavbreaker also supports splitting MP3 files without +re-encoding them, to preserve their original audio quality.") + (license license:gpl2+))) -- 2.37.0