From patchwork Mon Jun 27 11:24:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ontje.Luensdorf@dlr.de X-Patchwork-Id: 40355 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E69A227BBEA; Mon, 27 Jun 2022 13:34:20 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1E82327BBE9 for ; Mon, 27 Jun 2022 13:34:20 +0100 (BST) Received: from localhost ([::1]:53446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5nwZ-0007Mm-2v for patchwork@mira.cbaines.net; Mon, 27 Jun 2022 08:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5nuN-0005Eo-F4 for guix-patches@gnu.org; Mon, 27 Jun 2022 08:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5nuN-00057t-6I for guix-patches@gnu.org; Mon, 27 Jun 2022 08:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5nuM-0007T8-VU for guix-patches@gnu.org; Mon, 27 Jun 2022 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56257] [PATCH] fenics: Do not use mpirun for tests Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Jun 2022 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56257@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.165633311328235 (code B ref -1); Mon, 27 Jun 2022 12:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2022 12:31:53 +0000 Received: from localhost ([127.0.0.1]:50234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5nuD-0007L0-3k for submit@debbugs.gnu.org; Mon, 27 Jun 2022 08:31:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:34940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5mrR-0007Wb-Ks for submit@debbugs.gnu.org; Mon, 27 Jun 2022 07:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5mrR-0007In-FG for guix-patches@gnu.org; Mon, 27 Jun 2022 07:24:57 -0400 Received: from mailin.dlr.de ([194.94.201.12]:15272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5mrO-0000KT-KU for guix-patches@gnu.org; Mon, 27 Jun 2022 07:24:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dlr.de; i=@dlr.de; q=dns/txt; s=052022; t=1656329094; x=1687865094; h=from:to:subject:date:message-id:mime-version; bh=XSmkQFzx9z/w40wIwlX0IQgGjVPuDS9BIIEUCLK8utM=; b=F/K6l5ydf5r7mBk9qyC0EELH95v0Yv7dEKq83EAntLtUEHy7gE3FItsD 5MjmgnzwhsZvat5XbEh/EOna/FIdEN5xn0R5I0w/BmJLpSFd5TqVgUGBY kwLFnjhy/lcHFd5Ga5VKFCeiGaIE0AjmSVz7OGZmJnkRCNov0sckd3hNl o2pcmomAQBriZjjDr1FCo3LyDEaDPQfvtGAmK6zf+YcVHkvrNGwHxnavZ 1cQRpmfeHjPzWKTYQ57z1DPZwO0/UGWTM6EtvELiUwmtDvtWvYhYPo7pO w1dNbpixAgclVUJqZ2XUvTLEEns780k84wdv1ZVCoQEih2MNpE3SunsFM w==; X-IPAS-Result: A2EiBAAYk7li/xeKuApaHgEBCxIMQIFEC4MjAoFXF5VFnHWBfAQHAQEBAQEBAQEBCAE3CwQBAQMEhHyFTiY2Bw4BAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBAQYEAQECgRiFLzkNgjUifIEIAQEBAQEBAQEBAQEBAQEBAQEBARYCDVJmAS1EIAEZAwECCicNASIdCgQTDoJwgxgSqkJ4gQEygQGDTwGBHoUBCgaBPZFIgRWCem6EHD8JLYVuBIJelxsDRy8SgSBBLQEIBgYHCgUwBgIMGBQEAhMSUxwCEgwKGw5UFwwPAxIDEQEHAgkSCBUrCAMCAwgDAgMrAgMWCQcKAx0IChwSEBQCBBEeCwgDGR4sCQIEDgNACAsKAxEEAxMYCRYIEAQGAwgvDScLAxQNAQYDBgIFBQEDIAMUAwUkBwMhDyYNDQQiHQMDBSUDAgIbBwICAwIGFQYCAm4uDQgECAQ3JA8FAgcvBQQvAh4EBQYRCAIWAgYEBQIEBBYCEAgCCCcXBxMzGQEFMicQCSEcKRAFBhYDIW4FRQ8oNDY8LB8bCoEaLCsWAwQEAwIGHAMDIgISLAYMBiKbJEVMDioKASsEBXwWMnCgKkSBMw+dYYEwB4IUhzOFK5UmlmSRfwGWcI0wmWUCBAIEBQIWgWgGgglxgzdRFwIPlyaFSnUCOQIGCwEBAwmGR4VzgTWBEgEB IronPort-PHdr: A9a23:KVyIMhL1JYaiFFTTGtmcuHhmWUAX0o4c3iYr45Yqw4hDbr6kt8y7e hCFvrM00AKCBtSTwskHotKei7rnV20E7MTJm1E5W7sIaSU4j94LlRcrGs+PBB6zBvfraysnA JYKDwc9rDm0PkdPBcnxeUDZrGGs4j4OABX/Mhd+KvjoFoLIgMm7ye6/94fObwhHhDexbr1/I RGrpgjNq8cahpdvJLwswRXTuHtIfOpWxWJsJV2Nmhv3+9m98p1+/SlOovwt78FPX7n0cKQ+V rxYES8pM3sp683xtBnMVhWA630BWWgLiBVIAgzF7BbnXpfttybxq+Rw1DWGMcDwULs5Xymp4 aV2Rx/ykCoJNyA3/nzLisJ+j6xboQ6uqBNkzo7RfI2YLuBzcr/Bcd8HQ2dKQ8ZfVzZGAoO5d 4YCCPMPPeBEr4n/uVQCtx2wBRSyC+Pp0T9Hm3j23bc00+k6DA7G2BYgE8gTv3vKtdj4MroZX u+pwqfS1zrDc+9W1inn6IjOah0sr/GCUax+f8bNxkciFgfIgFqMpID4IT6Y2fkAv3WV4edhS e+iiWEppgNyrzWr2sshjorEi54axF3Y6Sh13Ig7KNulQ0B1Zt6kFYFftyCcN4ZuTcMiRXxot Dw9yr0ctp62ejUBxpc/xxPHdvCLb5KE7g/gWeueOzt0mXxodbGlixqs/0Ws0vDwWtWu3FpXr SdIncPAum0D2hHQ8MSLVPtw80in1D2SzQ7c8PtELloxlafDLp4hxaM/mYQLvETYGy/2hF32j KiLdkU44uSo6/roYrHhppKEOYF6jA/wPKsulMK/Buo2MQ8AUXKF9emy27Ps/FP0TK9Ljv0wj qnZqorVKd4Gqa69GQ9ZyJss5AinAzen1tQXg2UHIUpYdB6blYTlJlLDLf/iAfuijVmhky1ny +7IM7H5B5XCNHnDkLPvfbZn7E5czRI+w8lZ55JICLEOPuj/VEnstNPGCB85KBG7w+H9CNVzz Y4RRGaPArWDPKzPr1CE/uQvLPKUa48PpDn9M+Ql5+LpjXIhhFMRZbOp0ocPaHCkAvRmJF2UY XXxgtcAHmYGpxI+Q/b2iFKeUT5ceW2yUrkz5jE9FYKqF4DDRpqigO/J4CDuSpJLZ3ADElmQG nflbK2LXepKbziddJxPiDsBAOyGTZMj2FeKqQL80LZgNOT89ikC857ugosmr9bPnA0/oGQnR /+W1HuAGjkcow== IronPort-Data: A9a23:nthoTawMYi3JpYx06CV6t+cdxyrEfRIJ4+MujC+fZmQN5Upmgn1D0 SoCGTjCaae61lCFe9l2aZDhqw8b78OLl4UgVXYzsHdqUzdPscvfGNLcMkrrIzjUNsTfR0IPA 642N4fKd8o+FiWB/Un8abW583ch3v/ZFuqlVb+ea3kuGlFoFHgrg08+wbI0joNi29HmWg+Ht d38rZSFZQb/hWMkaAr4h077RDZH5Zwe7xtC5gVmDRwygGLjqpU1MH4+Day6cHGgT9NYF+O3S rebwu7g8m2FoBp9Bo76wub2LENRa7ODZgLmZli6+kSBbrquggRoj87X4dJFMR8/Zw2hxow3k JMU3XCJYV9B0pfkwYzxaDEFVXAkVUF60OWfeyLn75bMlxSun0bEmp2CMmlnZeX0xc4qWQmix dRAQNzaRkne7w4e6OvTpthE3qzPHuGyVG8ski0IIQXiMBoTacurr5MmRDNv9GxYashmRZ4yb ieCANZlREyojxZnYj/7BH+i9QsBa7aWnzBw8TqoSaQLD2f70lIo/5vVafnpPYaxdfUKpl/fv Fzl1jGsav0aHIT3JTut3laAq8HhuALeYNhJOY2TsP9snEeagGAXElsaWDNXo9Hg0gjnC44Zc hdEvHB1xUQx3BXDot3VeBukonPCmgMRXcFcFPc0wA2J0OzY7m51A0BbFGceMoB56afaQxQ31 nDUkt/tIQdTl6O5UFTM2561vw69bH19wWgqIHVsoRE+y9b+oZF2lhvTRdZuC4a6iMCzHiv/q w1mtwAyg7keg8AO1qCjpwvKkznqp57VVAdz6gHNGG6ohu9kWLOYi0WTwQCzxZ59wEyxFTFtY FBsdxCi0d0z IronPort-HdrOrdr: A9a23:rwQNsKhzI3DQo/hkyHveKlu2tHBQXuEji2hC6mlwRA09TyXBrb HNoB1p726QtN9xYgBYpTnuAsm9qB/nmKKdgrNhRYtKPjOW21dARbsKheCJ/9SKIULDH5tmtJ uIBJIRNDSfNzRHZI3BkW2F+p4bsb66GY6T9IHj80s= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos; i="5.92,226,1650924000"; d="scan'208,223"; a="72172475" From: Thread-Topic: [PATCH] fenics: Do not use mpirun for tests Thread-Index: AQHYihiDt/XO5z75+U2c/n1SP0a9PA== Date: Mon, 27 Jun 2022 11:24:49 +0000 Message-ID: <87bkuefiwu.fsf@dlr.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: MIME-Version: 1.0 Received-SPF: pass client-ip=194.94.201.12; envelope-from=Ontje.Luensdorf@dlr.de; helo=mailin.dlr.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 27 Jun 2022 08:31:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi guix, the fenics package tests fail and it looks like the tests are run 3 times concurrently. Every test name is printed three times in the build log, for example here: https://ci.guix.gnu.org/build/1039880/log/raw This is the maximum number of parallel jobs of the test run and if I increase it, I get more print outputs. AFAIK, pytest doesn't support mpi, so I don't see why the tests are executed this way. Anyhow, in the attached patch, the tests are executed directly using pytest. This prevents the tests from getting stuck and subsequently I discovered a failure in XDMF tests. With this test also disabled, the package builds fine for me. Maybe a fenics or mpi expert can tell if this patch makes sense? Best regards, Ontje From 8dd11596851ab5a7ae1d483b9883894a9bd4d4ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ontje=20L=C3=BCnsdorf?= Date: Mon, 27 Jun 2022 11:51:10 +0200 Subject: [PATCH] gnu: fenics: Do not mpirun tests. * gnu/packages/simulation.scm (fenics)[phases]: Do not use mpirun for tests and skip failing XDMF test. --- gnu/packages/simulation.scm | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm index 9e92fbcc5b..df4dd2d17a 100644 --- a/gnu/packages/simulation.scm +++ b/gnu/packages/simulation.scm @@ -665,15 +665,14 @@ (define-public fenics (lambda* (#:key tests? #:allow-other-keys) (when tests? (with-directory-excursion "test" - ;; Note: The test test_snes_set_from_options() in the file - ;; unit/nls/test_PETScSNES_solver.py fails and is ignored. - ;; Limit the number of jobs to 3 as 500 MiB of memory is used - ;; per process. - (invoke "mpirun" "-np" (number->string - (min 3 (parallel-job-count))) - "python" "-B" "-m" - "pytest" "unit" "--ignore" - "unit/nls/test_PETScSNES_solver.py"))))) + (invoke + "pytest" "unit" + ;; The test test_snes_set_from_options() in the file + ;; unit/nls/test_PETScSNES_solver.py fails and is ignored. + "--ignore" "unit/nls/test_PETScSNES_solver.py" + ;; Fails with a segfault. + "--ignore" "unit/io/test_XDMF.py" + ))))) (add-after 'install 'install-demo-files (lambda* (#:key outputs #:allow-other-keys) (let* ((demos (string-append base-commit: 97766323bc6e2b4dcfba4d6b46749a4280bca709 -- 2.36.1