From patchwork Fri May 27 17:23:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?RXJpayDFoGFiacSN?= X-Patchwork-Id: 39635 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BFC4F27BBEA; Fri, 27 May 2022 18:24:29 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 868EF27BBE9 for ; Fri, 27 May 2022 18:24:29 +0100 (BST) Received: from localhost ([::1]:51782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nudhM-0001nk-Mq for patchwork@mira.cbaines.net; Fri, 27 May 2022 13:24:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nudgw-0001n8-S3 for guix-patches@gnu.org; Fri, 27 May 2022 13:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nudgw-0003Zl-JM for guix-patches@gnu.org; Fri, 27 May 2022 13:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nudgw-0002xa-GI for guix-patches@gnu.org; Fri, 27 May 2022 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19. Resent-From: Erik =?utf-8?b?xaBhYmnEjQ==?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55674 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55674@debbugs.gnu.org Received: via spool by 55674-submit@debbugs.gnu.org id=B55674.165367222311338 (code B ref 55674); Fri, 27 May 2022 17:24:02 +0000 Received: (at 55674) by debbugs.gnu.org; 27 May 2022 17:23:43 +0000 Received: from localhost ([127.0.0.1]:35728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nudgZ-0002wk-15 for submit@debbugs.gnu.org; Fri, 27 May 2022 13:23:43 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:46625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nudgX-0002wW-7r for 55674@debbugs.gnu.org; Fri, 27 May 2022 13:23:37 -0400 Received: by mail-oi1-f172.google.com with SMTP id q8so6381951oif.13 for <55674@debbugs.gnu.org>; Fri, 27 May 2022 10:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GBDygCzDyo+hUzZgQK63Y9MZQr3ATeWxIvDSEo/O+Zs=; b=C33xxITi31M52oUPvR0IKshOdzxAayft6f6gHRXVIQYpKbHVM43xBLXqX4Q0SX8kaI 99d2dSsDsoy7h5v3FbnJmE555NCXCNSibLqubrspjR++GEhr80pdSwrOM3ckhW7Dl+7V 59wyBIv9LVDFOmHQdUM3WnEvYdkLWL9sG9/gX+wbrr0gmAz/7kdnwol+K2EIDwSiA+81 Gvktrc33VqdrvorqNKb9nDJzshxFkUHY1tIFvfyEzab0nxHeKfCdQbE7WKrN8DVH7OKn S2cj2gSDd2Fo2M/N1qKMe+RBfbOrDqWHln+swQ8/WOEyVH9E7JAq5Z9Fsfe8AN4dDyT+ RLSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GBDygCzDyo+hUzZgQK63Y9MZQr3ATeWxIvDSEo/O+Zs=; b=OSfXvSe4+lTDob3JdW3SUc2f/m/2PkZ8X/TmDgPDkYTrgzIQ4MLij9MI406QkXPvY6 q5KriHEXm5A3oSz6uhzTn71Lu3ZAky1uGh/mQanuehfCo4jvzd/THBUpDX01IwwxiWlw vCXQnOhckoF3qFlC06m8ynAiLRwjYH65NMj4BggsFSaXwJoYS9lSw+0OkHgF9AP6xX4I dULXNpJfpkARUNLvSyKrTk9+MwEdCDpcJ3LpRhRZ90I0sv6kiuQPaxtEY7s5KBWQd2Hq VzaP4QRfUVbdRr9rckcGNyadN6WiZH34MQ9RlGww5GnDtc3iV1ZcPkvcQVTiJEydMIne jDQQ== X-Gm-Message-State: AOAM533bfSX3gmJNfRN42GBHBsflTImUWq10JWEwqYxeuX5wNS0yvjzW yGeZNkcZDNSMkD1lBO0IRedOtEAeh5U/wCozIC8= X-Google-Smtp-Source: ABdhPJy+F+DOq8ydiAQnKH9cjQlaSUEctQI05ReXSlzYQ7+vstyWv44UubXJTCEK/KG3sCJ+Gti91zVIjRPK4UAHA2g= X-Received: by 2002:a05:6808:613:b0:32b:f27:2891 with SMTP id y19-20020a056808061300b0032b0f272891mr4520235oih.166.1653672211453; Fri, 27 May 2022 10:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20220527125242.27817-1-erik.sab@gmail.com> <20220527125242.27817-2-erik.sab@gmail.com> <7fa715e77a2f947b2104a3c578c001125842b01f.camel@telenet.be> <56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be> In-Reply-To: <56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be> From: Erik =?utf-8?b?xaBhYmnEjQ==?= Date: Fri, 27 May 2022 19:23:20 +0200 Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Okay, I figured it out. The test is indeed broken and it's an easy fix. I will try sending a PR on github. I have a lot to learn. I apologise for being a nuisance :) Please tell me if there's anything else I can improve on. Thank you! here's a diff for the test: diff --git a/test/helpful-unit-test.el b/test/helpful-unit-test.el index a07aa8e..1a61a6f 100644 nil) On Fri, May 27, 2022 at 3:48 PM Maxime Devos wrote: > > [Please keep 55675@debbugs.gnu.org in CC] > > Erik Šabič schreef op vr 27-05-2022 om 15:32 [+0200]: > > Well it fails on a test defined like this: > > (ert-deftest helpful--docstring () > > "Basic docstring fetching." > > (should > > (equal > > (helpful--docstring #'test-foo t) > > "Docstring here."))) > > > > And fails like so: > > ...............s...s..Test helpful--docstring-advice backtrace: > > > > > > Test helpful--docstring-advice condition: > > > > (ert-test-failed > > ((should > > (equal > > (helpful--docstring ... t) > > "Docstring here too.")) > > :form > > (equal "Docstring here too.\n\nThis function has :around > > advice: `ad-Advice-test-foo-advised'." "Docstring here too.") > > :value nil :explanation > > (arrays-of-different-length 84 19 "Docstring here too.\n\nThis > > function has :around advice: `ad-Advice-test-foo-advised'." > > "Docstring here too." first-mismatch-at 19))) > > > > F............................................................s...... > > Looks like a bug. > > > I don't know anything about emacs-ert. And I wasn't able to > > figure out if it works for the upstream author. > > > > WDYT? > > I don't know if it fails for the upstream author, but I don't think > that's relevant to Guix. More relevant I think, is that this bug > appears in Guix, so it can cause problems for Guix users, so some > fixing might be necessary. > > I don't know much about Emacs though, so you might need to contact > upstream about the bug. > > Greetings, > Maxime. --- a/test/helpful-unit-test.el +++ b/test/helpful-unit-test.el @@ -119,7 +119,7 @@ bar"))) (should (equal (helpful--docstring #'test-foo-advised t) - "Docstring here too."))) + "Docstring here too.\n\nThis function has :around advice: `ad-Advice-test-foo-advised'."))) (defun test-foo-no-docstring ()