From patchwork Sun May 15 16:38:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: kyle X-Patchwork-Id: 39376 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8611F27BBEA; Sun, 15 May 2022 18:11:16 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 092A127BBE9 for ; Sun, 15 May 2022 18:11:16 +0100 (BST) Received: from localhost ([::1]:58346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqHlz-0005lO-6i for patchwork@mira.cbaines.net; Sun, 15 May 2022 13:11:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqHlm-0005kf-CJ for guix-patches@gnu.org; Sun, 15 May 2022 13:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nqHlm-0000Y2-0y for guix-patches@gnu.org; Sun, 15 May 2022 13:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nqHll-0004P8-TH for guix-patches@gnu.org; Sun, 15 May 2022 13:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55381] [PATCH 05/14] gnu: Add r-unglue. Resent-From: Kyle Andrews Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 May 2022 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55381 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55381@debbugs.gnu.org Received: via spool by 55381-submit@debbugs.gnu.org id=B55381.165263465616918 (code B ref 55381); Sun, 15 May 2022 17:11:01 +0000 Received: (at 55381) by debbugs.gnu.org; 15 May 2022 17:10:56 +0000 Received: from localhost ([127.0.0.1]:50559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqHlf-0004Oo-V8 for submit@debbugs.gnu.org; Sun, 15 May 2022 13:10:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqHld-0004OX-Is for 55381@debbugs.gnu.org; Sun, 15 May 2022 13:10:54 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 706DF240027 for <55381@debbugs.gnu.org>; Sun, 15 May 2022 19:10:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1652634647; bh=9doSpWglyvtH9ct0FLshFh1Xo9Z+SkRLrJDljhPrNQU=; h=From:To:Cc:Subject:Date:From; b=o8ST9gJpKWUZAcKfmNJ06DSXMK+GwdOhJiBytYno8+0ckVh+LbJSuq9kwjdVNK3B8 0kVLg0PamhNOc3vWwUFkuZfU82RmtrH4Fdt8v82zlaAreJFpv00OXr/Uee3bxHAfYR m8cULUznLD8CBD3d7OIl7SZr11TNHwwDBNxGfSH3sVO1c+BZNUO7qW+GD+C8oj2CTy xJPLhqOa4Loz6ce1jcugO/ivKgSZGjJtsAFJjXBr0HhOOSZa1sFFJHILcLAdFBatRs yHMcN/15DnAEl/hmJtHj60Aa2k8qmR5mTM8mI1Zhb74FBhyv1I4518EF8bk+8HY1RL SLWQA/I0x7skQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4L1TRT4bvMz6tmJ; Sun, 15 May 2022 19:10:45 +0200 (CEST) References: <20c51184bbe6034ed7b4be6fc3f2b36f212ea60e.1651893551.git.kyle@posteo.net> <464037be8d677efd5402d66a0c59db221cb960a6.camel@telenet.be> From: Kyle Andrews Date: Sun, 15 May 2022 16:38:44 +0000 In-reply-to: <464037be8d677efd5402d66a0c59db221cb960a6.camel@telenet.be> Message-ID: <87czge67sd.fsf@posteo.net> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Maxime, Maxime Devos writes: > [[PGP Signed Part:Undecided]] > kyle schreef op do 12-05-2022 om 02:10 [+0000]: >> Use syntax inspired by the package 'glue' > > Shouldn't this be 'r-glue'? Guix doesn't have a package named 'glue'. > Also, writing a description (+- = some factual statements) in the > imperative mood ... is technically possible, but I wouldn't recommend > it. Referring to another package for more information on what 'rust- > unglue' is about is technically possible, but a bit cumbersome for the > reader I think. Maybe you can re-use parts of the description of > 'r-glue'. > This (and r-glue too) is an R package designed to be installed and used from within R. I noticed that the Pandas python package, for example, doesn't refer to itself as python-pandas in its Guix documentation. There are numerous other instances in Guix where such library software for high-level languages refer to themselves and other related packages as within their own ecosystems instead of the Guix ecosystem. However, in this particular case I included in parenthesis "(provided by r-glue in Guix)". >> to extract matched substrings in a >> +more intuitive and compact way than by using standard regular expressions. > > This is a bit markety language. > > More generally, upstream descriptions often aren't great and require > some tweaking, expanding (and sometimes abbreviation, though not in > this particular case). The manual has some general guidelines in > (guix)Synopses and Descriptions. Thanks, I had a look. > FWIW, I consider 'emacs', 'hello' and 'sed' to have good descriptions, > though the emacs description goes a bit markety with ‘highly > customizable ... extensive documention on everything’ and such ... > though in the case of Emacs those claims appear to be actually true so > maybe it's a good description after all. > I made a few small tweaks which I feel significantly reduces the "marketing" aspect. See the included patch. Cheers, Kyle From 9a30410e850000e839002649a5f6183f174fdfa2 Mon Sep 17 00:00:00 2001 Message-Id: <9a30410e850000e839002649a5f6183f174fdfa2.1652634138.git.kyle@posteo.net> From: Kyle Andrews Date: Sun, 15 May 2022 13:01:30 -0400 Subject: [PATCH] gnu: Add r-unglue. --- gnu/packages/cran.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 5c05f20ea7..bbe18e1d67 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -33255,3 +33255,23 @@ (define-public r-zoeppritz coefficients or scattering amplitudes, for seismological P and S-waves at an interface.") (license license:gpl2+))) + +(define-public r-unglue + (package + (name "r-unglue") + (version "0.1.0") + (source + (origin + (method url-fetch) + (uri (cran-uri "unglue" version)) + (sha256 + (base32 "0w8ld4xllx0lj1jz8i2sj92f8136hlwri1d8ldpg1ymxj7aw93vg")))) + (properties `((upstream-name . "unglue"))) + (build-system r-build-system) + (home-page "https://cran.r-project.org/package=unglue") + (synopsis "Extract Matched Substrings Using a Pattern") + (description + "Use syntax inspired by the package 'glue' (provided by r-glue in +Guix) to extract matched substrings in a more compact way than by +using regular expressions.") + (license license:gpl3))) -- 2.36.0