From patchwork Wed Jul 10 13:23:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 29147 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8CCE827BBEA; Wed, 10 Jul 2024 14:24:20 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9323727BBE2 for ; Wed, 10 Jul 2024 14:24:18 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRXIc-0003n8-H2; Wed, 10 Jul 2024 09:23:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRXIa-0003my-OW for guix-patches@gnu.org; Wed, 10 Jul 2024 09:23:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRXIa-00029R-Dp; Wed, 10 Jul 2024 09:23:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRXIg-0001yC-9P; Wed, 10 Jul 2024 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72035] [PATCH] installer: Create ext4 file systems with =?utf-8?b?4oCYLU8gbGFyZ2VfZGly4oCZLg==?= Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, guix-patches@gnu.org Resent-Date: Wed, 10 Jul 2024 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72035 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72035@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe Received: via spool by submit@debbugs.gnu.org id=B.17206178387556 (code B ref -1); Wed, 10 Jul 2024 13:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jul 2024 13:23:58 +0000 Received: from localhost ([127.0.0.1]:55135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRXIb-0001xo-NB for submit@debbugs.gnu.org; Wed, 10 Jul 2024 09:23:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:32926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRXIZ-0001xe-71 for submit@debbugs.gnu.org; Wed, 10 Jul 2024 09:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRXIS-0003l0-Ol for guix-patches@gnu.org; Wed, 10 Jul 2024 09:23:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRXIS-00022L-E6; Wed, 10 Jul 2024 09:23:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=2PXDOkr+IVcgL2hEo7b6c8zL0gLLUdGMJKYfctbI3KM=; b=B19hjbhzjyj1Cs oPYv6Rfy9INJVbfGS87rV8d0NEiUKvL69bso5SQ3boUZftdrMJSs70SoSDIH+X2Yotod3vYOf1Tuw XuuwJmbQNDOi6rI17NwrcTBY+7STH0RzCjmXqWSW/IgKTnF6eXfrKDewo296SXHzkuI+BhS2cDx0F 5ficmsRZBmjTt7tNuajrBL+izHivrMYGhiofCfVZdm9az+1l0VDNd8SYJqdlsmi8BvLicj9wk4jeD ZrDGHKptno2cSoG9ZmMmR4njgNGOxvCY9O4QTRX7I92ARuyxu+tSX+nZIiIVNYHHJFhJZHc0xVxc3 cWSFIgVYhnz31gTwjQ0A==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Wed, 10 Jul 2024 15:23:32 +0200 Message-ID: <7976069f078b5ba5c7d75e4a427f35f06c70c058.1720617776.git.ludo@gnu.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/installer/parted.scm (create-ext4-file-system): Pass ‘-O large_dir’ to ‘mkfs.ext4’. Change-Id: Ie34039ed03f273505e7f7fb5c3241120e3395ba2 --- gnu/installer/parted.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) base-commit: 922e943059050f05532ac8274e55e25ebe711cf5 diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 51fa7cf9d9c..dbdec1bba82 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018, 2019 Mathieu Othacehe -;;; Copyright © 2019, 2020, 2022 Ludovic Courtès +;;; Copyright © 2019-2020, 2022, 2024 Ludovic Courtès ;;; Copyright © 2020 Tobias Geerinckx-Rice ;;; Copyright © 2022 Josselin Poiret ;;; @@ -1187,7 +1187,13 @@ (define (create-btrfs-file-system partition) (define (create-ext4-file-system partition) "Create an ext4 file-system for PARTITION file-name." - ((run-command-in-installer) "mkfs.ext4" "-F" partition)) + ;; Enable the 'large_dir' feature so users can have a store of several TiBs. + ;; Failing to do that, the directory index (enabled by 'dir_index') can fill + ;; up and adding new files would fail with ENOSPC despite there being plenty + ;; of free space and inodes: + ;; . + ((run-command-in-installer) "mkfs.ext4" "-F" partition + "-O" "large_dir")) (define (create-fat16-file-system partition) "Create a fat16 file-system for PARTITION file-name."