From patchwork Mon Apr 25 19:10:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Paul A. Patience" X-Patchwork-Id: 38897 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9002A27BBEB; Mon, 25 Apr 2022 20:11:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 21F3A27BBEA for ; Mon, 25 Apr 2022 20:11:11 +0100 (BST) Received: from localhost ([::1]:46668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nj474-0004so-9b for patchwork@mira.cbaines.net; Mon, 25 Apr 2022 15:11:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nj46w-0004rg-VG for guix-patches@gnu.org; Mon, 25 Apr 2022 15:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nj46w-0008Va-MR for guix-patches@gnu.org; Mon, 25 Apr 2022 15:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nj46w-0003bT-Gt for guix-patches@gnu.org; Mon, 25 Apr 2022 15:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55067] [PATCH v3] gnu: nomad-optimizer: Disable failing test. References: <20220422162024.91287-1-paul@apatience.com> In-Reply-To: <20220422162024.91287-1-paul@apatience.com> Resent-From: "Paul A. Patience" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Apr 2022 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55067 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55067@debbugs.gnu.org Cc: "Paul A. Patience" Received: via spool by 55067-submit@debbugs.gnu.org id=B55067.165091383313817 (code B ref 55067); Mon, 25 Apr 2022 19:11:02 +0000 Received: (at 55067) by debbugs.gnu.org; 25 Apr 2022 19:10:33 +0000 Received: from localhost ([127.0.0.1]:36114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nj46P-0003ai-4m for submit@debbugs.gnu.org; Mon, 25 Apr 2022 15:10:33 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:45268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nj46L-0003aQ-7N for 55067@debbugs.gnu.org; Mon, 25 Apr 2022 15:10:27 -0400 Date: Mon, 25 Apr 2022 19:10:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1650913817; bh=+7TSYqpu1sbx7Kx0XaoUbbs2c78EMH5c1cOjviKV12k=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID; b=DSdgzRE0MCt7tc68cedM4GRJRNw+3EW8ABroQQhbG8YUKzKdoLWGS6MAUuHw+7Pud JzFLmZr22f3O+fW/5DxuA9khw794A6YWFfQfsZJgGGLL5tTOtKAtoolScsUd1tLEiR OvG/lspzcKg0CTdr2VA7XMOhq5k9USHnwoRCZU4M+VkWo4l7myvb89gZVBUpn7ujaV WDO0g25IJCYrm4ID0148w3o30+A61PPQ4W+H2T+2h3JN6STdMOiMyRXh649AyaCRsX EqkWxbE0fsFxtjdbf1Q3lqCGA5MeN9mT+KatgVWlBQhmnyfRHbq08zn+8Rgpz/h2qi 5nZdhQfimx9hg== From: "Paul A. Patience" Message-ID: <20220425191002.58325-1-paul@apatience.com> Feedback-ID: 19227857:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/maths.scm (nomad-optimizer)[arguments]: Disable the examples/advanced/library/PSDMads test. --- I've added a link to the issue I opened upstream regarding this failing test, as suggested by Maxime Devos. gnu/packages/maths.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.35.1 diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index f4778179d6..448cdb4d73 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -45,7 +45,7 @@ ;;; Copyright © 2021 Gerd Heber ;;; Copyright © 2021 Franck Pérignon ;;; Copyright © 2021 Philip McGrath -;;; Copyright © 2021 Paul A. Patience +;;; Copyright © 2021-2022 Paul A. Patience ;;; Copyright © 2021 Ivan Gankevich ;;; Copyright © 2021 Jean-Baptiste Volatier ;;; Copyright © 2021 Guillaume Le Vaillant @@ -2008,6 +2008,10 @@ (define-public nomad-optimizer (add-after 'fix-sources-for-build 'fix-sources-for-tests (lambda _ (substitute* "examples/CMakeLists.txt" + ;; This test passes only sometimes. + ;; See https://github.com/bbopt/nomad/issues/72. + (("^ +add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/advanced/library/PSDMads\\)\n") + "") ;; examples/basic/batch/example3 is accidentally omitted. (("^(add_subdirectory\\(\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/basic/batch/example)2(\\)\n)" _ prefix suffix) @@ -2052,10 +2056,6 @@ (define-public nomad-optimizer "examples/advanced/library/exampleSuggestAndObserve/cache0.txt") (let ((builddir (string-append (getcwd) "/../build"))) - ;; For some reason, omitting this fix causes the - ;; examples/advanced/library/PSDMads test to fail, even though - ;; it doesn't seem to reference any part of the FixedVariable - ;; test. (let ((dir "examples/advanced/library/FixedVariable")) (substitute* (string-append dir "/fixedVariable.cpp") (("^( +std::string sExe = ).*" _ prefix)