From patchwork Sat Apr 23 20:00:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luis Felipe X-Patchwork-Id: 38773 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2042C27BBEA; Sat, 23 Apr 2022 21:02:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 902C327BBE9 for ; Sat, 23 Apr 2022 21:02:09 +0100 (BST) Received: from localhost ([::1]:34434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niLxI-0007r8-N4 for patchwork@mira.cbaines.net; Sat, 23 Apr 2022 16:02:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niLxC-0007r0-Kt for guix-patches@gnu.org; Sat, 23 Apr 2022 16:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1niLxC-0006jg-CX for guix-patches@gnu.org; Sat, 23 Apr 2022 16:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1niLxC-00035X-AU for guix-patches@gnu.org; Sat, 23 Apr 2022 16:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55085] [PATCH] gfeeds 0.16.2: Make it run Resent-From: Luis Felipe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Apr 2022 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55085 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55085@debbugs.gnu.org X-Debbugs-Original-To: Luis Felipe via Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.165074408011822 (code B ref -1); Sat, 23 Apr 2022 20:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2022 20:01:20 +0000 Received: from localhost ([127.0.0.1]:57306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niLwP-00034W-VS for submit@debbugs.gnu.org; Sat, 23 Apr 2022 16:01:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:43514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niLwO-00034O-F2 for submit@debbugs.gnu.org; Sat, 23 Apr 2022 16:01:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niLwO-0007oq-7F for guix-patches@gnu.org; Sat, 23 Apr 2022 16:01:12 -0400 Received: from mail-4325.protonmail.ch ([185.70.43.25]:32633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niLwK-0006hl-4X for guix-patches@gnu.org; Sat, 23 Apr 2022 16:01:11 -0400 Date: Sat, 23 Apr 2022 20:00:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1650744065; bh=CtyZtiFcK2T5NnmMolNQSO8t4s/XKOy17x2IvKAhucc=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=wA8mNCIUAL/do3lMDeyJ9nFpTCR+aUgvBLe+KPb6NcMY72F1vSwU+0Uywqr9eXJ5W aSrQD46zSxwAoQk7pcdZv3jNNe/kh6U0yRewHvXH47kVzamok66P+lN5QH2RXtfQo/ FOXCBUwEoGYbn8m1D+b/lEWXUAuHg01NB9BbVeAhLmlBHn2eOj6jvt7TubmByX7Yhm AM5KRa/zj+Wyp/WCAlXZY0KbMENy34bdyHkHDQTjNUeDaOW/6V2++U0hIvUJyu1zij bPtpYHJoVrfE6VBF9xMBiSpV9FY6DtDm+Gk3CfF3TmQSPyN9nCPG2E4gEXFx7grmJr qNtkpGMKeJECw== Message-ID: Feedback-ID: 24022468:user:proton MIME-Version: 1.0 Received-SPF: pass client-ip=185.70.43.25; envelope-from=luis.felipe.la@protonmail.com; helo=mail-4325.protonmail.ch X-Spam_score_int: 9 X-Spam_score: 0.9 X-Spam_bar: / X-Spam_report: (0.9 / 5.0 requ) AC_FROM_MANY_DOTS=2.996, BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Luis Felipe X-ACL-Warn: , Luis Felipe via Guix-patches X-Patchwork-Original-From: Luis Felipe via Guix-patches via From: Luis Felipe X-getmail-retrieved-from-mailbox: Patches This program fails to run. I attach a patch that makes it work. SYSTEM INFORMATION Guix system with the following Guix. Generation 55 Apr 18 2022 11:42:09 (current) guix 237d90a repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: 237d90a7808cfdced34b34595eba16632cbcb89e STEPS TO REPRODUCE guix shell gfeeds -- gfeeds Traceback (most recent call last): File "/gnu/store/8vbjfdq9dv8cscs28vq9iabmkz4zkqcg-gfeeds-0.16.2/bin/.gfeeds-real", line 64, in gi.require_version('WebKit2', '4.0') File "/home/yo/.guix-profile/lib/python3.9/site-packages/gi/__init__.py", line 129, in require_version raise ValueError('Namespace %s not available for version %s' % ValueError: Namespace WebKit2 not available for version 4.0 ADDITIONAL INFORMATION The problem seems to be that the current inputs of gfeeds don't provide WebKit2 4.0 but WebKit 4.1: ❯ guix shell python-pygobject webkitgtk yo@gnu[env]: ~❯ python3 Python 3.9.9 (main, Jan 1 1970, 00:00:01) [GCC 10.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import gi >>> >>> # The following fails. >>> gi.require_version("WebKit2", "4.0") Traceback (most recent call last): File "", line 1, in File "/home/yo/.guix-profile/lib/python3.9/site-packages/gi/__init__.py", line 129, in require_version raise ValueError('Namespace %s not available for version %s' % ValueError: Namespace WebKit2 not available for version 4.0 >>> >>> >>> # But the following works. >>> gi.require_version("WebKit2", "4.1") >>> POSSIBLE SOLUTION I attach a patch that makes the program import WebKit 4.1 instead. This makes the program work. As far as I could see, there is no package in Guix that provides WebKit 4.0, so I left the inputs untouched. Another option was to upgrade gfeeds to the latest (v1.0.2), but it required to package new libraries that are not available in Guix (a recent libadwaita, for example), and which I'm not able to package. Best, --- Luis Felipe López Acevedo https://luis-felipe.gitlab.io/ From 14b23d3ae7ffe5192a96a3e92e58175bd67e3497 Mon Sep 17 00:00:00 2001 From: Luis Felipe Date: Sat, 23 Apr 2022 14:14:43 -0500 Subject: [PATCH] gnu: gfeeds: Make it start. This change patches the version of WebKit required by the program to a version available in Guix, so that the program actually starts. * gnu/packages/syndication.scm (gfeeds)[arguments]: Require WebKit2 4.1 instead of 4.0, which is not available. --- gnu/packages/syndication.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm index 0417737d7d..20929aa7ad 100644 --- a/gnu/packages/syndication.scm +++ b/gnu/packages/syndication.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2018, 2019, 2021 Tobias Geerinckx-Rice ;;; Copyright © 2020 Vinicius Monego ;;; Copyright © 2021 Felix Gruber +;;; Copyright © 2022 Luis Felipe López Acevedo ;;; ;;; This file is part of GNU Guix. ;;; @@ -537,6 +538,11 @@ (define-public gfeeds (substitute* "gfeeds/confManager.py" (("mpv") (search-input-file inputs "/bin/mpv"))) #t)) + (add-after 'unpack 'patch-webkit2-version + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "bin/gfeeds.in" + (("gi\\.require_version\\('WebKit2', '4\\.0'\\)") + "gi.require_version('WebKit2', '4.1')")))) (add-after 'install 'wrap-gfeeds (lambda* (#:key outputs #:allow-other-keys) (wrap-program (string-append -- 2.35.1