From patchwork Thu Apr 21 20:09:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Hogan X-Patchwork-Id: 38731 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 86EBE27BBE9; Thu, 21 Apr 2022 21:16:39 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B4FCB27BBEA for ; Thu, 21 Apr 2022 21:16:38 +0100 (BST) Received: from localhost ([::1]:57738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhdED-0001vW-Oq for patchwork@mira.cbaines.net; Thu, 21 Apr 2022 16:16:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhd7q-0003Cs-Ai for guix-patches@gnu.org; Thu, 21 Apr 2022 16:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhd7q-0002WV-2C for guix-patches@gnu.org; Thu, 21 Apr 2022 16:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nhd7p-00042j-T6 for guix-patches@gnu.org; Thu, 21 Apr 2022 16:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55057] [PATCH core-updates] gnu: llvm-14, llvm-12: Enable RTTI. Resent-From: Greg Hogan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Apr 2022 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55057 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55057@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165057176215480 (code B ref -1); Thu, 21 Apr 2022 20:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Apr 2022 20:09:22 +0000 Received: from localhost ([127.0.0.1]:50955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhd7B-00041b-Rh for submit@debbugs.gnu.org; Thu, 21 Apr 2022 16:09:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:55858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhd7A-00041T-Ap for submit@debbugs.gnu.org; Thu, 21 Apr 2022 16:09:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhd7A-0002OE-5w for guix-patches@gnu.org; Thu, 21 Apr 2022 16:09:20 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:36532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhd73-0002TF-Ns for guix-patches@gnu.org; Thu, 21 Apr 2022 16:09:19 -0400 Received: by mail-pl1-x632.google.com with SMTP id q3so6167898plg.3 for ; Thu, 21 Apr 2022 13:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20210112.gappssmtp.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=YdDff+rK9ymMyl4csPwgSV4xe+LlL1Sksd3s5YRnOUk=; b=Dv+PDXg7IujwKNnPCDNK84xzzIoRd4CL3UT1/GAuphLgLBzpye7sX9ztci7v8ejjkA mcRK8E6rRdiaW2o8pxDxx6g4wJES3twaawsdwfG8iF9EywVoxCXRvwxwVHNFMggnk1um 1Q0Nnx/rSFDLsgVHIb/A+UdX7dKHl9QewAlAghha0V+dqP4uzI0IKhYwvMNXYhxiCDqE ESsfXF/nbCRoGid6kIeI/Sp7cLr6gwiTFdDjYmSY2831cNg5+oW66ws8UeQ+8b6pagrv vY8xgM6GTpEIYSThsTd9OsDnze7Wxre4q8TyS9VzwazJ6fOOPTRloP8UtUWxpaYoJsrX HmfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YdDff+rK9ymMyl4csPwgSV4xe+LlL1Sksd3s5YRnOUk=; b=7rgAwUFGRNbPect8GSskkojoAEySjZJQ6acSikC89a8yJfkVtreoOSpIkQieky2OBl J4SVkKP4NZCoNKgn9jyFtkyzTUY90qQyQSzz0EXxvLQKDVFYuWVsNa74sphSmPfdzckB zT88vE23XnjrfKQggUdpIas8f+dtyp40oWav2seuJyWiQmiq4HzxNEloA1XvAoKRTa6W 9dx0lf187R7d5Uzu1kkuNlxZHxPuAgF3eFhb0aisggpbWm641+zY7Cr/yq1ZDfcjPAdq 8P2xebVS2Hmho9QmowSae69YCKIIlcGOgHV+awLQixAs4kYFgdEO5xuhdHkO1XDCNOUb BfUA== X-Gm-Message-State: AOAM531lkBUfXlALrdin/C0quZytMYdr4tqSQwHKd67d8RpSSHIsoUPl j+NxnaOFD5foEAdYjELmTKWo0ABdSoykN8/wjqDQfE5f4c2EXUGQ X-Google-Smtp-Source: ABdhPJzQ8f73fe9x+PDOsUB1xqy5ZJd2L4olT91o5RIn2thkOtnxD0sCTHf55DxJflArimoZ3LK6ycQnc3jThhHPXA0= X-Received: by 2002:a17:902:be18:b0:153:2444:9c1a with SMTP id r24-20020a170902be1800b0015324449c1amr1169165pls.152.1650571751300; Thu, 21 Apr 2022 13:09:11 -0700 (PDT) MIME-Version: 1.0 From: Greg Hogan Date: Thu, 21 Apr 2022 16:09:00 -0400 Message-ID: Received-SPF: none client-ip=2607:f8b0:4864:20::632; envelope-from=code@greghogan.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches The llvm packages currently define LLVM_REQUIRES_RTTI rather than the LLVM_ENABLE_RTTI flag specified in the LLVM documentation ( https://llvm.org/docs/CMake.html). LLVM_REQUIRES_RTTI is noted as an internal flag in the llvm code ( https://github.com/llvm/llvm-project/blob/llvmorg-14.0.1/llvm/cmake/modules/AddLLVM.cmake#L15 ). This appears to have been an issue from the first Guix commit adding the LLVM_REQUIRES_RTTI flag as LLVM_ENABLE_RTTI is the flag specified in the documentation for llvm 3.8.1 ( https://releases.llvm.org/3.8.1/docs/CMake.html). $ git show 83c49858b518b98f88db5f50ce36c19084e7ad62:gnu/packages/llvm.scm LLVM_ENABLE_RTTI is propagated to the exported llvm library cmake configuration. $ grep RTTI /gnu/store/*-llvm-*/lib/cmake/llvm/LLVMConfig.cmake With all llvm packages inheriting from llvm-14 or llvm-12 this patch must go to core-updates. $ ./pre-inst-env guix search llvm | recsel -C -P version -e "name = 'llvm'" | awk '$0="llvm@"$0' | xargs ./pre-inst-env guix refresh -l Building the following 4906 packages would ensure 7034 dependent packages are rebuilt ... Greg From 0cd3048f15fcca774088ab4d5b97a0fdaa74652e Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Thu, 21 Apr 2022 19:13:50 +0000 Subject: [PATCH] gnu: llvm-14, llvm-12: Enable RTTI. * gnu/packages/llvm.scm (llvm-14, llvm-12): Enable RTTI. [arguments]<#:configure-flags>: Switch to proper CMake flag. --- gnu/packages/llvm.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) From 0cd3048f15fcca774088ab4d5b97a0fdaa74652e Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Thu, 21 Apr 2022 19:13:50 +0000 Subject: [PATCH] gnu: llvm-14, llvm-12: Enable RTTI. * gnu/packages/llvm.scm (llvm-14, llvm-12): Enable RTTI. [arguments]<#:configure-flags>: Switch to proper CMake flag. --- gnu/packages/llvm.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 8348638614..a93a1976b5 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -577,7 +577,7 @@ (define-public llvm-14 "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE" "-DBUILD_SHARED_LIBS:BOOL=TRUE" "-DLLVM_ENABLE_FFI:BOOL=TRUE" - "-DLLVM_REQUIRES_RTTI=1" ;for some third-party utilities + "-DLLVM_ENABLE_RTTI:BOOL=TRUE" ;for some third-party utilities "-DLLVM_INSTALL_UTILS=ON") ;needed for rustc ;; Don't use '-g' during the build, to save space. #:build-type "Release" @@ -711,7 +711,7 @@ (define-public llvm-12 "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE" "-DBUILD_SHARED_LIBS:BOOL=TRUE" "-DLLVM_ENABLE_FFI:BOOL=TRUE" - "-DLLVM_REQUIRES_RTTI=1" ; For some third-party utilities + "-DLLVM_ENABLE_RTTI:BOOL=TRUE" ; For some third-party utilities "-DLLVM_INSTALL_UTILS=ON")) ; Needed for rustc. ;; Don't use '-g' during the build, to save space. #:build-type "Release" -- 2.35.1