From patchwork Tue Jan 25 17:18:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Eklund X-Patchwork-Id: 36803 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9345E27BBEA; Tue, 25 Jan 2022 17:21:00 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4CB3927BBE9 for ; Tue, 25 Jan 2022 17:21:00 +0000 (GMT) Received: from localhost ([::1]:36418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCPV5-0001dN-BI for patchwork@mira.cbaines.net; Tue, 25 Jan 2022 12:20:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCPTP-0007Ep-FM for guix-patches@gnu.org; Tue, 25 Jan 2022 12:19:15 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCPTC-00069A-F7 for guix-patches@gnu.org; Tue, 25 Jan 2022 12:19:14 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCPTC-0001qQ-CU for guix-patches@gnu.org; Tue, 25 Jan 2022 12:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53525] [PATCH] gnu: Add emacs-puni Resent-From: Niklas Eklund Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 Jan 2022 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53525 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 53525@debbugs.gnu.org Received: via spool by 53525-submit@debbugs.gnu.org id=B53525.16431311047033 (code B ref 53525); Tue, 25 Jan 2022 17:19:02 +0000 Received: (at 53525) by debbugs.gnu.org; 25 Jan 2022 17:18:24 +0000 Received: from localhost ([127.0.0.1]:49956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCPSa-0001pN-5B for submit@debbugs.gnu.org; Tue, 25 Jan 2022 12:18:24 -0500 Received: from mout01.posteo.de ([185.67.36.65]:37917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCPSX-0001p8-Sb for 53525@debbugs.gnu.org; Tue, 25 Jan 2022 12:18:22 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9A5ED240027 for <53525@debbugs.gnu.org>; Tue, 25 Jan 2022 18:18:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1643131095; bh=kR4PbEBCCbtoqvzvy/yTn7OO5kZoIhBsM1wBGyRvJ6w=; h=From:To:Cc:Subject:Date:From; b=ZenZVj/5S9FatUwYk69r8BmmrN8fBGgrlVzj3XdduRodsPTzvfEpoysgDTBTaxDIe ZuOVXcqYPT+32ma0/uTDYBByn2p/fef8iz/MPOno0vJop4eniKJgpxuQiSdoNqHjyA ZtqZQzRUgmgOqWAof6RNNJ8CF5WNMSHwDfJl2zrucpvfG++amE4L/DuJYebPsy4bQn MAUimuKt3/j4SjjnDopmE7R4WXr2geqXnogI70/sEsJGHvQ0dxoGqE5RCBXFme/0zA oVGslN698fdgREhs+/EZ7uvSUGxctVshOTr17DqdPJ1+JGLRUBfpS8Q7U2raj4m+F5 y0W0b0E/3xZMQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Jjtpt4P0Hz9rxD; Tue, 25 Jan 2022 18:18:14 +0100 (CET) From: Niklas Eklund In-Reply-To: <87a6fjbv4d.fsf@nicolasgoaziou.fr> References: <875yq7pxv4.fsf@posteo.net> <87a6fjbv4d.fsf@nicolasgoaziou.fr> Date: Tue, 25 Jan 2022 17:18:13 +0000 Message-ID: <874k5rlooa.fsf@posteo.net> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Nicolas Goaziou writes: > Hello, > > Niklas Eklund writes: > >> Subject: [PATCH] gnu: Add emacs-puni > > Thank you. > >> +(define-public emacs-puni >> + ;; No tagged release upstream >> + (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") (revision "0")) > > Nitpick: could you add a newline character between (commit ...) and > (revision ...)? Oops, how did that end up there, of course! >> + (home-page "https://github.com/AmaiKinono/puni") >> + (synopsis "Parentheses Universalistic") > > This synopsis is not very useful. Could you expound it a bit? Will give it a go :) >> + (description >> + "Structured editing (soft deletion, expression navigating & manipulating) that supports many major modes out of the box.") > > Description are expected to consist of full sentences. I suggest: > > Puni is an Emacs minor mode for structured editing: soft deletion, > expression navigating and manipulating. It supports many major modes > out of the box. > > Could you send an updated patch? > > Regards, > -- > Nicolas Goaziou Absolutely, thanks for the feedback :) Here is an updated patch. Best regards, Niklas From 7c1a30a2567d85bd10d6a767358bafa67f8fc610 Mon Sep 17 00:00:00 2001 From: Niklas Eklund Date: Tue, 25 Jan 2022 17:42:48 +0100 Subject: [PATCH] gnu: Add emacs-puni --- gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 387f1b93fd..9d9adbb1e5 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -633,6 +633,32 @@ (define-public emacs-paredit when typing parentheses directly or commenting out code line by line.") (license license:gpl3+))) +(define-public emacs-puni + ;; No tagged release upstream + (let ((commit "ed4a863460329a3019c286ff382e2ddc0ffdc9d7") + (revision "0")) + (package + (name "emacs-puni") + (version (git-version "0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/AmaiKinono/puni") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "14lcqf0qdkq2rklx12v12qpgfahz2bpqmnl3bzcz5myawgjjcphd")))) + (build-system emacs-build-system) + (propagated-inputs (list emacs-with-editor)) + (home-page "https://github.com/AmaiKinono/puni") + (synopsis "Emacs minor mode for structured editing") + (description + "Puni is an Emacs minor mode for structured editing: soft deletion, +expression navigating and manipulating. It supports many major modes +out of the box.") + (license license:gpl3+)))) + (define-public emacs-project (package (name "emacs-project") -- 2.32.0