From patchwork Thu Jan 6 09:46:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 35997 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 83DA127BBEA; Thu, 6 Jan 2022 10:07:42 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 440C327BBE9 for ; Thu, 6 Jan 2022 10:07:42 +0000 (GMT) Received: from localhost ([::1]:35800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5PgL-0008Im-CL for patchwork@mira.cbaines.net; Thu, 06 Jan 2022 05:07:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PMV-0007oO-6i for guix-patches@gnu.org; Thu, 06 Jan 2022 04:47:11 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5PMN-0006sa-BZ for guix-patches@gnu.org; Thu, 06 Jan 2022 04:47:10 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5PMM-0001Qk-B7; Thu, 06 Jan 2022 04:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53045] [PATCH] services: networking: Add netmask to loopback address. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: Yann.Dupont@univ-nantes.fr, guix-patches@gnu.org Resent-Date: Thu, 06 Jan 2022 09:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53045 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53045@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Yann Dupont X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Yann Dupont Received: via spool by submit@debbugs.gnu.org id=B.16414623825445 (code B ref -1); Thu, 06 Jan 2022 09:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jan 2022 09:46:22 +0000 Received: from localhost ([127.0.0.1]:39682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PLi-0001Pl-9Z for submit@debbugs.gnu.org; Thu, 06 Jan 2022 04:46:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:45888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PLf-0001Pc-AW for submit@debbugs.gnu.org; Thu, 06 Jan 2022 04:46:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PLe-0006w7-0q for guix-patches@gnu.org; Thu, 06 Jan 2022 04:46:19 -0500 Received: from [2001:470:142:3::e] (port=39448 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PLc-0006de-Hw; Thu, 06 Jan 2022 04:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=Mi7cAnM4o7vLPGUBGTLJkYmn3mIxP5UuMzUoIj98xNo=; b=JXrzsEJbdlBHzM 25DbymR35oyji2NbCxrp1D7eghZNWaUxICn7VoJgWxC8EWkrBsNwA/yuKM6Mha3rX+RYuuGYVFfA2 Vnm7Ly0JCbKnl2XGYU/Kp5+NBzxjf7I2Tb2aLxH6I7x11OWzxs1f0npunc75jSc0o1T5ZJhq+pFc4 lpQr37GCJDdDPY7w8AEwfRfouW3/RrGNJQVCvxGoaJSoHeLIwE16d4tmlEjOB2M95WCEZHErBbhGy nMZawCis3yPrTt0CgQK1nJzhZ191Jqg0SkgLgkWtuQCV6awB4BPc2x5vqOZY4hTmnX8CRXfVc1bLA X6JyG/8PzrxLMOqlJOBg==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34736 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5PLZ-0003vZ-UL; Thu, 06 Jan 2022 04:46:15 -0500 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Thu, 6 Jan 2022 10:46:03 +0100 Message-Id: <20220106094603.11283-1-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches From: Ludovic Courtès Previously, we would get a fishy 127.0.0.1/0 interface: $ ip a show dev lo 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet 127.0.0.1/0 scope global lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever With this change, we get nothing but the "/8" version: $ ip a show dev lo 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope global lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever Reported by Yann Dupont . * gnu/services/base.scm (assert-valid-address): Remove special cases for 127.0.0.1 and ::1. (%loopback-static-networking): Add "/8". --- gnu/services/base.scm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) base-commit: 97657689507a0681aa9699407d292383ff22c330 diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 88869e40d2..e46bb591a9 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Ludovic Courtès +;;; Copyright © 2013-2022 Ludovic Courtès ;;; Copyright © 2015, 2016 Alex Kost ;;; Copyright © 2015, 2016, 2020 Mark H Weaver ;;; Copyright © 2015 Sou Bunnbu @@ -2393,11 +2393,7 @@ (define (ipv6-address? str) (define-compile-time-procedure (assert-valid-address (address string?)) "Ensure ADDRESS has a valid netmask." - (unless (or (cidr->netmask address) - (and=> (false-if-exception (inet-pton AF_INET address)) - (cut = INADDR_LOOPBACK <>)) - (and=> (false-if-exception (inet-pton AF_INET6 address)) - (cut = 1 <>))) + (unless (cidr->netmask address) (raise (make-compound-condition (formatted-message (G_ "address '~a' lacks a network mask") @@ -2741,7 +2737,7 @@ (define %loopback-static-networking (static-networking (addresses (list (network-address (device "lo") - (value "127.0.0.1")))) + (value "127.0.0.1/8")))) (requirement '()) (provision '(loopback))))