From patchwork Sun Dec 26 21:32:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 35673 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0C00D27BBE9; Sun, 26 Dec 2021 21:33:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id AAA1727BBEA for ; Sun, 26 Dec 2021 21:33:12 +0000 (GMT) Received: from localhost ([::1]:53640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1b8h-00023r-RD for patchwork@mira.cbaines.net; Sun, 26 Dec 2021 16:33:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1b8Y-00023i-N9 for guix-patches@gnu.org; Sun, 26 Dec 2021 16:33:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1b8Y-0007O4-A9 for guix-patches@gnu.org; Sun, 26 Dec 2021 16:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1b8Y-0001JZ-8U for guix-patches@gnu.org; Sun, 26 Dec 2021 16:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52690] [PATCH] gnu: IcedTea: Prohibit references to nss-certs. References: In-Reply-To: Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Dec 2021 21:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52690 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 52690@debbugs.gnu.org Received: via spool by 52690-submit@debbugs.gnu.org id=B52690.16405543685030 (code B ref 52690); Sun, 26 Dec 2021 21:33:02 +0000 Received: (at 52690) by debbugs.gnu.org; 26 Dec 2021 21:32:48 +0000 Received: from localhost ([127.0.0.1]:41730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1b8J-0001J3-TW for submit@debbugs.gnu.org; Sun, 26 Dec 2021 16:32:48 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1b8I-0001Il-0a for 52690@debbugs.gnu.org; Sun, 26 Dec 2021 16:32:46 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B99DB32009C3; Sun, 26 Dec 2021 16:32:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 26 Dec 2021 16:32:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=A7Xf7EGwCx5TGPiZTIekBpA YRbkiFlkby8JvVRS2jLQ=; b=oL9dclhnszf7V78lnnL2RsN3myBrIIot+V/g4TU 1mzuara8quC7b+sGX2buWYeomrSrOWXS2mwAm7z85FJES55mI48HRjvx3rO/jWNy pGPcJSfMKK6RrYiwcO5s88wZv0P2VE8hmJbr5HNnYYP7m7WoaGOp4hii6KjtDrj8 wpc8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=A7Xf7EGwCx5TGPiZT IekBpAYRbkiFlkby8JvVRS2jLQ=; b=EKk+gZEzAphVujra72wmscBkrDLGxBFgw CA0c1HuGBQm1INnnetF7aWxYKXK9krUp4Og8vUFRlfIgKJCMRPGuOVbif87dsn/x x60JqPACM8qKz2/EArB8CM+WGoIN0IP1YVJZvj5xEolEEhnDccIabJ/KdHDfgc8q GrNLpHuce4OT4UXg3QpaDSRaEJ/fqbQIlH1O8SJmv+F03/Ux8tCIQIBbLlKrLaRa klY23dyEUFgIso6jAk+UJfUa8yyWmCmlftEdxQXGjKV1EK11MvuNwIRZHBSgT7uQ QGxgbWors6Xsqy1QjS+0+9JE6yJ0p2QbboP92dYLgqcGl7X6pP9Kg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddugedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepteeuiefgleehkeevffevteffueegueduvd egieffveekuefffeetuddvhffhudfhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for <52690@debbugs.gnu.org>; Sun, 26 Dec 2021 16:32:38 -0500 (EST) From: Leo Famulari Date: Sun, 26 Dec 2021 16:32:33 -0500 Message-Id: <6fca92dfa3101c383f62c2569d87ff4e48e63764.1640554102.git.leo@famulari.name> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches I checked, and neither of these packages keep references to nss-certs. So, although this change will cause rebuilds, it shouldn't cause any functional changes. However, my understanding is that the IcedTea packages actually copy the NSS certificate store, so there wouldn't be a reference anyways, but we would have the problem of "software that expires". Built packages should not refer to nss-certs, to prevent errant hard-coding of a certificate store version. * gnu/packages/java.scm (icedtea-7, icedtea-8)[arguments]: Add nss-certs to #:disallowed-references. --- gnu/packages/java.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index 0a757b2391..91a16bb53d 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -812,6 +812,8 @@ (define-public icedtea-7 ;; gremlin) doesn't support it yet, so skip this phase. #:validate-runpath? #f + #:disallowed-references (,nss-certs) + #:modules ((guix build utils) (guix build gnu-build-system) (ice-9 match) @@ -1376,7 +1378,8 @@ (define-public icedtea-8 (guix build syscalls) ,@%gnu-build-system-modules) - #:disallowed-references ,(list (gexp-input icedtea-7 "jdk")) + #:disallowed-references ,(list (gexp-input icedtea-7 "jdk") + nss-certs) ,@(substitute-keyword-arguments (package-arguments icedtea-7) ((#:modules modules)